[Koha-bugs] [Bug 24368] Koha::Libraries->pickup_locations needs refactoring/ratifying

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24368

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Regarding the failing tests from bug 25421, I am not sure what you provided is
equivalent.
The POD of Koha::Libraries->pickup_locations said "-    C. none of the above,
simply all libraries with pickup_location => 1", but it's wrong, the code is:

    my @pickup_locations;
    foreach my $library ($libraries->as_list) {
        if ($item && $item->can_be_transferred({ to => $library })) {
            push @pickup_locations, $library->unblessed;
        } elsif ($biblio && $biblio->can_be_transferred({ to => $library })) {
            push @pickup_locations, $library->unblessed;
        }
    }

With this change we are loosing the "can_be_transferred" conditions.

-- 
You are receiving this mail because:
You are watching all bug changes.