[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 104637
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104637
Bug 25440: Fix for "uninitialized value in string eq" in smart-rules.pl

Review of attachment 104637:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25440&attachment=104637)
-----------------------------------------------------------------

::: admin/smart-rules.pl
@@ +284,5 @@
>      my $opacitemholds = $input->param('opacitemholds') || 0;
>      my $article_requests = $input->param('article_requests') || 'no';
>      my $overduefinescap = $input->param('overduefinescap') || '';
> +    my $cap_fine_to_replacement_price = $input->param('cap_fine_to_replacement_price');
> +    $cap_fine_to_replacement_price = $cap_fine_to_replacement_price && $cap_fine_to_replacement_price eq 'on';

What about

cap_fine_to_replacement_price = ($cap_fine_to_replacement_price || '') eq 'on';

-- 
You are receiving this mail because:
You are watching all bug changes.