[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 104635
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104635
Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl

Review of attachment 104635:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25440&attachment=104635)
-----------------------------------------------------------------

::: admin/smart-rules.pl
@@ -253,5 @@
>      my $fine = $input->param('fine');
>      my $finedays     = $input->param('finedays');
>      my $maxsuspensiondays = $input->param('maxsuspensiondays');
> -    $maxsuspensiondays = undef if $maxsuspensiondays eq q||;
> -    $maxsuspensiondays = '' if $maxsuspensiondays eq q||;

Maybe a bit radical :)

This is coming from a bad merge resolution conflict, I think it should be:
my $maxsuspensiondays = $input->param('maxsuspensiondays') || q||;

Just a feeling, it should be tested.

-- 
You are receiving this mail because:
You are watching all bug changes.