[Koha-bugs] [Bug 26727] Fix <p/> appearing in the templates

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #3)
> Comment on attachment 112761 [details] [review]
> Bug 26727: Fix <p/> appearing in the templates
> 
> Review of attachment 112761 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
> @@ +90,4 @@
> >  
> >                                  <fieldset class="rows">
> >                                      <legend>Place article request from [% biblio.title | html %] for [% patron.firstname | html %] [% patron.surname | html %] ( [% patron.cardnumber | html %] )</legend>
> > +                                    <p>

We use HTML5 - we don't need closing <p>, see:

https://www.w3.org/TR/2010/WD-html-markup-20100624/p.html
A p element’s end tag may be omitted if the p element is immediately followed
by an address, article, aside, blockquote, dir, div, dl, fieldset, footer,
form, h1, h2, h3, h4, h5, h6, header, hr, menu, nav, ol, p, pre, section,
table, or ul element, or if there is no more content in the parent element and
the parent element is not an a element.

In this case, the following tag is <ul>.

> 
> Hmm, not sure about this one.. won't it result in an unmatched tag? (i.e. I
> can't see a closing </p> anywhere beneath this opening <p>)
> 
> :::
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
> @@ +220,4 @@
> >                                  </span>
> >                              </span>
> >  
> > +                            <br><br>
> 
> Why a double <br> here compared to a single <br> in
> koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt ?

I believe "looks". It was using a br br in another spot in the same file and I
wanted to achieve the same 'distance'. It's not the cleanest way to do this,
but I wanted to aim for making the HTML templates valid first.

-- 
You are receiving this mail because:
You are watching all bug changes.