[Koha-bugs] [Bug 26727] Fix <p/> appearing in the templates

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi

--- Comment #5 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Katrin Fischer from comment #4)
> (In reply to Martin Renvoize from comment #3)
> > Comment on attachment 112761 [details] [review] [review]
> > Bug 26727: Fix <p/> appearing in the templates
> > 
> > Review of attachment 112761 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
> > @@ +90,4 @@
> > >  
> > >                                  <fieldset class="rows">
> > >                                      <legend>Place article request from [% biblio.title | html %] for [% patron.firstname | html %] [% patron.surname | html %] ( [% patron.cardnumber | html %] )</legend>
> > > +                                    <p>
> 
> We use HTML5 - we don't need closing <p>, see:
> 
> https://www.w3.org/TR/2010/WD-html-markup-20100624/p.html
> A p element’s end tag may be omitted if the p element is immediately
> followed by an address, article, aside, blockquote, dir, div, dl, fieldset,
> footer, form, h1, h2, h3, h4, h5, h6, header, hr, menu, nav, ol, p, pre,
> section, table, or ul element, or if there is no more content in the parent
> element and the parent element is not an a element.
> 
> In this case, the following tag is <ul>.

So then there is a paragraph with no content. That doesn't make any sense to
me, in that case the paragraph tag should be just removed. If it is for styling
reason it should be done in CSS instead of HTML.

-- 
You are receiving this mail because:
You are watching all bug changes.