[Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658

Cindy Murdock Ames <cmurdock at ccfls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cmurdock at ccfls.org

--- Comment #6 from Cindy Murdock Ames <cmurdock at ccfls.org> ---
I am also seeing this on 19.11.  My plack-error.log shows the error below when
it occurs, and if I change the itemnumber to NULL for the deleted item's fine
in accountlines the ISE doesn't happen:  

Template process failed: undef error - DBIC result _type  isn't of the _type
Biblio at
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/members/pay.tt
line 96.

This is line 96 from pay.tt:
        [% IF line.itemnumber %]
            <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[%
line.itemnumber | uri %]&biblionumber=[% line.item.biblionumber | uri
%]#item[% line.itemnumber | uri %]">[% line.item.barcode | html %]</a>


I am not sure what method staff used when deleting the item, but since it was a
magazine I suspect they used the batch deletion tool.

Wouldn't it be better to add some error handling in pay.tt so it doesn't fail
if it can't find the record it's trying to link to?

-- 
You are receiving this mail because:
You are watching all bug changes.