[Koha-bugs] [Bug 26547] Move context from msgid to msgctxt in pref PO files

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26547

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111557|0                           |1
        is obsolete|                            |

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 111697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111697&action=edit
Bug 26547: Move context from msgid to msgctxt in pref PO files

String extraction for system preferences was putting context inside
msgid. For instance:

    # Accounting > Policy
    msgid "accounting.pref#FinePaymentAutoPopup# automatically display "
    "a print dialog for a payment receipt when making a payment.."

Now context is put into msgctxt, and the reference is set, which is
cleaner

    #:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
    msgctxt "Accounting > Policy > FinePaymentAutoPopup"
    msgid "automatically display a print dialog for a payment receipt "
    "when making a payment.."

The downside is that some messages will have to be re-translated,
especially short messages like 'Do', for which msgmerge has a hard
time finding the corresponding new msgid.

Test plan:
1. Run `gulp po:update`
2. Verify the contents of updated pref PO files
3. Run `cd misc/translator && ./translate install <lang>`
4. Verify that sysprefs are correctly translated
5. Run `prove t/misc/translator/xgettext-pref.t`

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.