[Koha-bugs] [Bug 24718] Introduce hour-based holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #41 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Nick Clemens from comment #32)
> Hi Aleisha,
> 
> The comment on the syspref says jobs will be run hourly - probably should
> say something like:
> NOTE: This system preference requires the misc/cronjobs/holds/ cronjobs. Ask
> your system administrator to schedule them. 

Fixed 

> 
> When confirming a hold the max pickup delay is added for days correctly,
> however, the time part is set to 00:00:00 - I thin it should be preserved
> from original setting or set to 23:59:59

Fixed (note, this is for when setting a hold as waiting). It now preserves
minutes and seconds

> 
> t/db_dependent/api/v1/holds.t fails - should we accept a simple date and use
> 23:59:59 if time not specified? I am not sure how it is handled for checkouts

The same tests in this test file fail for me, before and after the patches, so
I can't test this one. Can you please paste the output for what fails and be
more specific when you say 'should we accept a simple date'?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.