[Koha-bugs] [Bug 24718] Introduce hour-based holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #42 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Aleisha Amohia from comment #41)
> > t/db_dependent/api/v1/holds.t fails - should we accept a simple date and use
> > 23:59:59 if time not specified? I am not sure how it is handled for checkouts
> 
> The same tests in this test file fail for me, before and after the patches,
> so I can't test this one. Can you please paste the output for what fails and
> be more specific when you say 'should we accept a simple date'?
> 
> Thanks!

I filed bug 26463 - the tests fail for me if AllowHoldPolicyOverride is set,
otherwise they pass before these patches.

I will attach a list of failures I see after the patches.

By 'simple date' I meant we should not expect/require the time part of the
date, but fall back to a default. Though I am not sure where I saw that as
needed

It may be the problem is in api/v1/swagger/definitions/hold.json where
hold_date and expiration_date are defined as "format": "date" and may need to
be "date-time" with these patches?

-- 
You are receiving this mail because:
You are watching all bug changes.