[Koha-bugs] [Bug 24132] search_with_library_limits vs filter_by_branch_limitations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24132

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #0)
> Aside from the naming of these two subroutines (implemented at different
> times), Koha::Patron::Attribute::Types->search_with_library_limits and
> Koha::Patron::Attributes->filter_by_branch_limitations looks similar and
> that the code must be simplified.
> 
> The join table is between borrower_attribute_types and branches
> (borrower_attribute_types_branches). So Koha::Patron::Attribute::Types can
> inherit directly from Koha::Objects::Limit::Library, not
> Koha::Patron::Attributes
> 
> There are a couple of ways to deal with that:
> 1. Improve Koha::Objects::Limit::Library => Sounds wrong as there is no join
> table between borrower_attributes and branches
> 2. Remove Koha::Patron::Attributes->filter_by_branch_limitations and replace
> it by something like: 
>   my $attribute_types = Koha::Patron::Attribute::Types
>                          ->search_with_library_limits;
>   my $attribute = $patron->extended_attributes
>                          ->search({ code => { -in =>
> attribute_types->column('code') } });
> Which sounds more correct.

I agree with the latter, Jonathan. Let me know if we can sort this one for
21.05, to finish this consistency rewrite.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.