[Koha-bugs] [Bug 28161] New: Allow Koha::Patron->extended_attributes be passed a library_id

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 16 21:07:41 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28161

            Bug ID: 28161
           Summary: Allow Koha::Patron->extended_attributes be passed a
                    library_id
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Koha::Patron::Attributes->filter_by_branch_limitations accepts the parameter,
and falls back to C4::Context->userenv->{branch} if omitted.

Lacking the parameter in Koha::Patron->extended_attributes makes it always
fallback to userenv, thus forcing the caller to deal with that instead of just
passing the parameter.

Examples:
- A CLI script with a --library_id param for setting extended attributes would
be forced to mock a userenv for checks to work
- An API route would need to deal with that as well.

A minor and harmless change adding this parameter would allow more
straight-forward use of this method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list