[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

--- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #46)
> 5. in circ/transferstosend.pl
> +    show_date    => output_pref(                                           
> 
> +        { dt => dt_from_string, dateformat => 'iso', dateonly => 1 }
> +    )
> 
> I'd pass {today => dt_from_string}, it should be enough.

Done in followup on branch

> 6. in circ/transferstosend.tt
> [% FOREACH branchesloo IN branchesloop %]                                   
>
> should be
> [% FOREACH library IN libraries %]

Done in followup on branch

> 7. There are some indentation inconsistencies in circ/transferstosend.tt

Not sure I'm seeing the same thing you are.. need a bit of clarification

> 8. (not blocker) transferCollection.tt
> +                        [%- SWITCH message.type -%]
> +                            [%- CASE 'failure' %]
> ...
> +                            [%- CASE 'enqueu' -%]
> 
> The usual pattern is
> push @message, 
> {
>   type => 'error', # or message
>   code => 'enqueu(ed?)',
>   %more_variables 
> }

Struggling to find an example.. happy to change but struggling to understand
the minute

-- 
You are receiving this mail because:
You are watching all bug changes.