[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Martin Renvoize from comment #53)
> (In reply to Jonathan Druart from comment #46)

> > 7. There are some indentation inconsistencies in circ/transferstosend.tt
> 
> Not sure I'm seeing the same thing you are.. need a bit of clarification

 69                                     </tr>
 70                                     [% END %]
 71                                     [% END %]
 72                                 </tbody>
 73                             </table>
 74                             [% END %]
 75                         [% END %]
 76                         </div>
 77                         [% ELSE %]
 78                         <p>No transfers to send</p>
 79                         [% END %]


> > 8. (not blocker) transferCollection.tt
> > +                        [%- SWITCH message.type -%]
> > +                            [%- CASE 'failure' %]
> > ...
> > +                            [%- CASE 'enqueu' -%]
> > 
> > The usual pattern is
> > push @message, 
> > {
> >   type => 'error', # or message
> >   code => 'enqueu(ed?)',
> >   %more_variables 
> > }
> 
> Struggling to find an example.. happy to change but struggling to understand
> the minute

% git grep 'push @messages'
will return a lot of examples :)

-- 
You are receiving this mail because:
You are watching all bug changes.