[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1080-g63820d3

Git repo owner gitmaster at git.koha-community.org
Sun Sep 8 21:41:23 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  63820d3973dae7514556172665a46c0584aaefc8 (commit)
      from  bc240a908d0fbc50b099df04e61da9fbb55fab52 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 63820d3973dae7514556172665a46c0584aaefc8
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Wed Sep 4 11:18:11 2013 +0100

    Bug 10817: return hold items info in SIP Patron Info Response
    
    When requested by the summary flags the sipserver
    should return in the patron info response barcodes of
    the relevant titles.
    
    For available holds this is the barcode of the captured items.
    
    For unavailable holds ( i.e. current unsatisfied holds ),
    we need to send a barcode so that the unit can use this to
    request the title info. The barcode could be any one
    belonging to the title.
    
    This patch also corrects the erroneous return of empty items
    in the patron information response. If the unit supplies a
    range 1 - 100 unless the title has a hundred or more copies the
    unit expects all copies. The server was erroneously stuffing
    the returned arrays with null copies so that all summary requests
    returned 100 copies (mainly without barcodes)
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    
    Testing notes:
    Using the test script provided on the bug report, but changed it
    to match sip user and patron existing in my database.
    
    Before applying the patch the SIP responses show the behaviour
    pointed out above regarding the 100 items. After applying the
    patch and restarting the SIP server responses are much more clean
    not returning empty IDs.
    
    64 Patron information response
    AS = hold items
      hold items count is correct.
      AS contains barcodes of waiting holds.
      Before patch, all AS were empty.
    AT = overdue items
      overdue items count is correct.
      AT contains barcodes of overdue items.
    AU = charged items
      charged items count is correct.
      AU contains barcodes of charged items.
    AV = fine items
      Judging from behaviour seen and comment in
      Patrons.pm currently not implemented.
    BU = recall items
      Recalls are not implemented in Koha yet.
    CD = unavailable hold items
      unavailable items count is correct.
      CD contains barcode for item level holds and is empty
      for title level holds where  no item can be determined.
      Before patch, all CD were empty.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/ILS/Patron.pm |   55 ++++++++++++++++++++++++++++++++++++++++---------
 1 files changed, 45 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list