[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1082-g995a270

Git repo owner gitmaster at git.koha-community.org
Sun Sep 8 22:20:48 CEST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  995a270dd10bd2dd56222fcdcb29ab033fad567e (commit)
       via  ec09fe092e302dfbaf8ddf2a26ab361be9ea915e (commit)
      from  63820d3973dae7514556172665a46c0584aaefc8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 995a270dd10bd2dd56222fcdcb29ab033fad567e
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Thu Jul 25 09:37:34 2013 +0200

    Bug 10630: give DelBookseller() a return value
    
    This patch makes DelBookseller returns the number of suppliers it has
    deleted or undef if an error has occurred.
    
    It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t
    
    To test:
    prove t/db_dependent/Bookseller.t
    t/db_dependent/Bookseller.t .. 1/54
    All tests successful.
    Files=1, Tests=54,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.48 cusr  0.02 csys =  0.52 CPU)
    Result: PASS
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Logical change and makes another test pass :)
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit ec09fe092e302dfbaf8ddf2a26ab361be9ea915e
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date:   Tue Aug 13 14:55:32 2013 +0200

    Bug 10718: fix items with no checkouts report
    
    Bug 8124 has commented the option to download results items with no
    checkouts report into a file.  But the perl code of this page uses
    the export into a file has default behavior since the input "output"
    is no more present.  The consequence is that there are never results
    in page.
    
    This patch removes the code concerning file output from template and perl.
    Such a feature exists in guided reports.
    
    Test plan :
    Play with cgi-bin/koha/reports/catalogue_out.pl form and see if you get results
    
    Bug 10718 - select user branch as default
    
    In cgi-bin/koha/reports/catalogue_out.pl report, select in library filter the user logged-in.
    
    Test plan :
    - Log into intranet with a normal user
    - Got to "Items with no checkouts" reports
    => Your branch is selected
    - Run report
    => You see "Filtered on : Branch = <your branch>"
    - Come back to report
    - Select "Any library"
    - Run report
    => You do not see "Filtered on : Branch"
    
    Bug 10718 - items with no checkouts report permission is execute_reports
    
    This report only executes SQL to change reports/catalogue_out.pl permissions from all reports subpermissions to reports/execute_reports.
    
    Test plan :
    Test you can access and run this report with only execute_reports subpermission into reports permission.
    
    Bug 10718 - redefine limit input
    
    In reports/catalogue_out.pl form, the limit input is by defaut none.
    So by default the report queries all the catalogue.
    This may take a very long time (fall into timeout) and since now the results are displayed in page, the page may be huge.
    
    This patch modifies limit input to removes the "none" option.
    Also reduces the number of options (same options as guided reports results per page).
    
    Test plan:
    - Go to reports/catalogue_out.pl
    => first value "10" is selected
    - Launch report
    => You see "Filtered on: limit = 10"
    
    Bug 10718 - perltidy on reports/catalogue_out.pl
    
    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Tested all of these things, all ok - squashed patch for neatness.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.
    Fixed a tab in one of the comments.
    Improves script, but more work needed.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Bookseller.pm                                   |    3 +-
 .../prog/en/modules/reports/catalogue_out.tt       |   53 ++--
 reports/catalogue_out.pl                           |  330 +++++++++-----------
 t/db_dependent/Bookseller.t                        |    5 +-
 4 files changed, 174 insertions(+), 217 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list