[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.04-62-g5ff99f6

Fri Sep 13 19:09:46 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  5ff99f63e32212071cc1e71749f93e943f005005 (commit)
       via  afbc6e2e8a62ae2200e53ec61960e6297916dcc0 (commit)
       via  5f4c95947cc2512ec425bfabbd88d412a2e213f6 (commit)
       via  1190c1044413f1431d472f34469430434d4e64d7 (commit)
       via  46144ea08fd15636c65eef4a094c70ae4eeab9fc (commit)
       via  13936914dad62aa4cfa0c39e90544dec3e53f99b (commit)
       via  5ddc1f43fb18679fadd80d17bb4a45b2d2a6b87b (commit)
       via  a1c831bf43a563a116e9161b2b9381c9434669da (commit)
       via  45f9a4a0385967f5e4dfd2ff4b77412353d77a83 (commit)
       via  e647d4e3ed887510db6bf7754bbd37c0401c3999 (commit)
       via  1ad01972ca995bc938ffe55fd43e7a69e03aca5c (commit)
      from  b64c9255fc14a8b812585990ad3bad2e726365c7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5ff99f63e32212071cc1e71749f93e943f005005
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Tue Jul 23 15:27:23 2013 +0200

    Bug 10629: remove inappropriate uses of $sth->finish() in C4::Branch

    Test plan :
    Check if the regression tests still works
    prove t/db_dependent/Branch.t
    t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207.
    t/db_dependent/Branch.t .. ok
    All tests successful.
    Files=1, Tests=36,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.12 cusr  0.00 csys =  0.16 CPU)
    Result: PASS

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    From the man page

    finsh()
    Indicate that no more data will be fetched from this statement handle
    before it is either executed again or destroyed.
    You almost certainly do not need to call this method.

    Adding calls to "finish" after loop that fetches all rows is a common
    mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 4287fd9d1c3ae16a0496b6261de44642bc92ab9c)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit afbc6e2e8a62ae2200e53ec61960e6297916dcc0
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Aug 28 14:24:34 2013 +0000

    Bug 10508: (follow-up) remove Perl 5.14 construct

    Also added parentheses to bare function calls.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 7fa8e92e8e261f822b610da65b28a094e21e452c)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 5f4c95947cc2512ec425bfabbd88d412a2e213f6
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Tue Aug 27 10:29:42 2013 +1200

    Bug 10508: (follow-up) fix a typo

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Thx for the follow-up Chris!

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 7a6bd88e497901bd7dc02e1964717da20313c0d8)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 1190c1044413f1431d472f34469430434d4e64d7
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Tue Jul 2 14:24:08 2013 +0200

    Bug 10508: add unit tests for C4::Branch

    Unit tests are wrap in a transaction.

    To test:
    prove t/db_dependent/Branch.t
    t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207.
    t/db_dependent/Branch.t .. ok
    All tests successful.
    Files=1, Tests=36,  1 wallclock secs ( 0.02 usr  0.02 sys +  0.13 cusr  0.01 csys =  0.18 CPU)
    Result: PASS

    http://bugs.koha-community.org/show_bug.cgi?id=10508
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes all tests and QA script.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 68bf770f9238d6b05b9383e521969a6782b068d5)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 46144ea08fd15636c65eef4a094c70ae4eeab9fc
Author: Magnus Enger <magnus at enger.priv.no>
Date:   Tue Aug 6 16:00:01 2013 +0200

    Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL

    The descriptions for OPACBaseURL and staffClientBaseURL are not explicit
    about including a trailing slash or not. This patch makes it explicit
    that the trailing slash should *not* be included.

    To test:
    - Apply the patch
    - Search for "baseurl" in the system preferences
    - Check that the description of both sysprefs includes a warning about
      not including a trailing slash.
    - Sign off

    If you want to check that the trailing slash is in fact superfluous you
    can do something like 'grep -r "BaseURL" *' and check that these
    sysprefs are usually concatenated with some string that starts with a
    slash.

    Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Changes to the description appear correctly on both system
    preferences.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit da40fe77fc471cfe8e797a7be5f87a506cf9d921)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 13936914dad62aa4cfa0c39e90544dec3e53f99b
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Aug 19 14:48:00 2013 -0400

    Bug 10130: widen input fields for library configuration

    Most input fields in the library entry form (admin/branches.pl) have no
    explicit width, so they display with a browser-default width. This patch
    gives explicit widths to those fields, giving more room for entry.

    Other fields have been given an explicit width and/or maxwidth according
    to the database table structure.

    To test, add or edit a library in Administration -> Libraries and
    Groups. Form fields should be more comfortable for entry, and add/edit
    actions should complete correctly.

    Signed-off-by: Campbell Reid-Tait <campbellreidtait at gmail.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Template changes only, works nicely.
    Tested editing and adding libraries in administration.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 08330ec05b8854df61bb28c2498b6ef0a727589e)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 5ddc1f43fb18679fadd80d17bb4a45b2d2a6b87b
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Aug 9 11:41:41 2013 -0400

    Bug 10587: fix HTML errors on authority detail page in OPAC

    A validator check of the OPAC's authority detail returns a few minor
    errors. This patch corrects the errors.

    To test, apply the patch and run an OPAC authority detail page through
    an HTML validator. There should be no errors which are specific to the
    authorities detail template (as opposed to header and footer includes).

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests and QA script pass.
    Also checked using the W3C validator and testing the
    authority detail page in the OPAC is still correctly
    displayed.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 452a4b7775ce10655543aa81f670e2fb497ccc9b)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a1c831bf43a563a116e9161b2b9381c9434669da
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Jul 15 11:56:14 2013 -0300

    Bug 10593: make AuthoritiesLog default to yes

    This trivial patch set the default to 'yes' for this system preference.
    To test,
    On a clean install
    - Navigate Home > Administration > Global System preferences > Logs
    - AuthoritiesLog is set to "Don't log"
    Apply the patch, install koha on a new DB.
    - Navigate Home > Administration > Global System preferences > Logs
    - AuthoritiesLog should be set to "Log"

    Sponsored-by: Universidad Nacional de Cordoba
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    One line patch, changing the default for new installations only.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 0cfe0fa92328e62d1fbca33ea69869ad4f034c1b)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 45f9a4a0385967f5e4dfd2ff4b77412353d77a83
Author: Magnus Enger <magnus at enger.priv.no>
Date:   Tue Jul 30 15:32:31 2013 +0200

    Bug 9247 - Add two more usage examples to the manpage for koha-mysql

    It might not be immediately obvious that it is possible to send
    SQL queries "directly" to the koha-mysql command, or that files
    from mysqldump can be loaded with it. This patch adds these as
    "example usage" to the man page for koha-mysql.

    To test:

    Run these commands and look at the formatted man page:
    $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \
      debian/docs/koha-mysql.xml
    $ man -l koha-mysql.8

    Make sure this test passes:
    $ prove -v xt/verify-debian-docbook.t

    This patch also corrects a couple places where "Koha" was written as "koha".

    Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Test plan, all tests and QA script pass.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 5b121593800088656a0430da641b4c12a4e53980)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit e647d4e3ed887510db6bf7754bbd37c0401c3999
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Tue Jul 23 16:46:38 2013 +0200

    Bug 10528: add unit tests for C4::Bookseller.pm

    The tests are wrapped in a transaction.

    NOTE: some tests should pass but doesn't because of incoherences in
    the code.  These tests are in comments and preceded by FIXME

    Test plan:
    prove t/db_dependent/Bookseller.t
    t/db_dependent/Bookseller.t .. 15/53
    [Some warnings about uninitialised values]
    t/db_dependent/Bookseller.t .. ok
    All tests successful.
    Files=1, Tests=53,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.46 cusr  0.03 csys =  0.51 CPU)
    Result: PASS

    http://bugs.koha-community.org/show_bug.cgi?id=10528

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    The new tests pass nicely, as do all old tests and the QA script.
    All patches marked as dependencies have been pushed to master
    already.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit dc7b5b10e737cc34452dfc6c061cd7c893f08983)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 1ad01972ca995bc938ffe55fd43e7a69e03aca5c
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Jul 9 12:02:00 2013 +0200

    Bug 10557: remove unused branch parameter from GetBooksellersWithLateOrders

    C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter.
    The $branch variable is never used in the routine.

    Test plan:
    Check that no behavior changes on the late orders page.

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    I couldn't find any use of the branch parameter apart from
    the one corrected by this patch. Also tested late orders,
    couldn't find any problems.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 7f075448b8e00596ece780cca654471eebf949a3)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Bookseller.pm                                   |    4 +-
 C4/Branch.pm                                       |   10 -
 acqui/lateorders.pl                                |    2 +-
 debian/docs/koha-mysql.xml                         |   21 +-
 installer/data/mysql/sysprefs.sql                  |    2 +-
 .../prog/en/modules/admin/branches.tt              |   28 +-
 .../prog/en/modules/admin/preferences/opac.pref    |    2 +-
 .../en/modules/admin/preferences/staff_client.pref |    2 +-
 .../opac-tmpl/prog/en/modules/opac-auth-detail.tt  |    9 +-
 t/db_dependent/Bookseller.t                        |  694 ++++++++++++++++++++
 t/db_dependent/Branch.t                            |  297 ++++++++-
 11 files changed, 1028 insertions(+), 43 deletions(-)
 create mode 100644 t/db_dependent/Bookseller.t

hooks/post-receive
-- 
main Koha release repository