[koha-commits] main Koha release repository branch 3.12.x updated. v3.12.04-71-gbf84bf5

Fri Sep 13 19:47:16 CEST 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.12.x has been updated
       via  bf84bf5b55c8d378f8abc4fa0f82a804c2d933df (commit)
       via  b7e3e0efa6611be9c2f8c4e7f3bb08de49af7900 (commit)
       via  41f12d9edaecb2857f8823ef59748f974a79879a (commit)
       via  0d97cee2f1b4eb9ca8e6ded917e019ea4bae68f5 (commit)
       via  637721585595de560ddaa48f2f93aef07bf0f65f (commit)
       via  328b1bef0f72538105a1463d1398aadce349310e (commit)
       via  a6d9026f23dc2eb95188907dfc14f574c2305215 (commit)
       via  b6e9c93514fcb85f4a86565761ec0d39ce766a83 (commit)
       via  4eb94db2daeab8aed65dc703b13b3e8d4d154abc (commit)
      from  5ff99f63e32212071cc1e71749f93e943f005005 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bf84bf5b55c8d378f8abc4fa0f82a804c2d933df
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Aug 19 11:29:13 2013 +1000

    Bug 10755 - Add "Keyword as Phrase" to staff client advanced search indexes

    This patch adds a "Keyword as Phrase" index to the search options in
    the staff client.

    Test Plan:

    1) Go to the Advanced Search in the staff client and click on the "Keyword"
    drop-down list.
    2) Note that there is only a "Keyword" not a "Keyword as Phrase" option
    3) Apply the patch
    4) Reload the Advanced Search
    5) Note that there is now a "Keyword as Phrase" option as well

    If you want to test the functionality...it will depend on your catalogue
    data.

    Basically, a phrase search will allow you to find "Keyword Adjacent To
    Keyword" rather than a more scattershot search that finds the keywords
    regardless of their position to each other.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Template change is correct, and in my tests the searching behavior was
    correctly modified: Using "keyword as phrase" returned only results
    where the terms were adjacent.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Passes koha-qa.pl, trivial patch with no possible side effects.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit a1a4ff2bef3c94bafbf55b5995bc92bb46cdfa02)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit b7e3e0efa6611be9c2f8c4e7f3bb08de49af7900
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Thu Aug 8 11:40:13 2013 +0200

    Bug 10699: add explicit return value for DeleteBranchTransferLimits()

    This patch adds return values to DeleteBranchTransferLimits:
    1 if a Transfer Limit is deleted
    undef if no parameters is given
    0E0 if a wrong parameter is given

    More, it fixes and adds some tests in t/db_dependent/Circulation_transfers.t

    To test :
    prove t/db_dependent/Circulation_transfers.t
    t/db_dependent/Circulation_transfers.t .. ok
    All tests successful.
    Files=1, Tests=14, 19 wallclock secs ( 0.02 usr  0.01 sys +  0.39 cusr  0.02 csys =  0.44 CPU)
    Result: PASS

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Tested with patch for bug 10692 applied.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 88f15db30a9da6a24cf575759a97e8765be61ad4)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 41f12d9edaecb2857f8823ef59748f974a79879a
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Aug 28 15:16:28 2013 +0000

    Bug 10693: (follow-up) fix parameter checking in CreateBranchTransferLimit()

    There is nothing prevent '0' from being used as a library code.

    To test:

    Run prove -v t/db_dependent/Circulation_transfers.t and verify that
    the tests pass.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 6751c5dc7c963defd0a31adfd46d0665abf41cd6)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 0d97cee2f1b4eb9ca8e6ded917e019ea4bae68f5
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Wed Aug 7 16:35:35 2013 +0200

    Bug 10693: CreateBranchTransferLimit's return value in C4::Circulation.pm should be more explicit

    This patch test if the parameters $toBranch and $fromBranch are given.
    If not, CreateBranchTransferLimit now returns undef.
    This patch also fixes and adds some regression tests in
    t/db_dependent/Circulation_transfers.t

    NOTE:
    Currently, we can add a transferlimit to nonexistent branches because
    in the database branch_transfer_limits.toBranch
    and branch_transfer_limits.fromBranch aren't foreign keys.

    To test:
    prove t/db_dependent/Circulation_transfers.t
    t/db_dependent/Circulation_transfers.t .. ok
    All tests successful.
    Files=1, Tests=15, 18 wallclock secs ( 0.02 usr  0.01 sys +  0.42 cusr  0.00 csys =  0.45 CPU)
    Result: PASS

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    All tests and QA script pass.
    (cherry picked from commit 3c61f95fb41152994ca2807eee87dc8e13ba219d)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 637721585595de560ddaa48f2f93aef07bf0f65f
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Wed Aug 7 15:54:01 2013 +0200

    Bug 10692: add unit tests for C4::Circulation routines about transfers

    The tests are wrap in a transaction.

    NOTE: Currently, some tests should pass but don't because of incoherences in the code.
    These tests are in comments and preceded by FIXME.

    To test:
    prove t/db_dependent/Circulation_transfers.t
    t/db_dependent/Circulation_transfers.t .. ok
    All tests successful.
    Files=1, Tests=12, 18 wallclock secs ( 0.02 usr  0.01 sys +  0.37 cusr  0.06 csys =  0.46 CPU)
    Result: PASS

    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit a58c5334c96105315ee3bf1cbb62d8c1aab82f0c)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 328b1bef0f72538105a1463d1398aadce349310e
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Aug 14 16:37:49 2013 +0000

    Bug 10710: (follow-up) perltidy new code

    Also, I prefer the use of parentheses for function
    calls, even when no arguments are being passed.
    One missed comma turns

    is(GetOfflineOperation, ...)

    into

    is(GetOfflineOperation ...)

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 35b83e540ea6d2f9856de827cfcad7c3b2b07f82)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a6d9026f23dc2eb95188907dfc14f574c2305215
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Mon Aug 12 14:16:46 2013 +0200

    Bug 10710: add unit tests for OfflineOperation's routines in C4/Circulation.pm

    This patch test AddOfflineOperation,GetOfflineOperation and
    DeleteOfflineOperation in C4/Circulation.pm.

    The tests are wrapped in a transaction.

    Note: Currently, GetOfflineOperations is not tested because we cannot
    mock C4::Context->userenv in unit tests

    To test:

    prove t/db_dependent/Circulation_OfflineOperation.t
    t/db_dependent/Circulation_OfflineOperation.t .. ok
    All tests successful.
    Files=1, Tests=7, 19 wallclock secs ( 0.01 usr  0.01 sys +  0.33 cusr  0.02 csys =  0.37 CPU

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 87890bc366d566685f1484cb476200f5ca302e91)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit b6e9c93514fcb85f4a86565761ec0d39ce766a83
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Wed Aug 28 14:44:01 2013 +0000

    Bug 10767: (follow-up) remove FIXME comments

    The FIXME comments in the new test script were based on
    an assumption that GetIssuingRules() should return
    multiple rules if no or only partial parameters are
    passed.  This is not the intent of that routine, whose
    purpose is to return the *singular* rule that best
    applies to a given loan situation.  In other words,
    GetIssuingRule() is not a traditional accessor function.

    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit c191532cc0c908ccbd5019a0d49c721e5702e7a6)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 4eb94db2daeab8aed65dc703b13b3e8d4d154abc
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date:   Tue Aug 20 10:18:04 2013 +0200

    Bug 10767: add unit tests for C4::Circulation routines that use issuingrules

    The test are wrap in a transaction.

    To test:
    prove t/db_dependent/Circulation_Issuingrule.t
    t/db_dependent/Circulation_Issuingrule.t .. ok
    All tests successful.
    Files=1, Tests=9, 17 wallclock secs ( 0.02 usr  0.00 sys +  0.34 cusr  0.04 csys =  0.40 CPU)
    Result: PASS

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Comment: No koha-qa errors
    prove t/db_dependent/Circulation_Issuingrule.t run without errors

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 08d45913d68d85eea1a1b2bab604b184d323ded5)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    7 +-
 .../prog/en/includes/search_indexes.inc            |    1 +
 t/db_dependent/Circulation_Issuingrule.t           |  341 ++++++++++++++++++++
 t/db_dependent/Circulation_OfflineOperation.t      |  100 ++++++
 t/db_dependent/Circulation_transfers.t             |  205 ++++++++++++
 5 files changed, 651 insertions(+), 3 deletions(-)
 create mode 100644 t/db_dependent/Circulation_Issuingrule.t
 create mode 100644 t/db_dependent/Circulation_OfflineOperation.t
 create mode 100644 t/db_dependent/Circulation_transfers.t

hooks/post-receive
-- 
main Koha release repository