[koha-commits] main Koha release repository branch 3.8.x updated. v3.08.13-106-gf3a2c1e

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.8.x has been updated
       via  f3a2c1ec774181c1e5ccb941b79c25bd06b2302c (commit)
      from  6045b736000805787453ee764629dd04907dc83a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f3a2c1ec774181c1e5ccb941b79c25bd06b2302c
Author: David Cook <dcook at prosentient.com.au>
Date:   Thu Jun 13 16:46:46 2013 +1000

    Bug 10457: fix SQL error when using 'export select items data' in serials claims page
    
    Currently, if you use the "check all" checkbox next to the "Vendor"
    table header, and try to "Export selected items data", you'll
    see the following SQL error in the Apache error log:
    
    DBD::mysql::st execute failed: You have an error in your SQL syntax;
    check the manual that corresponds to your MySQL server version for
    the right syntax to use near 'on ORDER BY title' at line 12 at
    /.../lib/C4/Serials.pm line 1828.
    
    This is because the Javascript that produces the re-direct URL is
    including the value of the checkall checkbox, which is "on",
    as a "serialid".
    
    We need to only take checkboxes with a name of "serialid" when
    crafting the re-direct link.
    
    This patch adds the [name=serialid] attribute selector to the Jquery
    that creates the URL to lateissues-excel.pl from claims.pl.
    
    Test Plan:
    
    Before applying the patch:
    
    1) Go to Serials > Claims (found on the left navigation bar of Serials)
    2) Choose a vendor that has serials to claim (or create some late
    serials for a vendor so that they will show up)
    3) Click on the checkbox to the left of the "Vendor" table heading.
    4) Click "Export selected items data" at the bottom of the page
    5) Check the Apache error log.  Notice that you'll get a SQL error
       like the one in the message above.
    
    Apply the patch.
    
    Repeat Steps 1-4.
    
    Note that you should now have a CSV file downloading rather than
    getting a SQL error.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit 3834d1f2b4494d465c6d1ab72aa334100898a756)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit fdb1d099c5489f200b7b36125ed4ccddd00e3d4c)
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    (cherry picked from commit fdb1d099c5489f200b7b36125ed4ccddd00e3d4c)
    Signed-off-by: Chris Hall <followingthepath at gmail.com>
    (cherry picked from commit 9643d6ca30315cae2a2732b0bc84e0a63797261a)

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/serials/claims.tt              |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository