[koha-commits] main Koha release repository branch 3.8.x updated. v3.08.13-107-g1fa3781

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.8.x has been updated
       via  1fa37815fa186c1e773a682631807588253c1e5c (commit)
      from  f3a2c1ec774181c1e5ccb941b79c25bd06b2302c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1fa37815fa186c1e773a682631807588253c1e5c
Author: David Cook <dcook at prosentient.com.au>
Date:   Thu Jun 27 16:02:08 2013 +1000

    Bug 9801: display facet labels in search results only when there are facet values
    
    Currently, the headings for facets (such as location) are showing even
    if there are no actual values/links for that facet type.
    
    This patch simply checks if the facet array contains any facets before
    printing the heading and HTML for each facet value/link.
    
    Test Plan:
    
    Before applying:
    
    0) If you want to check the location facet (which is easiest),
    enable singlebranch  mode in the globals system preferences.
    
    1) Do a search for records/items that you have no shelving location
    specified (or simply remove the shelving location for a small range
    of records that you can find in a search query).
    
    2) Note that "Location" appears amongst the facets even though there
    are no values/links present. (If you look at the HTML source, you'll
    see some empty HTML tags have been printed out.)
    
    Apply patch.
    
    3) Flush your cache and refresh your page.
    4) You should no longer see a "Location" facet (or those empty HTML
    tags) on the facet sidebar.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Template changes only.
    Checked according to test plan, made sure location facet
    still shows up when values exist, otherwise it's hidden.
    
    It might make sense to add ids to the facets so libraries
    can decide to hide some of them easily. Or alternatively
    add a system preference to make that possible.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    (cherry picked from commit f01606d89b487d585bf06eae1dd6de6ff138eab9)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 8871a6a2add5cbdef3a46267a54fc78ddf995687)
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    (cherry picked from commit 8871a6a2add5cbdef3a46267a54fc78ddf995687)
    Signed-off-by: Chris Hall <followingthepath at gmail.com>
    (cherry picked from commit 270cc499c3dde4ef22e395d8dc3f40ebb1e6907e)

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/includes/facets.inc      |    2 ++
 .../opac-tmpl/prog/en/includes/opac-facets.inc     |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
main Koha release repository