[koha-commits] main Koha release repository branch master updated. v3.16.00-162-g6d77304

Git repo owner gitmaster at git.koha-community.org
Tue Jul 1 05:02:37 CEST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  6d77304c98e9b4c839b3bcf19e1453a7e6ec8aaa (commit)
      from  b212c4137d8b401073dd0c4d0ab07c12dd0fd224 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6d77304c98e9b4c839b3bcf19e1453a7e6ec8aaa
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Jun 19 14:47:15 2014 +0200

    Bug 11357 - biblioitems.size value not correctly displayed in list emails sent from OPAC and intranet
    
    The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable.
    
    It's currently used in the templates for sending shelves from OPAC and intranet and maybe also in other places:
    
    [% END %]
       [% IF BIBLIO_RESULT.size %]
       , [% BIBLIO_RESULT.size %]
    [% END %]
    
    This patch corrects by using item() TT method.
    See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template.
    
    Test plan :
    In each display :
    => Without this patch you see biblioitems.pages and then a number
    => With this patch you only see biblioitems.pages
    
    - Create a record with biblioitems.pages defined (like "12p") but without biblioitems.size defined
    Same for OPAC and intranet :
    - Add it to the cart
    - Open the cart
    - Check the "Title" column
    - Click on "More Details"
    - Check the "Details" row
    - Send the basket via email and check the result
    - Add to a list
    - Send the list via email and check the result
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Works well!!
    Tested on staff & opac, cart & list.
    No koha-qa errors
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Passes QA script and tests.
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt       |    8 ++++----
 koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt   |    4 ++--
 .../intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt  |    6 +++---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt        |    6 +++---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasket.tt    |    4 ++--
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt     |    6 +++---
 6 files changed, 17 insertions(+), 17 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list