[koha-commits] main Koha release repository branch master updated. v3.16.00-174-g5fa481f
Git repo owner
gitmaster at git.koha-community.org
Wed Jul 2 19:15:45 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 5fa481fa081e52053ee535b9a94e71483950b4a0 (commit)
via 4bbda034644723750a11c5693953390cc229a0a7 (commit)
via 05b4fd7d522436face13f45634671bae0151b013 (commit)
via 2b8b5ae225af6119e41e2112f9a8573b4170b927 (commit)
via 9d3e8487b19c409b159c924c9005ece23e8f1b7d (commit)
via 44a3d3413b5195cdf13d0c36a11d3bd8ce86774a (commit)
via a660d2208bd2d9e4bde9f2889a57fb8597f2ccf4 (commit)
via 47dbd2e69110bf79ca472d596daee5cb404ee366 (commit)
via 638b7225ae2507a708313c7766b9e71a6d891289 (commit)
via b223a5e23e393a83b5283520096e052cb122b189 (commit)
via 24d6d83ada6d6b3aaf9fbb163025e08f588dc4ab (commit)
via 88e27fce3f47dcca8fc4a7134fc0dc0b21e52e9c (commit)
from 6d77304c98e9b4c839b3bcf19e1453a7e6ec8aaa (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5fa481fa081e52053ee535b9a94e71483950b4a0
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Jun 11 15:20:37 2014 +0200
Bug 9811: Fix wording branch vs library
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
1) Top search
- OK no regressions found
2) New filters
- OK Terminology
- OK Search fields, search types, category, library
- OK Clear button
3) Result list
- OK Cardnumber
- OK Name, address and email
- OK Fines, checkouts and overdues
- OK Adding patrons to patron lists
- OK Select all/unselect all
- OK Sorting on the various columns
- OK Paging
- OK PatronsPerPage system preference
4) Performance
Tested with a database containing 40.000 patrons.
Search results were displayed with a little delay,
overall performance seemed pretty good.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 4bbda034644723750a11c5693953390cc229a0a7
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Jun 11 15:05:31 2014 +0200
Bug 9811: Cardnumber could be alphanumeric
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 05b4fd7d522436face13f45634671bae0151b013
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Jun 9 17:35:43 2014 +0200
Bug 9811: Various fixes
This patch fixes the issues raised in bug 9811 comment 105, 106 and 107:
1/ Add missing space between category and type.
2/ Fix error on searching an empty string (caused by a previous rebase).
3/ Remove sort option on checkbox/borrowernumber column.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 2b8b5ae225af6119e41e2112f9a8573b4170b927
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Jun 9 17:35:15 2014 +0200
Bug 9811: Remove useless orderby management
I don't know what is this stuff. I didn't find a call to member.pl with
an orderby parameter.
I am not sure this is in used.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 9d3e8487b19c409b159c924c9005ece23e8f1b7d
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Jun 9 17:33:48 2014 +0200
Bug 9811: Display email address in patron result list
This patch restores the enhancement introduced by Bug 10318.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 44a3d3413b5195cdf13d0c36a11d3bd8ce86774a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Apr 28 11:06:06 2014 +0200
Bug 9811: QA follow-up: Fix license version
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit a660d2208bd2d9e4bde9f2889a57fb8597f2ccf4
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Fri Mar 14 12:39:03 2014 +0100
Bug 9811 - datetime does not respect DateFormat-system prefrence
To test:
Try searching by the date of birth using the left filter column. Good luck.
After applying this patch:
You can search using your preferred DateFormat.
Merci bocu
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 47dbd2e69110bf79ca472d596daee5cb404ee366
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Mar 14 11:03:34 2014 +0100
Bug 9811: FIX encoding issue on patron categories
The patron categories should use the html_entity filter (on the current
master).
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
This fix solves the issue of double encoding some utf8-characters by html_encoding the
patron categories, which are not marked as utf8.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 638b7225ae2507a708313c7766b9e71a6d891289
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Thu Mar 13 11:58:18 2014 +0100
Bug 9811: Fixing JSON validation error for non-javascript string literal characters
Issue:
When a patron has backslashes in his circulation notes, the JSON transportation
layer cannot send the message because it will fail JSON validation when trying to
validate backslashed non-literal characters (\s \d ...).
This causes the whole search to fail when even one Borrower has a non-literal
backslashed character in his notes.
Solution:
The Borrowers' circulation notes are filtered through a regexp which doubles all
backslashes to prepare them for the JSON validation routine.
Result:
Backslashes pass through unchanged.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit b223a5e23e393a83b5283520096e052cb122b189
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Jan 10 11:24:48 2014 +0100
Bug 9811: FIX branches loop was not correctly set
The branches loop was not set with the values.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 24d6d83ada6d6b3aaf9fbb163025e08f588dc4ab
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Mar 19 11:12:26 2013 +0100
Bug 9811: Patron search improvement
This patch add DataTables using server-side processing for the patrons
search.
It adds:
- 1 module C4/Utils/DataTables/Members.pm
- 2 services svc/members/search and svc/members/add_to_list
- 1 template members/tables/members_results.tt
- 1 new practice which is to add template for DataTables in a
subdirectory named 'tables'.
Impacted scripts: members/members-home.pl and members/members.pl
To go further: We can imagine that all patrons searches use the same
service with no big changes: 1 little template creates a JSON file and
to implement DataTables on the template page, that's all.
Amended patch: Since bug 10565 has been pushed, these patches don't
apply cleanly. I had to rewrite a part of the patron list feature.
I removed the choice to add all resultant patrons from a search. I think
this choice is useless with this patch: we are able to display the
number of patrons we want and to select all of them.
Test plan:
- Check that there is no regression on searching patrons.
- Try filters on the left of the screen.
- Try to sort each column.
- Try the "Browse by last name" links.
- Check that the "Clear" button clears yours filters.
- Try with IndependantBranches ON and OFF.
- Verify this feature does not break the patron list feature (cf bug
10565).
Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script, couldn't find any regressions
or problems. Some notes left on the bug.
Bug 9811: Add unit tests for C4::Utils::DT::Members
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Bug 9811: QA followup
- removes 2 tabs
- removes mysqlisms
- add sort on borrowernotes
- fix wrong capitalization
- cat => Category
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Thx for fixing these!
Bug 9811 - multilines notes brakes JSON
In new patron search feature, the search results are fetched using Ajax and returned in JSON format.
The JSON is created by TT using koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt.
One of the fields is the borrower notes. When this notes contains several lines, the JSON is broken.
This patch uses TT fileters to consert in notes linefeeds into HTML line break (html_line_break) and then remove linefeeds (collapse).
Test plan :
- perform a member search that does not return a borrower with a circ note
- edit one of the borrowers returned by this search
- enter serveral lines of text in "Circulation note" and save
- reperform the member search
=> circ note is well displayed on several lines
Bug 9811: use count(primary_key) instead of count(*)
Bug 9811: A limit clause should be always added.
By default, we want to retrieve 20 first results.
Bug 9811: Load the page without any data.
Displaying the first 20 patrons is not useful. With this patch, the
table is hidden and no record is retrieved by default.
On the same way, the existing side effect on redirect disappears.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
-------------
-TEST REPORT-
-------------
For the filter: Tested all the search fields, branches, search type.
Found a bug with "date of birth", followup provided.
Tested display limits and verified that AJAX-queries are
efficient (using LIMIT clause) to not stress DB needlessly.
Tested adding Patrons to a list.
A good feature, which seems to work quite well.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Adding my test plan to the last patch of this bug.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 88e27fce3f47dcca8fc4a7134fc0dc0b21e52e9c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri May 30 07:17:25 2014 -0400
Bug 12337 - Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.
Each time the "renew all" or "renew or return" buttons are click, the
renewal process is triggered. If the patron only has one renewal left,
and the button is multi-clicked, the librarian may receive a
"renewal failed" message even though the renewal did occur. In
addition, this can just unwanted multiple consecutive renewals
as well.
Test Plan:
1) Check out an item to a patron that can have 1 renewal
2) Click the "renew all" button multiple times, fast and furiously
3) Note the "renewal failed" messaged
4) Apply this patch
5) Repeat steps 1 and 2
6) Note the item is now renewed without the failure message
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Members.pm | 2 +-
C4/Utils/DataTables/Members.pm | 213 +++++++
.../intranet-tmpl/prog/en/includes/home-search.inc | 3 +-
.../prog/en/includes/patron-search.inc | 147 +++--
.../prog/en/includes/patron-title.inc | 44 +-
koha-tmpl/intranet-tmpl/prog/en/js/datatables.js | 2 +-
.../prog/en/modules/circ/circulation.tt | 3 +-
.../prog/en/modules/members/member.tt | 603 ++++++++++++++------
.../en/modules/members/tables/members_results.tt | 35 ++
members/member.pl | 227 ++------
members/members-home.pl | 30 +-
members/moremember.pl | 17 +-
svc/members/add_to_list | 63 ++
svc/members/search | 124 ++++
t/DataTables/Members.t | 14 +
15 files changed, 1083 insertions(+), 444 deletions(-)
create mode 100644 C4/Utils/DataTables/Members.pm
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
create mode 100755 svc/members/add_to_list
create mode 100755 svc/members/search
create mode 100644 t/DataTables/Members.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list