[koha-commits] main Koha release repository branch master updated. v3.16.00-1036-g958dff0
Git repo owner
gitmaster at git.koha-community.org
Wed Nov 12 15:39:17 CET 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 958dff03d2b2ec18c380474b1c959df421bb68e9 (commit)
via 3b300146b2ca478472c5305abcc84ca0033b17ff (commit)
via a935e23d3d0d6e647fa05f75d9808fa43b7d0fcd (commit)
via d77f6519f4852b5b166556a598d9966773288964 (commit)
via ebf4350735da7ea365f3b5b72410f6810a9182b8 (commit)
via 3bc14af683fbdb37e881d16d0f7da5ef313c165a (commit)
via 51f0a0b7229c1e76699708a548a9e3e68c9953ad (commit)
via 0c7dbbb4cf62ed4d6ecab03d1b6b4b5157f3b155 (commit)
from 9042ce4ea508b689d7e54222ee8ae50d7c85e1ab (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 958dff03d2b2ec18c380474b1c959df421bb68e9
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Nov 12 11:29:01 2014 -0300
Bug 11634: DBRev 3.17.00.054
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 3b300146b2ca478472c5305abcc84ca0033b17ff
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Sep 18 07:44:36 2014 -0400
Bug 11634 [QA Followup 3] - Found holds should be considered unavailable
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit a935e23d3d0d6e647fa05f75d9808fa43b7d0fcd
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Mar 5 07:31:35 2014 -0500
Bug 11634 [QA Followup 2] - Implement check for IsAvailableForItemLevelRequest
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit d77f6519f4852b5b166556a598d9966773288964
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Mar 4 12:58:28 2014 -0500
Bug 11634 [QA Followup] - Unit Tests
These new unit tests will fail due to the fact that Koha::Database
uses a separate dbh handle than C4::Context->dbh
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit ebf4350735da7ea365f3b5b72410f6810a9182b8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Jan 29 10:52:08 2014 -0500
Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds
The current holds behavior in Koha allows a situation like this:
- Patron A has an item currently checked out.
- Patron B places a hold on the next available copy of that title.
- Then Patron A will not be able to renew his item, even if there are
other available copies of that title that could potentially fill Patron
B's hold.
Since this seems unfair to Patron A, we should allow renewal of items
even if there are unfilled holds, but those holds could all be filled
with currently available items.
Test Plan:
1) Apply this patch
2) Create a record with two items
3) Check out the item to a patron
4) Place a hold on the record
5) Note you cannot renew the item for the patron
6) Enable the new system preference AllowRenewalIfOtherItemsAvailable
7) Note you can now renew the item, as all the holds can be satisfied
by available items.
8) Place a second hold on the record
9) Note you can no longer renew the item, as all the holds *cannot*
be filled by currently available items
Signed-off-by: Holger Meissner <h.meissner.82 at web.de>
Signed-off-by: Chris Rohde <crohde at roseville.ca.us>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 3bc14af683fbdb37e881d16d0f7da5ef313c165a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Oct 31 09:51:43 2014 -0400
Bug 13116 [QA Followup] - Remove tabs, use unless instead of if
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 51f0a0b7229c1e76699708a548a9e3e68c9953ad
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Mon Oct 20 19:04:51 2014 +0300
Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates.
This patch changes the way CanBookBeReserved() and CanItemBeReserved() return error
messages and how they are dealt with in the templates. This change makes it possible
to distinguish between different types of reservation failure.
Currently only two types of errors are handled, all the way to the user, from the CanItemBeReserved():
-ageRestricted
-tooManyReserves which translates to maxreserves
#############
- TEST PLAN -
#############
((-- AGE RESTRICTION --))
STAFF CLIENT
1. Find a Record with Items, update the MARC Subfield 521a to "PEGI 16".
2. Get a Borrower who is younger than 16 years.
3. Place a hold for the underage Borrower for the ageRestricted Record.
4. You get a notification, that placing a hold on ageRestricted material is
forbidden. (previously you just got a notification about maximum amount of reserves reached)
((-- MAXIMUM RESERVES REACHED --))
0. Set the maxreserves -syspref to 3 (or any low value)
STAFF CLIENT AND OPAC
1. Make a ton of reserves for one borrower.
2. Observe the notification about maximum reserves reached blocking your reservations.
((-- MULTIPLE HOLDS STAFF CLIENT --))
3. Observe the error notification "Cannot place hold on some items"
((-- MULTIPLE HOLDS OPAC --))
1. Make a search with many results, of which atleast one is age restricted to the current borrower.
2. Select few results and "Place hold" from to result summary header element.
(Not individual results "Place hold")
3. Observe individual Biblios getting the "age restricted"-notification, where others can be
reserved just fine.
Updated the unit tests to match the new method return values.
t/db_dependent/Holds.t & Reserves.t
Followed test plan. Works as expected and displays meaningful messages for the reason why placing a hold is not possible.
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 0c7dbbb4cf62ed4d6ecab03d1b6b4b5157f3b155
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Nov 12 11:18:55 2014 -0300
Bug 7673: (RM followup) typo in sysprefs.sql
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 57 ++++++++++++++
C4/ILSDI/Services.pm | 6 +-
C4/Reserves.pm | 80 +++++++++++++++-----
installer/data/mysql/sysprefs.sql | 3 +-
installer/data/mysql/updatedatabase.pl | 10 +++
.../en/modules/admin/preferences/circulation.pref | 6 ++
.../prog/en/modules/reserve/request.tt | 5 +-
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 3 +
kohaversion.pl | 2 +-
opac/opac-reserve.pl | 10 ++-
reserve/request.pl | 16 +++-
t/db_dependent/Circulation.t | 36 ++++++++-
t/db_dependent/Holds.t | 16 ++--
t/db_dependent/Reserves.t | 6 +-
14 files changed, 211 insertions(+), 45 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list