[koha-commits] main Koha release repository branch master updated. v3.16.00-1044-g9e07b59

Wed Nov 12 18:54:58 CET 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  9e07b59d5bd330bc03c222603d1845f31fa8fd20 (commit)
       via  44cb93d77d11721e1b67f630cf643091a1c2ec6b (commit)
       via  c9816945fd6592ce7bb6b6e37d72c0215bfc7be0 (commit)
       via  a5dda66f64d73027fa4ede738272cba37e6e9b11 (commit)
       via  2de657d4ec0b381d045559d18276f28917b12994 (commit)
       via  c7d862bb7b98e854daa0bfd871f1e8f9f0f2eb39 (commit)
       via  041c24712444953b655f651b812836e5b412568d (commit)
       via  c48639ee271a7abc9670b41d4e16f39adc56842b (commit)
      from  958dff03d2b2ec18c380474b1c959df421bb68e9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9e07b59d5bd330bc03c222603d1845f31fa8fd20
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Nov 12 09:27:07 2014 -0500

    Bug 11634 [QA Followup] - Make unit tests pass

    * Allow on shelf holds needed to be enabled
    * Added some error supression code for undefined string comparison

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 44cb93d77d11721e1b67f630cf643091a1c2ec6b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 31 10:14:16 2014 +0100

    Bug 11319: [QA follow-up] Remove a warning from GetModificationTemplates

    Removes this warning: Use of uninitialized value $template_id in string eq
    at C4/MarcModificationTemplates.pm line 84.

    GetModificationTemplates has no template_id if called from
    marc_modification_templates.pl without operation (first click from
    interface) and from tools/stage-marc-import.pl.

    Slightly adjusted the POD lines accordingly.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit c9816945fd6592ce7bb6b6e37d72c0215bfc7be0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 31 09:33:14 2014 +0100

    Bug 11319: [QA follow-up] Add test message to MarcModificationTemplates.t

    The last test (#74) did not print anything. It now does..

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a5dda66f64d73027fa4ede738272cba37e6e9b11
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 11 17:11:01 2013 +0100

    Bug 11319: Template modifications

    This patch add template modifications for the restrictions:
    - the source field is always mandatory
    - on move and copy, the source and destination subfield should be both
      filled or blank.
    - on move and copy, the destination subfield should be filled.
    - on update, the subfield value should be filled.

    Test plan:
    Verify you are not able to create/modify template actions according to
    these restrictions.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 2de657d4ec0b381d045559d18276f28917b12994
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 11 15:53:37 2013 +0100

    Bug 11319: Add specific UT for nonexistent field/subfield

    This patch only adds unit tests for the copy and move actions.
    They test if the action does not create a field/subfield if the source
    did not exist.

    Also it adds a unit tests for the existing behavior (in order not to
    lost it): we can use the '^' and the '$' character in regex for
    substituing. For example: Copy 245$a to 245$a with the regex s/^/BEGIN /
    This will add the string "BEGIN " at the beginning of the 245$a fields.

    To test: prove t/SimpleMARC.t

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit c7d862bb7b98e854daa0bfd871f1e8f9f0f2eb39
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 11 15:39:49 2013 +0100

    Bug 11319: Add the field management for Koha::SimpleMARC

    Currently the Koha::SimpleMARC module call a "field" a "subfield".
    And the way to manage field is not implemented for all routines.

    This patch does not modify the API. The routine's names are kept. It
    just creates 2 privates routines for each action (e.g. delete_field
    will call _delete_field if the action affects field and _delete_subfield
    if the action affects subfields).

    Before this patch the move action was authorised by the interface but
    caused an error if executed.

    Note: I don't see the meaning for the add/update action if no subfield
    is given. So the call without subfield raises an error.

    Test plan:
    - apply all patches
    - create or modify an existent template
    - try at least the correct behavior for the following actions:
      * delete subfield and field
      * add new subfield to an existing field
      * add new subfield to an nonexisting field
      * move a subfield
      * move an entire field
      * copy a subfield
      * copy an entire field
    - import a biblio and use this template
    - verify the imported biblio matches actions defined.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 041c24712444953b655f651b812836e5b412568d
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 11 15:39:26 2013 +0100

    Bug 11319: Add UT for the fields management

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit c48639ee271a7abc9670b41d4e16f39adc56842b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 11 14:22:03 2013 +0100

    Bug 11319: Koha::SimpleMARC should take a hashref for parameters

    In order to avoid a long list of parameters, it should be better to
    pass all of them into a hashref.

    This patch does not add or modify a behavior.

    Test plan:
    Verify the unit tests still pass
    - prove t/SimpleMARC.t
    - prove t/db_dependent/MarcModificationTemplates.t

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/MarcModificationTemplates.pm                    |  144 +--
 Koha/Calendar.pm                                   |    2 +
 Koha/DateUtils.pm                                  |    2 +-
 Koha/SimpleMARC.pm                                 |  473 +++++++--
 .../modules/tools/marc_modification_templates.tt   |   28 +-
 t/SimpleMARC.t                                     | 1064 +++++++++++++++++---
 t/db_dependent/Circulation.t                       |    1 +
 t/db_dependent/MarcModificationTemplates.t         |    2 +-
 8 files changed, 1391 insertions(+), 325 deletions(-)

hooks/post-receive
-- 
main Koha release repository