[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-28-g31f808c
Git repo owner
gitmaster at git.koha-community.org
Tue Sep 23 22:55:07 CEST 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.16.x has been updated
via 31f808cb49e13b75b4137b3adb681135f8a1e51f (commit)
via 9f2c4b78261b2be1d4a09dd9dfcf0eef75acb308 (commit)
via 5502447d41d93d91bfc9a20201f3049cd9f1642e (commit)
via 533d6ed35c4dfa872edaf690fcb8ae05cf017358 (commit)
via 7f6f09da96002fbd5bd4a7cbecc532b28647ff27 (commit)
via a67bce36b0c1eb79bb7fcd45ec6a7ec8e873522c (commit)
via 92b0d001da517f858e8d78fc6b6b335744f2c866 (commit)
via 0a1c90084e9978c8f51c7d58d3383fd44ab2a8ef (commit)
via 8d21dd98af08a76218fa374323e7a9eda7267274 (commit)
from fdb55ce2fc9d5cc87405f9584714b5cfdab7737b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 31f808cb49e13b75b4137b3adb681135f8a1e51f
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Aug 20 11:39:27 2014 -0300
Bug 12788: (followup) minor optimization with proper tests
This patch removes the $facets_info calculation from the _get_facets_data_from_record
sub so it is not done for each record. It introduces a new sub, _get_facets_info
that is called from the getRecords loop, that does the job only once.
To test:
- Apply on top of the previous patches
- Run
$ prove -v t/db_dependent/Search.t
=> SUCCESS: _get_facets_info gets tested and it passes for both MARC21 and UNIMARC.
Facets rendering should remain unchaged on the UI.
- Sign off :-D
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 9f2c4b78261b2be1d4a09dd9dfcf0eef75acb308
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Aug 20 00:48:07 2014 -0300
Bug 12788: facets calculation should skip 100 if ind1=z
This patch adds a test for field 100, to skip it on facet calculation
if ind1=z.
To test:
- Have IncludeSeeFromInSearches set.
- Create a biblio record, when adding an author, create a new authority record
that contains a 400$a field (see from).
- Rebuild zebra db.
- Search for the record making sure the search returns more than one record.
=> FAIL: the facets contain the 'see from' field.
- Run
$ prove -v t/db_dependent/Search.t
=> FAIL: it fails
- Apply the patch
- Run
$ prove -v t/db_dependent/Search.t
=> SUCCESS: it passes
- Re-run the search, notice the 'see from' doesn't show anymore on the facets.
- Sign off :-D
Edit: minor stylistic change
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 5502447d41d93d91bfc9a20201f3049cd9f1642e
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Wed Aug 20 00:33:40 2014 -0300
Bub 12788: (regression test) refactor facet extraction code to allow testing
This patch refactors the facet extraction loop into a proper function.
The loop is changed so the MARC::Record objects are created only once
instead of the old/current behaviour: once for each defined facet (in
C4::Koha::getFacets).
To test:
- Apply the patch
=> SUCCESS: verify facets functionality remains unchanged.
- Run:
$ prove -v t/db_dependent/Search.t
=> SUCCESS: tests for _get_facets_data_from_record fail, because
100$a is considered for fields with indicator 1=z (field added
by IncludeSeeFromInSearches syspref).
- Sign off :-D
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 533d6ed35c4dfa872edaf690fcb8ae05cf017358
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Fri Jul 18 09:50:34 2014 +0100
Bug 12600: remove duplicate use statement from code
A use C4::Charset was added deep in the body of the code
we have already imported it at the top of the file
(the by convention normal place) As use is executed at compile time
specifying it in the code body does not serve a
useful purpose and detracts from the readability of an already
overly complex subroutine.
Remove the superfluous statement
also removed the tabs introduced to the surrounding lines
by the same commit
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Search still works, no errors.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 7f6f09da96002fbd5bd4a7cbecc532b28647ff27
Author: Dobrica Pavlinusic <dpavlin at rot13.org>
Date: Thu Jul 17 12:27:55 2014 +0200
Bug 12593: search facets die with regex error if biblio has square brackets in fields
It's quite common to have [something] within facet data, and it produces following error:
Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE
This problem was intoduced in Bug 12151 but is trivial to fix.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Good catch.
To test:
- Created a bibliographic record, linked to an authority record (personal name). Did a search that returned the author as a facet.
- Added a [ symbol to the author name.
- Repeated the search
=> FAIL: "Unmatched [ in regex; marked by <-- HERE in m/^[ <-- HERE"
- Apply the patch
- Retry the search
=> SUCCESS: No error, bracket shows correctly.
Passes koha-qa.pl too.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit a67bce36b0c1eb79bb7fcd45ec6a7ec8e873522c
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Jun 2 11:14:11 2014 -0300
Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm
Just that.
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes QA script and tests.
Could only verify by reading the code.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 92b0d001da517f858e8d78fc6b6b335744f2c866
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Mon Jun 2 11:30:48 2014 -0300
Bug 12151: Remove use of smartmatch operator in tools/batchMod.pl
The '~~' smartmatch operator is used to compare MARC::Field->subfield(code)
(i.e. a string) and the text element of each MARC::Field->subfields() which
is also plain text.
Substituting '~~' for 'eq' should be harmless then.
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes QA script and tests.
Tested batch modification of items, no problems found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 0a1c90084e9978c8f51c7d58d3383fd44ab2a8ef
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Sat May 31 00:30:32 2014 -0300
Bug 12151: Remove uses of smartmatch operator in report scripts
This patch removes the use of smartmatch operators in report scripts.
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes QA script and tests.
Acquisition and Patron statistics wizard tested, no regressions found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 8d21dd98af08a76218fa374323e7a9eda7267274
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri May 30 20:54:10 2014 -0300
Bug 12151: Remove uses of smartmatch operator in Search.pm and opac-search.pl
This patch removes the use of smartmatch operators in the search code.
Regards
To+
Edit: this revision uses 'grep' instead of Lists::MoreUtils::any
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Tested search, no problems found.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Search.pm | 137 +++++++++++++++++++++-----------
Koha/SearchEngine/Solr/QueryBuilder.pm | 16 ++--
opac/opac-search.pl | 15 ++--
reports/acquisitions_stats.pl | 101 ++++++++++++-----------
reports/borrowers_stats.pl | 60 +++++++-------
t/db_dependent/Search.t | 80 ++++++++++++++++++-
tools/batchMod.pl | 2 +-
7 files changed, 262 insertions(+), 149 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list