[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.03-29-g05ace0b

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.16.x has been updated
       via  05ace0b38085a11fbdd7c031a8a251243544b564 (commit)
      from  31f808cb49e13b75b4137b3adb681135f8a1e51f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 05ace0b38085a11fbdd7c031a8a251243544b564
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Jun 11 12:25:19 2014 +0200

    Bug 12405 - Search links on callnumber fails on intranet results page
    
    On intranet results page, the callnumber of items is a search like :
    /cgi-bin/koha/catalogue/search.pl?idx=callnum&q=[% result.itemcallnumber |url %]
    
    The callnumber should be URI-escaped to avoid special URI characters like & , ? ...
    If the callnumber contains some CCL words or parenthesis, the search will fail, it should be wrapped with double-quotes.
    
    This patch adds this to catalogue/results.pl and catalogue/shelves.pl :
    - uri TT filter instead of url
    - adds double-quotes using there URI code %22 since its in a HTML attribute using double-quotes
    
    Test plan :
    - Edit an item callnumber with : & ABC 123
    - Index zebraqueue
    - Perform a search returning this item
    - Click on the callnumber
    => Without this patch you get no result, because URL parameters are : idx=callnum&q=& ABC 123
    => With this patch you get results
    - Set syspref QueryWeightFields off (because this is no bug if on)
    - Edit an item callnumber with : AB(C) AND OR
    - Index zebraqueue
    - Perform a search returning this item
    - Click on the callnumber
    => Without this patch you get no result, because the search contains CCL words "OR" and "AND"
    => With this patch you get results
    
    Signed-off-by: Liz Rea <liz at catalyst.net.nz>
    Tested all with and without queryweightfields -
    all searches from clicked call numbers for given callnumbers fail without the patch, all are successful with the patch.
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Works as described - no problems found.
    Passes tests and QA script.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt   |    8 ++++----
 .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt    |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository