[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.02-18-gf88d0f1

Git repo owner gitmaster at git.koha-community.org
Mon Aug 10 23:04:50 CEST 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  f88d0f1cff5a07a9a082194ddc6a57c536d72e88 (commit)
       via  c0af19301accafb5346b67aa0dae8f33ef1e458a (commit)
      from  2dec35f6fdce7a6138fb1bbcc2f41aede1b103e5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f88d0f1cff5a07a9a082194ddc6a57c536d72e88
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri Jul 3 18:04:04 2015 -0400

    Bug 14487: Noise best detected under Debian 8
    
    The first error is caused by the fact that
    $messages->{'IsPermanent'} is undefined.
    
    The second error is caused by querying the CGI
    parameter 'barcode' inside a function call. This is not required.
    There is a variable $barcode set with the parameter. Changed to
    use the variable.
    
    TEST PLAN
    ----------
    1) Test first patch.
    2) Clear the log
    3) Put in a barcode which is not checked out.
    4) Check the log.
       -- should be two errors. One about a hash,
          the other will only be detectable under Debian 8.
    5) Apply this second patch
    6) Clear the log
    7) Put in a barcode which is not checked out.
    8) Check the log.
       -- should be empty.
    9) run koha qa test tools
    
    Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit beef8534724900e5777fc7b6d163763712decb1f)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit c0af19301accafb5346b67aa0dae8f33ef1e458a
Author: Indranil Das Gupta <indradg at gmail.com>
Date:   Fri Jul 3 13:33:06 2015 +0530

    Bug 14487: silence warns during checkin
    
    Test plan
    =========
    
    1/ check out an item and then check it back in.
    1/ check the logs after the check-in to see the warns from
       returns.pl line 623 of :
        (a) Use of uninitialized value $holdingBranch
        (b) Use of uninitialized value $collectionBranch
    2/ apply patch
    3/ check out and check-in again. no warns are recorded this time.
    
    NOTE: Under Debian Jessie, there are other messages.
          Additionally, this only corrects the line 623 ones.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit 0d632a606f499c31afb8a08f81625c4dfbddb445)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 circ/returns.pl |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list