[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.02-20-g7fe64b0

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  7fe64b0d0270f1cc4fc8829d4629f461b21f2338 (commit)
       via  d0b989a673af3794de410e92a4018ca59462d75b (commit)
      from  f88d0f1cff5a07a9a082194ddc6a57c536d72e88 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7fe64b0d0270f1cc4fc8829d4629f461b21f2338
Author: Stéphane Delaune <stephane.delaune at biblibre.com>
Date:   Thu Jul 23 16:28:57 2015 +0200

    Bug 10961: (followup) Make query fields explicit and add regression tests
    
    add correct frameworkcode to _koha_marc_update_bib_ids parameters
    
    add test, prove with : prove t/db_dependent/Biblio.t
    
    TEST PLAN
    ---------
    1) git checkout -b bug_10961 origin/master
    2) git bz apply 10961
    3) git checkout origin/master -- C4/Biblio.pm
    4) prove t/db_dependent/Biblio.t
       -- was expecting failure, got failure.
    5) git reset --hard origin/master
    6) git bz apply 10961
    7) prove t/db_dependent/Biblio.t
       -- success as expected.
    8) Read over code.
       -- Noted it also grabs the framework code for the biblio, rather than uses default.
          And it also corrects an indentation issue.
          Test case looks like it attempts to cover the biblionumber!=biblioitemnumber case
          by adding 1.
    9) run koha qa test tools.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit 62dc6b0ca15a9de99a1cb41809e6c9c016e6b0d0)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit d0b989a673af3794de410e92a4018ca59462d75b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Sep 27 12:53:39 2013 -0400

    Bug 10961: Error in GetMarcBiblio can cause severe data loss
    
    A bug in GetMarcBiblio can cause severe data loss if your database has
    records where the biblionumber and biblioitemnumber do not match and the
    script misc/batchRebuildBiblioTables.pl is run.
    
    The Biblio::GetMarcBiblio makes a kall to
    C4::Biblio::_koha_marc_update_bib_ids which passes the biblionumber as
    both the biblionumber *and the biblioitemnumber*.
    
    Thus, if your biblio and biblioitem numbers are not always equal, you
    will end up with a record where the biblioitemnumber is incorrect in the
    record!
    
    This is usually not a severe issue, but since batchRebuildBiblioTables
    uses that record to update the database tables, it ends up updating the
    wrong biblioitem row!
    
    NOTE: What a horrible, horrible typo that was. Tested this with the
          second patch.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit 298c4c76a5f231d9cc0935b6f14a5f191b727804)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm            |    8 +++++---
 t/db_dependent/Biblio.t |   19 ++++++++++++++++---
 2 files changed, 21 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository