[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-21-g595c8df

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.16.x has been updated
       via  595c8df72d2f2f0ef2837f3b9368d75c55d597af (commit)
      from  bc5ad9604518c0ac9514154269333d16f8b59590 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 595c8df72d2f2f0ef2837f3b9368d75c55d597af
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date:   Tue Jan 20 16:48:13 2015 +0200

    Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences
    
    When editing a Patron's messaging preferences or borrower attributes, one cannot
    save changes because 'userid' is not given as a parameter.
    
    It shouldn't, but the
    Check_Userid($newdata{'userid'},$borrowernumber) -check must have it.
    
    REPLICATE THE ISSUE:
    1. Find a Borrower.
    2. Go to the details-tab.
    3. Under "Patron messaging preferences" click edit to edit just the messaging
       preferences.
    4. Just save, no need to make any modifications.
    5. Observe the error "Username/password already exists"
       This happens to all/most of the sub-forms in the Borrower's Details-view.
    
    AFTER THIS PATCH:
    Check_Userid() get the $userid from the new parameters, or if not present, from
    the koha.borrowers-table.
    
    TEST FOR REGRESSION:
    1. Edit a borrower normally. Notice no errors.
    2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no
       errors.
    
    DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's
    extent without my permission. As long as it makes to Koha I am happy.
    
    Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

-----------------------------------------------------------------------

Summary of changes:
 members/memberentry.pl |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository