[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-24-g06c173e

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.16.x has been updated
       via  06c173efd58ea46da21a7e4a68247704e42b3733 (commit)
       via  53098ad2efa15c5113a17d810318af8deb98c4f8 (commit)
       via  771c294c7419818e47009e0af1335ba0410ad80a (commit)
      from  595c8df72d2f2f0ef2837f3b9368d75c55d597af (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 06c173efd58ea46da21a7e4a68247704e42b3733
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Nov 19 13:28:12 2014 -0500

    Bug 11954 - Clean up currency default files
    
    It makes no sense to have TRUNCATE or foreign key checks.
    
    TEST PLAN
    ---------
    1) Back up your database
    2) in an mysql client:
         use kohadata;
         SET FOREIGN_KEY_CHECKS=0;
         TRUNCATE currency;
         source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql
         SET FOREIGN_KEY_CHECKS=0;
         TRUNCATE currency;
         source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql
         SET FOREIGN_KEY_CHECKS=0;
         TRUNCATE currency;
         source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql
         SET FOREIGN_KEY_CHECKS=1;
         QUIT
       -- These should all work without problem.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

commit 53098ad2efa15c5113a17d810318af8deb98c4f8
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Nov 5 12:41:13 2014 +0100

    Bug 13201: GetSuggestion takes suggestionid
    
    Having $ordernumber as the parameter in a function which is
    handling suggestions and it is used as a suggestion id is
    confusing to the coder and person trying to read the code.
    This patch corrects the confusion.
    
    REVISED TEST PLAN
    -----------------
    1) perldoc C4::Suggestions
       -- notice it says ordernumber for the GetSuggestions example.
    2) Ensure you have CPL in your branches table.
    3) prove -v t/db_dependent/Suggestions.t
       -- if you have more than 8 itemtypes in your database, two
          tests at the end will fail, but that is not relevant to
          the modified GetSuggestions code.
    4) apply patch
    5) perldoc C4::Suggestions
       -- notice it is corrected now.
    6) prove -v t/db_dependent/Suggestions.t
       -- it should run with the same results as in step 3.
          That is, if you have 8 itemtypes, all pass, otherwise
          those two tests fail.
    7) run koha qa test tool
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

commit 771c294c7419818e47009e0af1335ba0410ad80a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 5 15:50:05 2014 +0100

    Bug 13401 - sort branches alphabetically in admin/authorised_values.pl
    
    This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages.
    
    Also replaces var $branch (too ambigus) by $branchcode.
    
    Test plan :
    - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch
    - Create a new authorized value : admin/authorised_values.pl
    - Look at "Libraries limitation" :
    => Without patch branches are sorted by code : Zbranch then Abranch
    => Without patch branches are sorted by name : Abranch then Zbranch
    - Select a branch and save
    - Re-edit
    => Check the same branch is selected
    
    Followed test plan. Patch behaves as expected.
    Signed-off-by: Marc Veron <veron at veron.ch>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Suggestions.pm                                       |    8 ++++----
 admin/authorised_values.pl                              |    8 ++++----
 installer/data/mysql/it-IT/necessari/parameters.sql     |    4 ----
 installer/data/mysql/ru-RU/optional/sample_currency.sql |    2 --
 installer/data/mysql/uk-UA/optional/sample_currency.sql |    2 --
 5 files changed, 8 insertions(+), 16 deletions(-)


hooks/post-receive
-- 
main Koha release repository