[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.01-58-gbec1614

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  bec1614a10a432a8770df0c0f07fd478868ffe61 (commit)
       via  3f92b5e38114572722b983961a1defc0a663989e (commit)
       via  fdf148d15fc647b3521daea84d2ca24626d7ffbf (commit)
       via  23ed6dd88f9bafa6ab0960936fecc2bd7649c613 (commit)
      from  acdf64889d6652750fd4b6b08525f85e752350da (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bec1614a10a432a8770df0c0f07fd478868ffe61
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri Jun 19 14:00:13 2015 -0400

    Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION
    
    While testing bug 9006, I discovered this gem in
    installer/install.pl
    
    TEST PLAN
    ---------
     1) back up DB
     2) drop db and create db
     3) git reset --hard origin/3.20.x
     4) run web installer and all sample data
     5) git reset --hard origin/master
     6) empty your koha intranet error log
     7) run web installer to upgrade
        -- there will be warnings regarding regex around
           installer/install.pl line 328 or so.
           grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log
     8) repeat steps 2-6
     9) apply this patch
    10) run web installer to upgrade
        -- no regex warnings.
           grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log
    11) koha qa test tools
    
    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit 5f3ec7109321f8e928371880e473e84d8db39f8d)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 3f92b5e38114572722b983961a1defc0a663989e
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Tue Jul 14 11:54:57 2015 +1200

    Bug 9942 : Bumping database version

commit fdf148d15fc647b3521daea84d2ca24626d7ffbf
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jun 25 17:22:25 2015 -0400

    Bug 9942: [QA Followup] - Add test and alert to returns.pl
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit efedadebf233cf7f2b8c1eb64d1687b282d94474)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 23ed6dd88f9bafa6ab0960936fecc2bd7649c613
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Thu Apr 9 13:07:05 2015 +0200

    Bug 9942: Make Koha fail if privacy is not respected
    
    If a patron has requested anonymity on returning items and the system is
    not correctly configured (AnonymousPatron no set or set to an inexistent
    patron), the application should take it into account and not fail
    quietly.
    
    This patch is quite radical: the script will die loudly if the privacy
    is not respected.
    
    To be care of the bad "Software error", some checks are done in the
    updatedatabase to be sure the admin will be warned is something is wrong
    in the configuration.
    
    Test plan:
    1/ Test the updatedatabase entry:
    a. Turn on OPACPrivacy and set AnonymousPatron to an existing patron
    => You will get a warning
    b. Turn on OPACPrivacy and set AnonymousPatron to 0 or ''
    => You will get a warning
    c. Turn on OPACPrivacy and set the privacy to 2 (Never) for at least 1 patron
    Turn off OPACPrivacy
    => You will get a warning
    d. In all other cases you will get no error
    
    2/ Test the interface
    a. Turn on OPACPrivacy and set the privacy to 2 (Never) for a patron
    b. Now you can turn off OPACPrivacy or keep it on, behavior should be
    the same
    c. check an item out the patron
    d. Check the item in using the check out table
    => fail
    e. Check the item in using the Check in tab
    => fail (not gracefully).
    
    Note that the software error could appear on other pages too.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Updatedatabase works as described
    On staff, if don't have correct settings for anonymity it's
    impossible to check-in (with OPACPrivacy on)
    No errors
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit 94315f663b8a582fb7ef68de2bd9c3933901cd7f)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |   28 +++++++---
 Koha.pm                                            |    2 +-
 installer/data/mysql/updatedatabase.pl             |   33 ++++++++++++
 installer/install.pl                               |    2 +-
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |    5 ++
 t/db_dependent/Circulation/MarkIssueReturned.t     |   55 ++++++++++++++++++++
 6 files changed, 117 insertions(+), 8 deletions(-)
 create mode 100644 t/db_dependent/Circulation/MarkIssueReturned.t


hooks/post-receive
-- 
main Koha release repository