[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.01-60-gce9b5d8

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  ce9b5d8904c0d46350418ed2252fd06910c01b8c (commit)
       via  01fe4aea32829dccb6bb71b4d69e1a603a9fdbb1 (commit)
      from  bec1614a10a432a8770df0c0f07fd478868ffe61 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ce9b5d8904c0d46350418ed2252fd06910c01b8c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jul 3 11:02:22 2015 +0200

    Bug 14382: [QA Follow-up] Bad regex alarm
    
    The regex /|date>>/ will match much more than you like :)
    The unescaped pipe is bad, but you also need to remove the >> because
    the split a few lines above it removes them already.
    
    This allows you to recover from an error like this one, running another
    report with a string parameter:
    The given date (india%) does not match the date format (us) at
    Koha/DateUtils.pm line 144.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended for possible spaces around the word date.
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    
    (cherry picked from commit bfea40b6e8161629c11d97be5eeba56fb6d59ba3)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 01fe4aea32829dccb6bb71b4d69e1a603a9fdbb1
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Jun 24 12:13:46 2015 -0400

    Bug 14382: Non-ISO Date parameters generate empty reports.
    
    The issue is that SQL expects ISO dates, but the user may wish to view dates according to the dateformat system preference.
    
    By detecting a date preference, the non-ISO dates can be converted to ISO dates before being stuffed back into the SQL query to be executed.
    
    TEST PLAN
    ---------
    1) Add a report with date parameters.
       -- I used 'Holds placed in date range' from
          http://wiki.koha-community.org/wiki/SQL_Reports_Library
    2) Set your dateformat to YYYY-MM-DD
    3) Run the report
       -- Note the SQL reads
          "... BETWEEN '{date formatted in YYYY-MM-DD}'..."
       -- If there is supposed to be data, there is some.
    4) Set your dateformat to MM/DD/YYYY
    5) Run the report
       -- Note the SQL reads
          "... BETWEEN '{date formatted in MM/DD/YYYY}'..."
       -- If there is supposed to be data, there is none.
    6) Apply patch
    7) Repeat steps 2-5
       -- The SQL will always read YYYY-MM-DD (ISO) format.
       -- The report will have data, if there is some.
    8) koha qa test tools.
    
    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Adding a QA follow-up.
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    
    (cherry picked from commit c3fea53039a6c53c766b0403eedd57f644c6f772)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Conflicts:
    	reports/guided_reports.pl

-----------------------------------------------------------------------

Summary of changes:
 reports/guided_reports.pl |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository