[koha-commits] main Koha release repository branch master updated. v3.20.00-572-g72d9c28

Wed Sep 16 15:49:17 CEST 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  72d9c28bbf2b715fddc684fbb4a8b79c27a9fa49 (commit)
       via  cef7cd40ce5b2fe1505245cf232d4338b10eba3e (commit)
       via  d671b8661cf02d8b039eb5230ab732fd1fde2301 (commit)
       via  f062542978ec6841948bf3e25c053762684346e9 (commit)
       via  0b6460b1916aaa6b08f2f12fd3d6832c3715db3f (commit)
       via  c7a6745bc0e0241e5f39a12e2ff4e17678288b14 (commit)
       via  9f8f33e351e1ae5810441a0c9ff7226aafb63c8b (commit)
       via  cb4ce631c316a41ac47a17bfdaa4e5591e0e37df (commit)
       via  a71cc14a52589f45bc30dad81b8c7fc0ac35d9fc (commit)
       via  f704fbebd86e0034cf285b2dd29c0d85cb2086a2 (commit)
       via  70133ef343e7885b4d237e51351bf05f4e490850 (commit)
       via  8b710d62d1414a89b686f3a440bf03552e7e1d04 (commit)
       via  fdc859281cc2af56431d183c3341ec9f8d4f672c (commit)
       via  aaf2903cc0e86a2e59b3c7e223d7d8a85778ca0d (commit)
       via  cb2151529e0c2d031a01e68bd5deab26d2ffbaff (commit)
      from  8dfde8b85a6eeea4db4f79e35d6540d0bfc9cdf4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 72d9c28bbf2b715fddc684fbb4a8b79c27a9fa49
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 18 14:19:19 2015 +0200

    Bug 13622: [QA Follow-up] Add unit test descriptions

    This report adds a few unit tests for datonly flag in notices.
    This patch adds (very trivial) unit test descriptions.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit cef7cd40ce5b2fe1505245cf232d4338b10eba3e
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Jan 26 17:24:36 2015 +0100

    Bug 13622: Display a datetime without time in a notice

    For some needs, a librarian would like to display a datetime or
    timestamp field without the time.

    This patch adds filter logic in the notice/letter parsing process.

    Test plan:
    1/ Defined a notice using a datetime or timestamp DB field
    (biblio.timestamp for instance).
    2/ Generate the notice
    3/ Verify that the letter is generated with the time
    4/ Use the "dateonly" filter like:
      <<your_table.your_field | dateonly>>
      <<biblio.timestamp | dateonly>>
    5/ Generate the notice
    6/ Confirm the the letter is generated without the time for this field.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>

    Updated the count of tests to 64 for t/db_dependent/Letters.t to pass
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit d671b8661cf02d8b039eb5230ab732fd1fde2301
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Sep 14 10:28:01 2015 +0100

    Bug 14813: Fix encoding issues on editing help pages

    It has been introduced by bug 11944.

    Test plan:
    1/ Install and set the fr-FR language (or ar-Arab).
    2/ Go on the help page and edit it.
    3/ The textarea should not contain encoding issues with this patch.

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit f062542978ec6841948bf3e25c053762684346e9
Author: Jonathan Druart <jonathan.druart at koha-community.org>
Date:   Thu Jul 9 09:35:12 2015 +0100

    Bug 14197: TestBuilder - Remove the error on starting the transaction

    DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560.
    DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit 0b6460b1916aaa6b08f2f12fd3d6832c3715db3f
Author: Jonathan Druart <jonathan.druart at koha-community.org>
Date:   Wed May 13 17:58:45 2015 +0200

    Bug 14197: Remove the warning on destroying TestBuilder objects

    This module will be called by db_dependent tests, which already create a
    transaction.
    TestBuilder creates a new one (which is certainly useless) and the
    rollback does not do anything.

    To see the warning see patches on bug 14045.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit c7a6745bc0e0241e5f39a12e2ff4e17678288b14
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jul 10 15:18:48 2015 +0100

    Bug 8723: Update hold_fill_targets, tmp_holdsqueue and linktracker tables

    Same as previous patch for 3 other tables.

    Test plan:
    Same as before but the hold should exist to the 3 tables before the
    move.

    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit 9f8f33e351e1ae5810441a0c9ff7226aafb63c8b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jul 10 15:04:55 2015 +0100

    Bug 8723: Update the reserves table for item-level holds

    If an item is moved from a biblio to another, the holds should be
    updated too.

    See discussion on the bug report for more information.

    Test plan:
    1/ Place a item-level hold on biblio1
    2/ Move the item to biblio2
    3/ Confirm that the hold still exists and point to the biblio2

    This patch should not change the existing behavior for bib-level holds.

    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit cb4ce631c316a41ac47a17bfdaa4e5591e0e37df
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jul 10 14:15:42 2015 +0100

    Bug 8723: Cover the existing behavior

    This patch cover the MoveItemFromBiblio subroutine

    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit a71cc14a52589f45bc30dad81b8c7fc0ac35d9fc
Author: Marc Véron <veron at veron.ch>
Date:   Sat Sep 5 16:41:58 2015 +0200

    Bug 14782: Add possibility to search patrons using the username (userid)

    This patch makes it possible to search for users using the username (userid / login name).

    To test:

    - Apply patch
    - Do searches from Home > Patrons
    - Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid
    - Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left
    - Make sure that other searches behave as before

    Signed-off-by: Joonas Kylmälä <j.kylmala at gmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit f704fbebd86e0034cf285b2dd29c0d85cb2086a2
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Sun Sep 13 18:06:46 2015 +0200

    Bug 14782: Add tests

    Run:
    perl t/db_dependent/Utils/Datatables_Members.t

    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit 70133ef343e7885b4d237e51351bf05f4e490850
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Sep 14 11:11:11 2015 +0200

    Bug 14801: Fix Reserves.t -- Follow-up for ChargeReserveFee

    The problem making some tests fail, actually was the unneeded addition
    of zero accountline records by ChargeReserveFee, called by AddReserve.
    The balance is still zero, but a test like !$var responds differently
    when var is 0.00 instead of 0 or undef.

    This patch adjusts the test in ChargeReserveFee in order to prevent
    adding these records with 0.00.
    The first patch that adjusts the tests in Reserves.t is not strictly
    needed anymore, but can stay.

    Test plan:
    [1] Run t/db_dependent/Reserves.t
    [2] Run t/db_dependent/Reserves/GetReserveFee.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit 8b710d62d1414a89b686f3a440bf03552e7e1d04
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Sep 10 16:39:51 2015 +0200

    Bug 14801: Fix Reserves.t

    Fix the following errors:
    not ok 59 - Bug 14464 - No fines at beginning
    ok 60 - Bug 14464 - 1st reserve correctly created
    not ok 61 - Bug 14464 - No fines after cancelling reserve with no charge configured
    ok 62 - Bug 14464 - 2nd reserve correctly created
    not ok 63 - Bug 14464 - No fines after cancelling reserve with no charge desired

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Marc Veron <veron at veron.ch>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended the x==0 test with !x || x==0 to include 0.00 and prevent warn.
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit fdc859281cc2af56431d183c3341ec9f8d4f672c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Sep 14 13:22:21 2015 +0100

    Bug 14655: Fix wording

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Fixed a missing space after Error: :)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit aaf2903cc0e86a2e59b3c7e223d7d8a85778ca0d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 18 18:15:02 2015 +0100

    Bug 14655: Add a warning on the about page if patrons have requested privacy

    New warning on the about page if at least a patron has requested a
    privacy on checkin but the AnonymousPatron is not set to a valid patron.

    Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

commit cb2151529e0c2d031a01e68bd5deab26d2ffbaff
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 18 18:10:37 2015 +0100

    Bug 14655: Add a warning if the checkin will fail

    On the checkin and checkout page, the checkin will fail if the patron
    has requested the privacy and the AnonymousPatron is not correctly set.

    This patch adds a warning message on both pages.

    Test plan:
    0/ Be sure you don't have any patron with privacy=2 (Never)
    1/ Set OPACPrivacy, not AnonymousPatron
    2/ Go on the checkin, you should a warning (same as before this patch).
    3/ Set the privacy=2 for a patron
    4/ Go on the circulation page, a warning should appear (for this
    specific patron)
    5/ Check an item out to this patron
    6/ Check the item in on the checkin page.
    The item is not checked in and you get a specific message for this
    patron.

    Confirm other/correct situations don't trigger the messages.

    Followed test plan. Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    2 +-
 C4/Items.pm                                        |   26 ++++--
 C4/Letters.pm                                      |   43 ++++++----
 C4/Reserves.pm                                     |    2 +-
 C4/Utils/DataTables/Members.pm                     |    3 +-
 about.pl                                           |    5 ++
 circ/returns.pl                                    |    1 +
 edithelp.pl                                        |   15 ++--
 .../prog/en/includes/patron-search.inc             |    5 ++
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt   |    3 +
 .../prog/en/modules/circ/circulation.tt            |    5 ++
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |    9 ++-
 .../prog/en/modules/members/member.tt              |    5 ++
 svc/members/search                                 |    2 +-
 t/db_dependent/Items/MoveItemFromBiblio.t          |   84 ++++++++++++++++++++
 t/db_dependent/Letters.t                           |   40 +++++++++-
 t/db_dependent/Reserves.t                          |    6 +-
 t/db_dependent/Utils/Datatables_Members.t          |   25 +++++-
 t/lib/TestBuilder.pm                               |    8 +-
 19 files changed, 245 insertions(+), 44 deletions(-)
 create mode 100644 t/db_dependent/Items/MoveItemFromBiblio.t

hooks/post-receive
-- 
main Koha release repository