[koha-commits] main Koha release repository branch master updated. v3.20.00-580-ga37b3bb
Git repo owner
gitmaster at git.koha-community.org
Wed Sep 16 16:02:57 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via a37b3bb7f76b5ddea7400f5268c592c0cc578a8c (commit)
via 10820de380695f90fd544b40b52682efcf83a962 (commit)
via e5f604378a45d62e8b454cd390abb18b34ef53f8 (commit)
via a2ca59efb877945f7b2ebc92e7643d4cdaf9d4e1 (commit)
via ae5ee62d598ccb0cfe4fb6cc4a3b2ab6408febd8 (commit)
via 704aed77ea03bf8a0a0e4ece457e91fb7937742d (commit)
via 1acddd0f1b41e9e5f75b75d9d101c8b0879c00c5 (commit)
via 224b1c7976567511f1d6715784274169e006edcf (commit)
from 72d9c28bbf2b715fddc684fbb4a8b79c27a9fa49 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a37b3bb7f76b5ddea7400f5268c592c0cc578a8c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Aug 25 10:35:28 2015 -0400
Bug 14640: 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out.
This bug is dealing with the situation where an item is checked out to a
patron that is not the next in line hold-wise for an item. In this case,
Koha will warn the librarian that there are holds on the item and
show the first person in line. Again, I want to stress that this
is the case where the item *is not waiting* for a patron. The
hold for the patron listed will just have a priority of 1.
The only situation where the "Cancel hold" checkbox will function
is when the priority 1 hold is an item level hold. This is due to
the fact that CancelReserve is being passed the trio of
biblionumber, borrowernumber, and itemnumber rather than the
singular reserve_id.
1) place biblio level hold on a book to borrower A.
2) check out an item of the book to borrower B.
3) When confirming checkout, check the 'Cancel hold' check-box, and
click the "Yes, check out" button.
4) Note the hold was not canceled
5) Apply this patch
6) Repeat steps 1 through 3
7) Note the hold was indeed canceled
Signed-off-by: Joonas Kylmälä <j.kylmala at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 10820de380695f90fd544b40b52682efcf83a962
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 1 10:52:51 2015 +0100
Bug 14640: Add tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit e5f604378a45d62e8b454cd390abb18b34ef53f8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 14 15:02:42 2015 +0100
Bug 10005: Inventory - Add an option to not check in items
The inventory tools automatically check in items, this patch adds it as
an option.
Test plan:
1/ Check an item out, fill a file with its barcode, and use this file in
the inventory tools.
2/ Check the new checkbox and confirm that the item is not checked in
3/ Repeat again and don't check it, the behavior should be the same as before
this patch.
Signed-off-by: Jason Robb <jrobb at sekls.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Added a missing </li>.
Patch works as expected.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit a2ca59efb877945f7b2ebc92e7643d4cdaf9d4e1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 2 14:28:52 2015 +0100
Bug 7634: Prevent permanent_location to be set to NULL if not defined
The permanent_location is correctly filled when an item is added from
the cataloguing module (routine set_item_default_location from
cataloguing/additem.pl).
But when records are imported, this filled is not managed. It's only on
editing (_do_column_fixes_for_mod called from ModItem).
This patch set the permanent_location item fields to the location value for all
items created, even the imported ones.
Test plan:
0/ Do not apply this patch
1/ Import a record with items using the "Stage MARC for import" tool
2/ Check the values for the permanent_location in the items table.
They are set to NULL
3/ Apply this patch
4/ Repeat 2 and confirm that now the permanent_location values are set
to the location values.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit ae5ee62d598ccb0cfe4fb6cc4a3b2ab6408febd8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 2 14:46:02 2015 +0100
Bug 7634: Add tests
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 704aed77ea03bf8a0a0e4ece457e91fb7937742d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 2 14:43:15 2015 +0100
Bug 7634: Make the tests pass
This patch just fixed a master bug, if your database already has some
items.homebranch set to CPL
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 1acddd0f1b41e9e5f75b75d9d101c8b0879c00c5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 14 11:38:41 2015 +0100
Bug 6756: Add info messages
NOTE: Before patch "./misc/cronjobs/batch_anonymise.pl --help" had no
message, and neither did the anonymizing tool in the staff client.
After the patch, both had informative messages.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 224b1c7976567511f1d6715784274169e006edcf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 14 11:30:51 2015 +0100
Bug 6756: Fix bad behaviors if AnonymousPatron is not defined
There are at least 2 wrong behaviors if the AnonymousPatron pref is not
defined (0 or empty string).
1/ If you use the clean borrower tools, you will get a successful
message when the nothing happened (the history has not been anonymised).
2/ At the OPAC, if a patron ask for delete his reading history, he will
get an error message "The deletion of your reading history failed,
because there is a problem with the configuration of this feature.
Please help to fix the system by informing your libr ary of this
error". IMO this should not happen, the history should be anonymised.
With this patch, the old_issues.borrowernumber field will be set to NULL
if the AnonymousPatron pref if not defined.
Test plan:
1/ Fill the pref with "" or 0
2/ At the OPAC, go on the privacy tab and click on the "Immedia deletion" button.
You should get a green and friendly message. Confirm that the history
has been anonymised.
3/ Use the "Batch patron anonymization" tools (tools/cleanborrowers.pl)
to anonymize the checkout history.
Confirm that a) it works and b) you get a message.
Try again with AnonymousPatron set to a valid patron. You should not see
any changes with the current behaviors.
NOTE: This patch tweaks C4/Circulation.pm and provides tests.
applying just this, and running prove success. Reverting just
C4/Circulation.pm fails, as expected.
Tested OPAC stuff with both patches applied.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 5 +-
C4/Items.pm | 1 +
C4/Reserves.pm | 6 +-
.../prog/en/modules/tools/cleanborrowers.tt | 4 +
.../prog/en/modules/tools/inventory.tt | 4 +
misc/cronjobs/batch_anonymise.pl | 1 +
t/db_dependent/Circulation/AnonymiseIssueHistory.t | 138 ++++++++++++++++++++
t/db_dependent/Circulation_issue.t | 26 ++--
t/db_dependent/Items.t | 18 ++-
tools/inventory.pl | 19 +--
10 files changed, 195 insertions(+), 27 deletions(-)
create mode 100644 t/db_dependent/Circulation/AnonymiseIssueHistory.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list