[koha-commits] main Koha release repository branch master updated. v16.05.00-392-g6ac4b20
Git repo owner
gitmaster at git.koha-community.org
Fri Jul 22 19:20:05 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 6ac4b20d3ab548621d6ffc8a931b947fdb3eb6f2 (commit)
via ec2271227c6f7beaf0016b618daebd31ee42d515 (commit)
via 00eeb41162066f80053e29a728a1510a8626eb24 (commit)
via 0e9c3d446d999b00558611746f433cf193669adf (commit)
via f3d7f271078f10837b5d1877e2cdfee209c98381 (commit)
via 0e80c75aee02157b1fc4121ecf3b039f6f797b7b (commit)
via bea95dace6d6e3d4eb99c1985f7f80e50cc6beb5 (commit)
via 04c7a8a845fb780c72d412133a4b97056c35301e (commit)
via 814a1d4231c8e71613ce58a72b30a539654c34ee (commit)
via 6d75e385c818212cc10a9832b5a5525cbef6e6b2 (commit)
via 9deb1ace53a16d245a7dfbefd8df016822dae850 (commit)
from 66a8c9655079f141c9185aea329435e3a63bbd0a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 6ac4b20d3ab548621d6ffc8a931b947fdb3eb6f2
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jul 22 17:21:42 2016 +0000
Bug 11606 - DBRev 16.06.00.011
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit ec2271227c6f7beaf0016b618daebd31ee42d515
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jul 22 10:26:12 2016 +0100
Bug 15451: Better error handling
1/ If a librarian edit (add_validate) a non-existing csv profile, we
explicitely die
2/ If you try to delete a non-existing csv profile, you will now get a
nice alert box
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 00eeb41162066f80053e29a728a1510a8626eb24
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Wed Apr 27 22:28:08 2016 -0300
Bug 15451: (followup) fix filename extension for csv file
This patch does the same as basket/downloadcart.pl
to set '.csv' as filename extension for downloadshelf.pl
To test:
1) Define a CSV MARC profile
2) On staff download a list, extension is '.NN'
with 'NN' the CSV profile id.
3) Apply the patch
4) Download again, check extension is now '.csv'
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 0e9c3d446d999b00558611746f433cf193669adf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 6 08:58:13 2016 +0000
Bug 15451: Do not considered a Resultset as a Result
The previous calls were wrong, but there is something bad with the DB
structure: export_format.profile should be a unique key.
This patch fixes the previous calls and add a FIXME not to forget to fix
the DB structure.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Previous test where done with all patches applied,
including this one, and all worked.
No errors
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit f3d7f271078f10837b5d1877e2cdfee209c98381
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 30 18:28:55 2015 +0000
Bug 15451: Koha::CsvProfiles - Remove the residue
This patch erase all traces of C4::Csv since it's not used anymore.
All occurrences have been replaced by previous patches to use
Koha::CsvProfiles.
Note that GetMarcFieldsForCsv was not used prior this patch set.
Test plan:
git grep 'C4::Csv'
should not return any result.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No more traces of the file.
This produces a koha-qa fail, due to the missing file.
No other errors
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 0e80c75aee02157b1fc4121ecf3b039f6f797b7b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 30 18:26:17 2015 +0000
Bug 15451: Koha::CsvProfiles - Remove GetCsvProfile
This subroutine just returned a csv profile for a given id.
It is replaced in this patch by a call to Koha::CsvProfiles->find.
There is nothing to test here, these changes have been tested in
previous patches.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit bea95dace6d6e3d4eb99c1985f7f80e50cc6beb5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 30 18:23:24 2015 +0000
Bug 15451: Koha::CsvProfiles - Remove GetCsvProfileId
This subroutine returned the export_format_id for a given profile name.
This can be done easily with the Koha::CsvProfiles->search method.
Test plan:
Export records using the misc/export_records.pl script and the
export tool.
If you are exporting using the MARC format, the profile filled in the pref
ExportWithCsvProfile will be used (or the one passed in parameter of
misc/export_records.pl).
If you are exporting using the CSV format, you can choose a profile in
the dropdown list.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Exported using tool & cmd, marc & csv. Pref is used.
No errors
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 04c7a8a845fb780c72d412133a4b97056c35301e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 30 18:16:01 2015 +0000
Bug 15451: Koha::CsvProfiles - Remove GetCsvProfiles
This subroutine did the same job as GetCsvProfilesLoop, so this patch
applies the same changes as the previous patch.
Test plan:
1/ Claim some serials, sql profiles should be listed
2/ Export records using the export tool. MARC profiles should be listed.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Listed sql & marc profiles
No errors
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 814a1d4231c8e71613ce58a72b30a539654c34ee
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 31 10:32:35 2015 +0000
Bug 15451: Koha::CsvProfiles - Remove GetCsvProfilesLoop
This subroutine returned the csv profiles for a given type.
This could be done easily with the new Koha::CsvProfiles->search method.
Test plan:
To do at the OPAC and staff interface!
1/ Export a list using a CSV profile
2/ Export your CART using a CSV profile
Note that only MARC profiles should be available.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested on staff/opac & cart/list
Small problem on filename extension fixed in followup.
No errors
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 6d75e385c818212cc10a9832b5a5525cbef6e6b2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 31 10:23:24 2015 +0000
Bug 15451: Rewrite the csv profile tool script
This page was inconsistent with the other admin and tool pages.
The 2 tabs 'New profile' and 'Edit existing profile' were useless, the
ergonomic needs to be revisited.
This patch applies the same script/page structure as others: by default
a table containing all csv profiles is displayed with 2 action links:
edit and delete.
Test plan:
1/ Create 1+ CSV profiles, with different types (marc and sql)
2/ Update some values using the Edit link
3/ Delete a CSV profile
Note: When deleting a CSV profile, it would be great to warn the user if it is
used.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No problems on create, update and delete.
No errors
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 9deb1ace53a16d245a7dfbefd8df016822dae850
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 31 10:22:47 2015 +0000
Bug 15451: Add the 2 new modules Koha::CsvProfile[s]
There are based on Koha::Objets. Tests provided.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Test pass, no errors.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Csv.pm | 116 ----
C4/Record.pm | 18 +-
Koha.pm | 2 +-
Koha/{Patron/Image.pm => CsvProfile.pm} | 6 +-
Koha/{Patron/Messages.pm => CsvProfiles.pm} | 10 +-
Koha/Exporter/Record.pm | 8 +-
basket/basket.pl | 8 +-
basket/downloadcart.pl | 9 +-
.../Bug_11606_Add_NovelistSelect_Staff_Prefs.sql | 2 -
installer/data/mysql/updatedatabase.pl | 12 +
.../prog/en/modules/tools/csv-profiles.tt | 614 ++++++++------------
misc/export_records.pl | 9 +-
opac/opac-downloadcart.pl | 9 +-
opac/opac-downloadshelf.pl | 7 +-
serials/claims.pl | 8 +-
serials/lateissues-export.pl | 11 +-
t/db_dependent/Csv.t | 67 ---
t/db_dependent/Koha/CsvProfiles.t | 57 ++
tools/csv-profiles.pl | 161 ++---
tools/export.pl | 13 +-
virtualshelves/downloadshelf.pl | 14 +-
virtualshelves/shelves.pl | 5 +-
22 files changed, 476 insertions(+), 690 deletions(-)
delete mode 100644 C4/Csv.pm
copy Koha/{Patron/Image.pm => CsvProfile.pm} (89%)
copy Koha/{Patron/Messages.pm => CsvProfiles.pm} (84%)
delete mode 100644 installer/data/mysql/atomicupdate/Bug_11606_Add_NovelistSelect_Staff_Prefs.sql
delete mode 100755 t/db_dependent/Csv.t
create mode 100644 t/db_dependent/Koha/CsvProfiles.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list