[koha-commits] main Koha release repository branch master updated. v16.05.00-394-g1766b10

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  1766b10d525819629219ee5f34a1201a6dadc7fa (commit)
       via  131002e6230f2b69f0d6007b75fbc90444745b68 (commit)
      from  6ac4b20d3ab548621d6ffc8a931b947fdb3eb6f2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1766b10d525819629219ee5f34a1201a6dadc7fa
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jul 4 15:06:18 2016 +0100

    Bug 16847: Add empty option to Salutation/title
    
    At the OPAC there is no way to empty this value.
    I think it should be allowed to empty it.
    
    Signed-off-by: Marc Véron <veron at veron.ch>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 131002e6230f2b69f0d6007b75fbc90444745b68
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jul 4 15:03:18 2016 +0100

    Bug 16847: Remove C4::Members::GetTitles
    
    This subroutine just reads the content of a pref, split it, add an
    empty string and returns.
    It is not really useful and the code in the script (memberentry.pl) uses
    the only occurrence of CGI::popup_menu
    Let's remove it and build the dropdown list in the template.
    
    Test plan:
    1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation"
    does not appear
    2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm
    that the "Salutation" dropdown list is correctly filled.
    The default option should be selected if you are editing a patron with a
    title defined.
    This should also be tested at the OPAC.
    
    Followed test pan, works as expected in Staff and OPAC
    Signed-off-by: Marc Véron <veron at veron.ch>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                                      |   21 --------------------
 .../prog/en/modules/members/memberentrygen.tt      |   13 ++++++++++--
 .../bootstrap/en/modules/opac-memberentry.tt       |    5 +++--
 members/memberentry.pl                             |   10 +---------
 opac/opac-memberentry.pl                           |    1 -
 5 files changed, 15 insertions(+), 35 deletions(-)


hooks/post-receive
-- 
main Koha release repository