[koha-commits] main Koha release repository branch master updated. v3.22.00-862-g3352ca6

Git repo owner gitmaster at git.koha-community.org
Sun Mar 13 00:29:49 CET 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  3352ca6a70c92c2a41a5007016e5ac721b567d16 (commit)
      from  5b89339272f4430a298363db2acb816ee9178fc4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3352ca6a70c92c2a41a5007016e5ac721b567d16
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Feb 23 12:07:17 2016 -0500

    Bug 15886 - Revise layout and behavior of audio alerts management
    
    This patch changes the behavior of the audio alerts management page so
    that sections of the page are shown or hidden based on what the current
    task is. Other changes include:
    
    - Moving JavaScript to a separate file
    - Adding a toolbar with a "New alert" button.
    - Enabling or disabling the "play sound" button based on the value of
      the sound file field.
    - Enabling or disabling the "delete" button based on whether there are
      checkboxes checked.
    - Switching the patron category administration header search form for
      the "generic" catalog search one.
    - Adding "Required" classes to required fields so that the staff
      client's built-in JS validation library can be used.
    - Styling the add/edit form in a way which is consistent with other
      interfaces in Koha.
    - Removing the invalid "border" attribute from images.
    - Adding better alt attributes to images.
    
    To test, the AudioAlerts system preference must be enabled. Apply the
    patch and go to Administration -> Audio alerts.
    
    - Confirm that the add/edit form is hidden initially. A toolbar with a
      "New" button should appear with existing audio alerts in a table
      below.
    - Confirm that the "New alert" button works:
      - The table should be hidden and an empty "add" form displayed.
      - Confirm that an empty form cannot be submitted.
      - Confirm that typing or selecting a sound enables the "Play sound"
        button and that it works to play the sound.
      - Confirm that adding valid data works.
      - Confirm that clicking the "Cancel" button hides the form and
        redisplays the table.
    - Test the "edit" button for an existing sound:
      - Confirm that the edit form is displayed and populated with the
        correct data.
      - Confirm that edits are saved correctly.
    - When viewing the table of existing alerts, confirm that checking one
      of the checkboxes "enables" the delete button.
    - With one or more checkboxes checked, test that clicking the delete
      button triggers a deletion confirmation. Test both confirm and cancel
      operations.
    - With no checkboxes checked, test that clicking the delete button
      triggers an alert that checkboxes must be checked.
    - Ponder whether all this is an improvement or not.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/js/audio_alerts.js |   89 +++++++++++
 .../prog/en/modules/admin/audio_alerts.tt          |  169 +++++++-------------
 2 files changed, 151 insertions(+), 107 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/js/audio_alerts.js


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list