[koha-commits] main Koha release repository branch master updated. v3.22.00-863-g186f630

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  186f630407573fd5a48522457685cebd13abc6db (commit)
      from  3352ca6a70c92c2a41a5007016e5ac721b567d16 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 186f630407573fd5a48522457685cebd13abc6db
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 25 12:37:58 2016 +0000

    Bug 15653: Remove unused C4::Members::UpdateGuarantees subroutine
    
    Looking at the code, there is some broken with the guarantees code.
    It seems that the expected behavior would be to update address, fax,
    B_city, mobile, city and phone info of the guarantees when a guarantor
    is modified.
    But the code in C4::Members::ModMember is broken:
    
     668         my $borrowercategory= GetBorrowercategory(
    $data{'category_type'} );
     669         if ( exists  $borrowercategory->{'category_type'} &&
    $borrowercategory->{'category_type'} eq ('A' || 'S') ) {
     670             # is adult check guarantees;
     671             UpdateGuarantees(%data);
     672         }
    
    First, GetBorrowerCategory expects a categorycode, not a category_type.
    Then UpdateGuarantees retrieves the param like:
    
     989 sub UpdateGuarantees {
     990     my %data = shift;
    
    Which means that %data will always be something like ( a_key => undef )
    And nothing more.
    
    The updateguarantees subroutine (It has been renamed) has been introduced by
    
    commit 56825e415fc232e38f0a874dc9a81fa2169ef06b
    Date:   Mon Aug 30 13:48:58 2004 +0000
        modularizing (with Members.pm) members management
        (beginning of...)
    
    And the `%data = shift` already existed...
    
    This code has never worked and could be removed.
    
    See http://lists.koha-community.org/pipermail/koha-devel/2016-January/042241.html
    
    Test plan:
    Confirm the previous assertions.
    
    Note that I have found this bug working on bug 15631, see patch "Bug
    15631: Koha::Cities - remove getidcity and GetCities"
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm |   35 -----------------------------------
 1 file changed, 35 deletions(-)


hooks/post-receive
-- 
main Koha release repository