[koha-commits] main Koha release repository branch master updated. v16.05.00-751-g6378027

Fri Sep 9 13:48:32 CEST 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  6378027fd29cf0b208850a4bff33b7c81f51f35d (commit)
       via  82ffd2812c94760e080a400007c803819f0618be (commit)
       via  2b84e18575efbd5edb0552a016f1a4aab3093444 (commit)
       via  7bdc106c986fb2ca57426797b3f9b85d2abab4a3 (commit)
      from  d6fba2e2f35a840c9cff8b0c05869e0a21ca09e2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6378027fd29cf0b208850a4bff33b7c81f51f35d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Jul 28 08:43:48 2016 +0200

    Bug 16365: [QA Follow-up] Add some comment lines to Cache.pm

    Resolve typo inifinite too.
    Adds a few lines in order to stress that the thawed key of the L1
    cache SHOULD ONLY be used for unsafe calls, and not be mixed with
    regular (safe) calls.

    Test plan:
    Nothing to test, but verify the quality of the added comments.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 82ffd2812c94760e080a400007c803819f0618be
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Jul 28 10:29:18 2016 +0200

    Bug 16365: Adding additional unsafe call-candidates from Acquisition

    [1] Candidate 1 is FillWithDefaultValues.
    This routine in Acquisition.pm does not autovivify the tagslib
    structure but first collects the keys at tag and subfield level.
    So, unsafe can be safely added here :)

    [2] Candidate 2 is script acqui/neworderempty.pl.
    It only (!) uses GetMarcStructure to know if there is a ACQ framework.
    There should be cheaper ways to do it, but when we use the fast cache,
    it does not matter that much anymore.

    [3] Candidate 3 is script acqui/orderreceive.pl. Same reason as [2].

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested with neworderempty.pl

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 2b84e18575efbd5edb0552a016f1a4aab3093444
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Wed Jul 27 11:38:00 2016 +0200

    Bug 16365 - GetMarcStructure() "unsafe" variant in PrepareItemrecordDisplay()

    This sub is a good candidate for the "unsafe" treatment too, it doesn't
    modify nor autovivify anything in the marc structure.

    Added a warning in the code regarding the $tagslib usage by the
    custom item plugins, plus a small change to prevent possible
    "Use of uninitialized value" warnings in the future.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested with neworderempty.pl and itemrecorddisplay.pl.
    Amended slightly: Made warning less dramatic.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 7bdc106c986fb2ca57426797b3f9b85d2abab4a3
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Wed Apr 27 13:19:10 2016 +0200

    Bug 16365: Selectively introduce GetMarcStructure() "unsafe" variant for better performance

    GetMarcStructure() currently uses Koha::Cache in the "safe" mode
    (returning deep copy of the result data structure by default), which
    causes numerous performance issues in many Koha scripts. Switching
    it to the "unsafe" mode globally (2nd patch from Bug 16140) resolves
    those issues, but ensuring that it is regression-free (and that it
    will stay that way in the future) is far from easy. This patch
    proposes a bit more manageable solution, it introduces
    a possibility to use "unsafe" variant selectively (only in those
    places in the code where GetMarcStructure() is called repetitively).
    That way, amount of the code that needs to be audited for possible
    problems gets vastly reduced, without any performance trade-offs.

    Test plan:
    1) Have a look at the code and audit the parts affected by this patch
    for possible regressions

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended the POD of GetMarcStructure, removing a TODO.

    NOTE: GetAuthorisedValueDesc, as called in C4::XSLT::transformMARCXML4XSLT
    and by GetISBDView, GetMarcAuthors in C4::Biblio, may autovivify some hash
    entries in tagslib.
    Same for Koha/Filter/MARC/ViewPolicy.pm, sub filter.

    No reason however to worry; our use of this structure in Koha does not
    depend on the existence of intermediate hash keys. (We seem to be safe as
    long as $tagslib->{$tag}->{$subfield}->{tab} and/or hidden are not filled.)

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm              |    2 +-
 C4/Biblio.pm                   |   21 ++++++++++++++-------
 C4/Items.pm                    |   10 +++++++---
 C4/XSLT.pm                     |    2 +-
 Koha/Cache.pm                  |    9 +++++++--
 Koha/Filter/MARC/ViewPolicy.pm |    2 +-
 acqui/neworderempty.pl         |    2 +-
 acqui/orderreceive.pl          |    2 +-
 8 files changed, 33 insertions(+), 17 deletions(-)

hooks/post-receive
-- 
main Koha release repository