[koha-commits] main Koha release repository branch master updated. v17.11.00-173-g11b562e

Thu Dec 21 15:29:34 CET 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  11b562e0d1dbca1243e7ab9305741360b2114db6 (commit)
       via  e2d88cfb28d54fe0e6f5714d5bcd3746076cffa5 (commit)
       via  54f7db91435498bcb6f846c2ec789d0abfa21b30 (commit)
       via  7f1c847aba818b1093a21e67ce4e350b861d013c (commit)
       via  2cd52f68cbe9de9c26871fc19d4ce1bf34488c7b (commit)
       via  12882d824ec5e7eab61c67afff4b43dfdde6f9fe (commit)
      from  47d8320deaabe420d0a13f4a4403ae650f5b6c74 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 11b562e0d1dbca1243e7ab9305741360b2114db6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 19 16:52:03 2017 -0300

    Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is made

    Caused by
      commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6
        Bug 15839: Koha::Reviews - Remove savereview

    the datereviewed=now() part of the query has not been translated.

    Test plan:
    Add a review from the OPAC
    Confirm that the reviews.datereviewd has been correctly set. Without
    this patch it is set to NULL.

    I have no idea how we could update existing data :-/

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e2d88cfb28d54fe0e6f5714d5bcd3746076cffa5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 19 16:28:00 2017 -0300

    Bug 19808: Do not display 'Added' alone

    It seems that reviews.datereviewed ends with NULL in DB.
    It is caused by another issue that will be fixed on another bug report.

    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 54f7db91435498bcb6f846c2ec789d0abfa21b30
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 18 13:32:19 2017 -0300

    Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl

    Test plan:
    - Create reviews
    - Delete some reviewers
    - Go to Home › Tools › Comments › Comments awaiting moderation

    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7f1c847aba818b1093a21e67ce4e350b861d013c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 18 13:32:14 2017 -0300

    Bug 19808: Handle deleted reviewers gracefully - opac-showreview

    Test plan:
    - Create reviews
    - Delete some reviewers
    - Enable OpacShowRecentComments
    - Go to opac/opac-showreviews.pl
    - Go to opac-showreviews.pl?format=rss

    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 2cd52f68cbe9de9c26871fc19d4ce1bf34488c7b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 18 13:32:02 2017 -0300

    Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail

    Make the tests easier to read

    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 12882d824ec5e7eab61c67afff4b43dfdde6f9fe
Author: Victor Grousset <victor.grousset at biblibre.com>
Date:   Fri Dec 15 15:22:24 2017 +0100

    Bug 19808: Handle deleted reviewers gracefully - opac-detail

    And other display issues when the patron was NULL.
    Which allows to keep the review even if it has no patron.
    Because it might be useful.

    For example when disconnected, the borrowernumber is null. So the
    comments from deleted patrons were displayed as if the disconnected
    user wrote them. So it had the edit button...

    And fix borrowernumber not being passed to the template when
    OpacStarRatings was false.

    Test plan
    1. Log in as a patron
    2. Leave a comment/review on a record
    3. Librarian: approve this comment
    4. Delete the borrower
    5. See the record (opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
    6. Then you should see an error
    7. Apply this patch
    8. Refresh the page
    9. Then you should see the record page with the comment

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |   20 +++++++++-------
 .../bootstrap/en/modules/opac-showreviews.tt       |    8 +++++--
 opac/opac-detail.pl                                |   22 ++++++++---------
 opac/opac-review.pl                                |    1 +
 opac/opac-showreviews.pl                           |   25 +++++++++++---------
 reviews/reviewswaiting.pl                          |   17 +++++++------
 6 files changed, 52 insertions(+), 41 deletions(-)

hooks/post-receive
-- 
main Koha release repository