[koha-commits] main Koha release repository branch master updated. v17.11.00-195-gb4d3b25
Git repo owner
gitmaster at git.koha-community.org
Thu Dec 21 17:28:33 CET 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via b4d3b25bc21adfc768d18756b0973ddf37d69efa (commit)
via 0ec74621ca2f105c33b85645d6855918efbc28a7 (commit)
via 367f6ef536fd67288eca8a0897499badf292be34 (commit)
via 730e1273801057781ea4577844bb80ab1b5c117c (commit)
via df7fbba8284349e404acf484e029093f0c6cb73f (commit)
via ebc1583f09e2c6cae9fe48f4476bc3ba4fd725fd (commit)
via 8b98a82572ae5667309c1d33c5994b2d42f36081 (commit)
via c1ea09f851626784d1c7b33c65ea3b78d6656556 (commit)
via 136c49a940a632e9bcfb50694871b1a9ba2480c1 (commit)
via c867cadeef6a324d1861514f3f21979881d04e18 (commit)
via 9aa724cdf29a57bc91e42b240b5bcd19e3814ada (commit)
via cf57457d34eed3a5fe3aff86ad5fbc9c1147cd81 (commit)
via 3d720e9ede3da4cb612d1517c776d5636e12452e (commit)
via b3d26c4e96e195308607960e03d309a9cf2d4065 (commit)
via b11597b16acdb76b2801c371c9a5df76d97824b9 (commit)
via 79c2848b142ed64336ccecd675d9cb2a38795900 (commit)
via f07f69ae21d5ac78ea662b9a473de59ef6d12ac0 (commit)
via 69f6b24a80ed6156ca13f48606f9941b260fcd80 (commit)
via c269a0148661a2f39e75688eeaf9be48f0926cf6 (commit)
via 325fddd8e911a7efe1342d61f21803d24f785dec (commit)
via 7140a5e4ecc68759c1bee04571386f9cc9a16d92 (commit)
via 92dd9082b8de2f45b468e4b73bd5f3efda344f4f (commit)
from 11b562e0d1dbca1243e7ab9305741360b2114db6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b4d3b25bc21adfc768d18756b0973ddf37d69efa
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 21 12:42:03 2017 -0300
Bug 19429: Rename .delete to .delete_invoice
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0ec74621ca2f105c33b85645d6855918efbc28a7
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Oct 3 02:47:40 2017 +0000
Bug 19401: Add confirm message when deleting invoice
To test:
1) Go to Acquisitions
2) Go to Invoices (left nav menu)
3) Click Search (no need to filter results)
4) Click dropdown menu for an invoice, click Details
5) Click Delete
6) Notice invoice is deleted instantly
7) Apply patch and repeat steps 4 and 5
8) Confirm the confirm message shows and works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 367f6ef536fd67288eca8a0897499badf292be34
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Oct 10 02:17:36 2017 +0000
Bug 19429: Add confirm message when deleting invoice from invoice search page
To test:
To test:
1) Go to Acquisitions
2) Go to Invoices (left nav menu)
3) Click Search (no need to filter results)
4) Click dropdown menu for an invoice, click Delete
5) Notice invoice is deleted instantly
6) Apply patch and repeat steps 3 and 4
7) Confirm the confirm message shows and works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 730e1273801057781ea4577844bb80ab1b5c117c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 21 12:37:38 2017 -0300
Bug 18201: Tidy tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit df7fbba8284349e404acf484e029093f0c6cb73f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 20 18:59:39 2017 -0300
Bug 19756: Fix encoding issues during the update DB process
To display the output of the updatedatabase.pl under Plack, we redirect
the output to a temporary file, read it, then display it.
We need to open it specifying the correct encoding (utf-8).
Test plan:
1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000"
where variable="version";
2. restart plack
3. Login
4. Make the update from the interface
=> Without this patch you will see encoding issue:
Upgrade to 17.12.00.000 done (TÄ“ tÅia, tÄ“ haumatia)
=> With this patch applied you will see :
Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia)
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ebc1583f09e2c6cae9fe48f4476bc3ba4fd725fd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 9 15:54:12 2017 +0000
Bug 19573: Link to make a new list in masthead in OPAC only appears / works if no other list already exists
This patch corrects the OPAC masthead include file so that the "New
list" link will appear whether or not the logged-in user has existing
private lists.
To test, apply the patch and log into the OPAC as both a user with
private lists and a user without private lists. The header's "Lists"
dropdown menu should include a "New list" link in both cases.
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8b98a82572ae5667309c1d33c5994b2d42f36081
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 21 12:57:11 2017 -0300
Bug 11976: Fix sorting issues
The last column must be sortable, and dates must use title-string
I removed the class on the th (did not seem useful as we have an id
already)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c1ea09f851626784d1c7b33c65ea3b78d6656556
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Oct 26 11:41:34 2017 -0400
Bug 11976: Add Publication date to subscription table (opac) + column settings
This patch adds the column settings feature to the subscription list at
the OPAC.
It also adds a new column (Publication date) to this table
Using Home->Administration->Column Settings->OPAC->subscriptionst
the fields visibility can be toggled.
TEST PLAN
---------
1) Have a subscription where you have received at least once.
2) Look for it in OPAC and note the date is the received date, not the publication date
3) Apply patch
4) Log in to staff client
5) Home->Administration->Column Settings->OPAC->subscriptionst
6) Set visibility as desired.
7) Refresh OPAC page
-- everything should be as expected.
8) run koha qa test tools.
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 136c49a940a632e9bcfb50694871b1a9ba2480c1
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Dec 1 15:21:56 2017 +0000
Bug 19725: OAI-PMH - Use biblio_metadata.timestamp
Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
Filtering should be based on biblio_metadata.timestamp instead.
Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it SUCCEEDS
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c867cadeef6a324d1861514f3f21979881d04e18
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Dec 1 15:18:04 2017 +0000
Bug 19725: Add failing test
Also fix tests for UNIMARC
Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it FAILS
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9aa724cdf29a57bc91e42b240b5bcd19e3814ada
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Nov 9 10:34:08 2017 -0300
Bug 19599: Speed anonymise_issue_history up
The query generated by anonymise_issue_history is unecessary complex and
can be very slow on large DB.
With this patch we will execute one query per patron instead.
See patch "Bug 19599: Simplify the query" on the bug report for an
alternative.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cf57457d34eed3a5fe3aff86ad5fbc9c1147cd81
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 18 14:27:52 2017 -0300
Bug 19830: Add the Koha::Patron->old_checkouts method
Test plan:
prove t/db_dependent/Koha/Patrons.t
must return green
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3d720e9ede3da4cb612d1517c776d5636e12452e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 19 15:04:13 2017 -0300
Bug 19694: Force scalar context for output_pref called with billingdate
If no string is passed to output_pref, it needs to be called in scalar
context (to avoid a shift in the hash elements).
Here we have billingdate that is not defined yet (NULL)
Test plan:
- Search for an existing invoice
- Show details
- Changing shipping cost
- Save
- Verify the new amount is shown
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b3d26c4e96e195308607960e03d309a9cf2d4065
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Oct 4 12:10:13 2017 +0000
Bug 18201: Unit tests
To test:
1. prove -v t/db_dependent/Exporter/Record.t
2. Tests should pass/be green/make the day a little brighter
Signed-off-by: Scott Kehoe <scott at masslibsystem.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b11597b16acdb76b2801c371c9a5df76d97824b9
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Apr 13 10:21:50 2017 -0400
Bug 18201: Export data -Fix "Remove non-local items" option and add "Removes non-local records" option for existing functionality
It turns out the modules had the option expected built in, we just didn't call
it. This patch set expands the options for passing to the export.
To test:
1 - Go to Tools->Export data
2 - Perform an export and check 'Remove non-local items'
3 - Note that file contains only 'local' records, but includes all items
on those records
4 - Apply patch
5 - Note Tools->Export data has a new option to remove records not owned
by logged in branch
6 - Export as before checking records option, file should be as before
7 - Now check 'Remove items not owned by logged in branch'
8 - File should now only have local items (may have empty records)
9 - Check both boxes and recieve only 'local' records and items
Signed-off-by: Scott Kehoe <scott at masslibsystem.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 79c2848b142ed64336ccecd675d9cb2a38795900
Author: Srdjan <srdjan at catalyst.net.nz>
Date: Thu Oct 12 13:45:43 2017 +1300
Bug 19450: Fixed WebService::ILS bug upstream (0.17)
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f07f69ae21d5ac78ea662b9a473de59ef6d12ac0
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue Nov 7 03:25:52 2017 +0000
Bug 17770: Perltidy
Signed-off-by: Your Full Name <your_email>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 69f6b24a80ed6156ca13f48606f9941b260fcd80
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue Nov 7 03:21:36 2017 +0000
Bug 17770: Improve perlcritic level
before patch: perlcritic -4 noisy
after patch: perlcritic -4 ok
Signed-off-by: Your Full Name <your_email>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c269a0148661a2f39e75688eeaf9be48f0926cf6
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Nov 6 19:49:27 2017 +0000
Bug 17770: Fix Sitemapper.t if date changes during test run
To compensate, DateTime->now is mocked to the current date.
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 325fddd8e911a7efe1342d61f21803d24f785dec
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 20 12:32:34 2017 -0300
Bug 19845: Do not generate a password if one is filled on selfreg
Bug 15343 allows patrons to choose their own passwords during self-registration.
But this does not work if the PatronSelfRegistrationVerifyByEmail preference is
set to "Require." If e-mail verification is required, whatever password the patron
supplied in the form is ignored, and they are given a randomly generated password
once they click on the verification link.
Test plan:
1. Make sure there is a valid e-mail stored in the KohaAdminEmailAddress preference.
2. Set PatronSelfRegistration to Allow.
3. Set PatronSelfRegistrationVerifyByEmail to Require.
3. Be sure "password" is listed in PatronSelfRegistrationBorrowerMandatoryField and
NOT listed in PatronSelfRegistrationBorrowerUnwantedField.
4. Be sure there is a valid patron category in PatronSelfRegistrationDefaultCategory.
5. Set PatronSelfRegistrationPrefillForm to "Display and prefill" so that you can see
the generated password.
Then fill out the self-registration form, include a valid e-mail address, and select
a password. Wait for the verification e-mail. Click on the link and you'll see that
the password you entered in the form is used.
Signed-off-by: Arturo <alongoria at sll.texas.gov>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7140a5e4ecc68759c1bee04571386f9cc9a16d92
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Dec 21 09:17:01 2017 -0500
Bug 19669: (QA follow-up) Remove itemstypes.plugin
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 92dd9082b8de2f45b468e4b73bd5f3efda344f4f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Nov 21 13:56:31 2017 +0000
Bug 19669: Remove deprecated checkouts by patron category report
Patch applies. Reports and general OPAC and staff client functionality is intact.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Installer/PerlDependencies.pm | 2 +-
Koha/Exporter/Record.pm | 7 +-
Koha/OAI/Server/ListBase.pm | 6 +-
Koha/Patron.pm | 18 +-
Koha/Patrons.pm | 13 +-
acqui/invoice.pl | 4 +-
admin/columns_settings.yml | 11 +
installer/install.pl | 4 +-
.../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 5 +-
.../prog/en/modules/acqui/invoices.tt | 6 +-
.../modules/reports/issues_by_borrower_category.tt | 92 ---------
.../intranet-tmpl/prog/en/modules/tools/export.tt | 6 +-
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 34 ++-
opac/opac-memberentry.pl | 2 +-
reports/issues_by_borrower_category.plugin | 218 --------------------
reports/itemtypes.plugin | 109 ----------
t/db_dependent/Exporter/Record.t | 75 ++++++-
t/db_dependent/Koha/Patrons.t | 26 ++-
t/db_dependent/OAI/Server.t | 62 +++---
t/db_dependent/Sitemapper.t | 86 ++++----
tools/export.pl | 8 +-
22 files changed, 270 insertions(+), 526 deletions(-)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_by_borrower_category.tt
delete mode 100755 reports/issues_by_borrower_category.plugin
delete mode 100755 reports/itemtypes.plugin
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list