[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.04-23-g6fe90c2

Git repo owner gitmaster at git.koha-community.org
Fri Apr 6 19:48:31 CEST 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  6fe90c2228ab6116f1d30d811aad2a6eb342153a (commit)
       via  4aaf30dfd87289a63e27073be90062db04a32dc1 (commit)
       via  93c5c8e4c85ed3330184de2c6ea06ab73803656b (commit)
       via  7c55ea5917998bc210d3ee632f0a8ea6beefff5f (commit)
       via  37750b2f20f63bec2de330533bb4d9a82171e9c1 (commit)
       via  3db7e1a63a517ad03a5426504ef4010beae0c8bf (commit)
       via  a1940ace4187e5f94bac82830a92481e85e9c6d0 (commit)
       via  5de7dc040dbb1e6ebae49a64aac8f4a7c19d4091 (commit)
       via  72de4ddaeed5e12a86414e6b965cb6f5a4a76ce1 (commit)
       via  362c0e0cd1035222ee43febae88cab73c410f41e (commit)
       via  900f3437622c3d3df4fc8cf782161c9b9eea844f (commit)
       via  46cb6e98ba88843422274f475711356ff4b13866 (commit)
       via  6dff4fc2bd1b4d4758a0950f52636ea6aca7a525 (commit)
       via  9ebf5074b696fa532234393187fd071785ec298d (commit)
       via  a7ac0b817d9a1f180e5aa93b5fb7c0284d169e45 (commit)
       via  81c1f80f11316e337c512b12a6b66cfba9a3b54d (commit)
       via  a3f8f90804f7989e27d180c76fe65cd86ad4adde (commit)
       via  8f5446e389249383281ee57aaa6a46ca80cdfac2 (commit)
       via  b569804b7ff8d987a05302b565843307edc9f5c9 (commit)
       via  db9f768ea4f312466f6d05e485350bf47002a0b4 (commit)
       via  71aeda12a86ab16b7212766e083c159387991d37 (commit)
       via  00e64a0cb16a6bbff764c9e4dd99129f9a4a9c0e (commit)
       via  4dfdf061badfa40954022653326c3166448ae5bf (commit)
      from  d0a0390b9d5739d582dd98165f321c49e08a02a4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6fe90c2228ab6116f1d30d811aad2a6eb342153a
Author: Victor Grousset <victor.grousset at biblibre.com>
Date:   Fri Jan 5 15:03:38 2018 +0100

    Bug 19953: Record page: acquisition details: add column for invoice
    
    Test plan:
    1. create a vendor with minimal info
    2. create a basket with minimal info
    3. add a item to the basket
    4. close the basket
    5. receive a shipment
    6. on the "receipt summary" click on "receive" for the wanted item (it
       should be the only one)
    7. items → receive? → tick this checkbox
    8. save
    9. click on "finish receiving"
    10. go to the record → Acquisition details
    11. apply this patch
    12. refresh the page
    13. you should see the new column
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4aaf30dfd87289a63e27073be90062db04a32dc1
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Mar 9 06:58:34 2018 +0000

    Bug 12812: (Follow-up) Fix use of C4::Circulation
    
    Fixes this error:
    Undefined subroutine &main::MarkIssueReturned called at
    misc/cronjobs/longoverdue.pl line 316.
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 93c5c8e4c85ed3330184de2c6ea06ab73803656b
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Thu Feb 8 06:39:39 2018 -0500

    Bug 12812: Longoverdue.pl --mark-returned doesn't return items
    
    The longoverdue.pl option --mark-returned doesn't work unless the
    --charge option is used as well.
    
    Test Plan:
    1) Run long overdue with --mark-returned and not --charge,
       note your items are marked lost but not returned
    2) Apply this patch
    3) Repeat step 1, the items should now get returned!
    
    Tested with (for example):
    misc/cronjobs/longoverdue.pl --lost 10=1 --mark-returned --verbose
    --confirm
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7c55ea5917998bc210d3ee632f0a8ea6beefff5f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Mar 5 11:30:15 2018 +0100

    Bug 17717: (QA follow-up) Fix typo chdir
    
    This test does obviously not achieve the desired result:
        [ "chdir" != "no" ]
    Trivial fix.
    Adding the same quotes around starting_dir (just as for Bug 19546).
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 37750b2f20f63bec2de330533bb4d9a82171e9c1
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Fri Mar 2 11:51:20 2018 -0300

    Bug 17717: Make cronjobs using koha-foreach use --chdir
    
    In order to patch production sites we need to adjust the shipped
    cronjobs so they are called with the --chdir option switch.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3db7e1a63a517ad03a5426504ef4010beae0c8bf
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Fri Mar 2 11:17:40 2018 -0300

    Bug 17717: Add a --chdir option switch for koha-foreach
    
    Until Perl 5.26, the current directory is added to @INC when running a
    Perl script [1]. Having the current directory in @INC means it can be
    tried to be traversed when performing a lib lookup. Since version 5.18,
    Perl dies when it finds an unreadable directory (permissions) in @INC
    that needs to be traversed. This behaviour won't change because Perl
    devs consider it an enhancement to security. [2]
    
    Because of this, we need to make sure our scripts are ran **from** a
    directory in which they have read permissions.
    
    Ths patch adds a --chdir option switch to the **koha-foreach** wrapper
    script, that makes the inner shells/scripts to be ran within the Koha
    instance's user home directory.
    
    The change is trivial and should be QAed easily. I tested this on a prod
    server:
    
    - Create a /tmp/test.pl file containing:
    
    use Modern::Perl;
    
    use Cwd;
    my $dir = getcwd;
    
    warn $dir;
    
    1;
    
    A) then create a cronjob entry to run it using koha-foreach:
    (in /etc/cron.d/test):
    1/* * * * * root koha-foreach perl /tmp/test.pl
    - Once I noticed the cronjob ran, I used mutt to read the emails in the
    root user.
    => FAIL:
    ...
    Subject: Cron <root at koha> koha-foreach --enabled perl /tmp/test.pl
    
    "/root"
    "/root"
    "/root"
    "/root"
    "/root"
    ...
    
    B) I then used the patched koha-foreach with different results:
    => SUCCESS:
    ...
    Subject: Cron <root at koha> /root/koha-foreach --chdir --enabled perl /tmp/test.pl
    
    "/var/lib/koha/acaderc"
    "/var/lib/koha/agro"
    "/var/lib/koha/anc"
    "/var/lib/koha/arico"
    "/var/lib/koha/artes"
    ...
    
    So this patch's approach works. But...
    
    C) master's koha-foreach seems to work just the same... I think it is
    because of my previous attempt to fix this by using sudo in koha-shell.
    So I think environmental conditions affect the behaviour (which shell is
    configured for cron, sudo configuration, etc).
    
    ====
    
    In conclusion, I think we should go ahead with this patch as it will solve
    peoples issues, and it is a right solution (option #5 on the list) to
    this Perl behaviour change. It doesn't cover other commands, but
    followup patches could do.
    
    I avoided /tmp as it is writable by any user... so it is an easy path
    for both exploiting by replacing some lib, and also because the
    existence of an unreadable dir that the interpreter could try to
    traverse (unreadable /tmp/Authen or /tmp/Koha will trigger the same
    error, and I assume people know what they are putting on the instance's
    dir, at least it will be easier to track).
    
    A followup patch takes care of making the cronjobs use --chdir when
    calling koha-foreach
    
    [1] https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html
    [2] https://rt.perl.org/Public/Bug/Display.html?id=123795
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a1940ace4187e5f94bac82830a92481e85e9c6d0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Feb 27 15:30:18 2018 -0300

    Bug 20286: Fix filter for BakerTaylor* prefs
    
    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5de7dc040dbb1e6ebae49a64aac8f4a7c19d4091
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Feb 26 10:48:18 2018 -0300

    Bug 20286: Correctly escape URI characters in OPAC RSS template
    
    Bug 19568 use the TT filter url whereas it must have escaped the URI
    characters with the uri filter.
    
    Test plan:
    Subscribe to an OPAC search
    => Without this patch you will get an empty page
    => With this patch applied you will see result list.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 72de4ddaeed5e12a86414e6b965cb6f5a4a76ce1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Feb 28 13:54:32 2018 -0300

    Bug 20311: Prevent get_age tests to fail on Feb 28th
    
    Today Feb 28th 2018:
    If we subtract 18y to this DateTime object 29/02/2000 and so the patron is not major yet
    
    use Koha::DateUtils qw( dt_from_string );
    say dt_from_string('28/02/2018')->add(years => -18);
    say dt_from_string('28/02/2018')->add(years => -18, end_of_month => 'limit');
    
    will display:
    2000-02-29T00:00:00
    2000-02-28T00:00:00
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 362c0e0cd1035222ee43febae88cab73c410f41e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Sat Feb 17 11:50:16 2018 -0300

    Bug 20234: Update service description in koha-common.init
    
    The service description is very old and outdated. This patch fixes this.
    
    Sponsored-by: Orex Digital
    
    Signed-off-by: Hugo Agud hagud at orex.es
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 900f3437622c3d3df4fc8cf782161c9b9eea844f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Sat Feb 17 11:34:58 2018 -0300

    Bug 20234: Make maintenance scripts use koha-zebra instead of koha-*-zebra
    
    This patch makes all maintenance scripts use **koha-zebra** instead of
    the old **koha-*-zebra** scripts.
    
    To test:
    - Run:
      $ perl misc4dev/cp_debian_files.pl
      $ sudo service koha-common stop
    => SUCCESS: No errors and the Zebra-related sevices are stopped
      $ sudo service koha-common start
    => SUCCESS: No errors and the Zebra-related services are started
      $ sudo service koha-common restart
    => SUCCESS: No erros and Zebra-related services are running
      $ sudo koha-create --create-db test
    => SUCCESS: Instance created and zebra running for it
      $ sudo koha-disable test
    => SUCCESS: No errors and Zebra is stopped for instance test
      $ sudo koha-zebra --start test
      $ sudo koha-remove test
    => SUCCESS: No errors, instance removed, no Zebra running for test
    - Sign off :-D
    
    Sponsored-by: Orex Digital
    
    Signed-off-by:  Hugo Agud hagud at orex.es
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 46cb6e98ba88843422274f475711356ff4b13866
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Tue Feb 27 12:59:56 2018 +0200

    Bug 20302: Allow translating Delete button in Patron batch mod tool
    
    There is an untranslatable Delete-button in the patron batch modification
    tool. Allow translating it.
    
    Test plan:
    
    1) Go to Home -> Tools -> Batch patron modification, put a patron's
       card number in the box, and click on Continue
    2) At the bottom of the screen there is an drop-down entry for
       Attribute, click on the "New" at the nd of that line
    3) There should now be another Attribute -line, with "Delete" -link
       at the end of that line
    4) Apply patch, install a language
    5) Repeat 1-3 in that language, the Delete-link should be shown in
       the correct language, if the msgid "Delete" was translated
       in xx-YY-staff-prog.po
    
    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Conflicts:
    	koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt

commit 6dff4fc2bd1b4d4758a0950f52636ea6aca7a525
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Tue Feb 27 09:10:17 2018 +0200

    Bug 20301: Allow translating "View" in manage MARC import
    
    When looking at the table showing the staged MARC records, the "View"
    text in the Diff-column is not translatable. Make it so.
    
    Test plan:
    
    1) Go to Home -> Tools -> Stage MARC records for import
    2) Select eg. t/db_dependent/www/data/marc21record.mrc and upload the file
    3) Click on Stage for import
       -> Manage staged records
       -> Import this batch into the catalog
    4) Wait for zebra to reindex, or trigger it yourself by
       running rebuild_zebra.pl -a -b -r
    5) Go to Home -> Tools -> Stage MARC records for import
    6) Select the same file as in part 2 and upload the file
    7) Change the Record matching rule to ISBN (020$a)
    8) Click on Stage for import
       -> Manage staged records
    9) In the table below, there should now be a line showing
       the staged MARC record matches biblio
    10) Note the "View"-text in the "Diff"-column
    11) Apply patch
    12) Install a language, view the same batch in the
        Manage staged MARC records -page in that language
    13) The "View" should show up correctly, and if the
        msgid "View" was translated in the xx-YY-staff-prog.po,
        should show up in the correct language
    
    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Conflicts:
    	koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt

commit 9ebf5074b696fa532234393187fd071785ec298d
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Tue Feb 6 12:19:17 2018 +0200

    Bug 20141: Untranslatable string in transport cost matrix
    
    Make the "Disable" checkboxes in transport cost matrix translatable
    
    Test plan:
    
    1) Go to Home -> Administration -> Transport cost matrix
    2) Click on any cell
    3) Note the "Disable" checkbox text
    4) Install patch, add a language, translate the text, etc
    5) Repeat 1-3, the "Disable" text should now be translated
    
    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Conflicts:
    	koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt

commit a7ac0b817d9a1f180e5aa93b5fb7c0284d169e45
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Mon Feb 26 12:08:27 2018 +0200

    Bug 20296: Untranslatable "All" in patrons table filter
    
    There's an untranslatable "All" in the "Show X entries" filter
    when browsing the patrons.
    
    Test plan:
    
    1) Home --> Patrons --> Browse by last name.
    2) In the table filtering toolbar, there's a dropdown with
       "Show [20] entries" and the last in the dropdown is "All".
    3) Update and install a language, check that msgid "All" is
       translated and isn't fuzzy.
    4) Check the "All" in the dropdown, it is not translated.
    5) Install patch, repeat 1-3, and check the "All" in the dropdown,
       it should now be translated.
    
    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Conflicts:
    	koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt

commit 81c1f80f11316e337c512b12a6b66cfba9a3b54d
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Mon Feb 26 11:10:10 2018 +0200

    Bug 20295: Allow translating link title in ILL module
    
    Allow translating "View borrower details" link title in the ILL module.
    
    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a3f8f90804f7989e27d180c76fe65cd86ad4adde
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Feb 20 21:42:13 2018 +0000

    Bug 20290: Fix capitalization of "Routling List"
    
    This fixes some strings to be properly capitalized.
    
    To test:
    - Create a new routing list, check title and breadcrumbs
    - View the routing list tab in the patron account in staff,
      check title and breadcrumbs
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8f5446e389249383281ee57aaa6a46ca80cdfac2
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Tue Feb 6 13:01:36 2018 +0200

    Bug 20142: Allow translating offline circ message
    
    Allow translating the notification saying you cannot change branch or
    logout while offline.
    
    Test plan:
    
    1) Enable AllowOfflineCirculation
    2) Go to Home -> Circulation -> Built-in offline circulation interface
    3) Try to change your branch. Note the notification message
    4) Apply patch, install language, translate the notification
    5) Repeat 2 and 3 in that language. The message should be translated
    
    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Conflicts:
    	koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt

commit b569804b7ff8d987a05302b565843307edc9f5c9
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Tue Feb 6 14:17:45 2018 +0200

    Bug 20147: Allow translating prompt in label edit batch
    
    Fix one untranslatable prompt in the label batch edit.
    
    Test plan:
    
    1) Go to Home -> Tools -> Label creator
    2) Click on New -> Label batch
    3) Add items to the batch
    4) Select any of the items
    5) Click on "Remove selected items"
    6) Note the popup text
    7) Apply patch, update a language, translate the msgid
       "Are you sure you want to remove label number(s): %s from this batch?"
    8) Repeat 1-6. The popup text should now be translated.
    
    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit db9f768ea4f312466f6d05e485350bf47002a0b4
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 6 15:40:56 2018 +0000

    Bug 20140: Allow translating more of OAI sets
    
    Allow translating two strings in the OAI set config:
    "setDescription" and "Remove"
    
    Test plan:
    
    1) Go to Home -> Administrator -> OAI sets config -> Add a new OAI set
    2) Click on "New set"
    3) Click on "Add description"
    4) Note the "setDescription:" and "Remove" -texts
    5) Install patch, update language, translate the new strings
    6) Redo 1-4, note how the strings in part 4 are now translated
    
    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
    Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 71aeda12a86ab16b7212766e083c159387991d37
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Feb 21 17:40:06 2018 +0000

    Bug 20240: Remove space before : when searching for a vendor in serials (Vendor name :)
    
    This patch removes the space before the colon in the "vendor" label in
    the vendor search pop-up window.
    
    To test, apply the patch and go to Serials -> New subscription.
    
    - Click the "Search for a vendor" link next to the vendor form field.
    - In the pop-up window, confirm that there is no space before the colon
      in the "vendor" label.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 00e64a0cb16a6bbff764c9e4dd99129f9a4a9c0e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Feb 21 17:59:49 2018 +0000

    Bug 20239: Fix spelling on authority linker plugin
    
    This patch corrects the capitalization of the "Choose" link in the
    pop-up window for selecting an authority record to link to a MARC field.
    
    This patch also converts the link, and the "Edit authority" link, to
    Bootstrap buttons.
    
    To test:
    - Create a new record
    - Go to the 100 field
    - Click on plugin link behind $a
    - Look for an existing authoriy in your system
    - In the table of search results, confirm that the "Choose" and "Edit
      authority" links look correct and work correctly.
    
    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4dfdf061badfa40954022653326c3166448ae5bf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Feb 16 12:23:26 2018 -0300

    Bug 20229: Explicitly list the SQL modes we support
    
    In our installation procedure we ask the administrator to edit the
    MySQL|MariaDB configuration file to specify the SQL modes we support
    (see bug 17258 comment 6 and 7 for more information).
    
    We are on the way to catch and fix all these issues and support these
    stricter modes (as they highlight problem in our codebase/DB structure)
    but in the meanwhile it may be good to remove this step and revert the
    changes when we are ready.
    
    TODO:
    - Remove that for dev installations (to let developers catch these bugs)
    - Edit the wiki page to remove this step
    
    Test plan:
    0. Do not apply this patch
    1. Edit your MySQL|MariaDB config and add:
    sql-mode = "ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION"
    to the [mysqld] section (or edit it)
    2. Restart your DBMS
    3. Try to make the app explode (watch the logs)
    (tips: you should get "'koha_kohadev.me.id' isn't in GROUP BY" when
    editing an order)
    4. Apply the patch, restart_all, restart your DBMS
    5. Try to recreate the failure
    => You should no longer see the error in the logs
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Database.pm                                   |    4 +++-
 debian/docs/koha-foreach.xml                       |   17 ++++++++++++--
 debian/koha-common.cron.d                          |    2 +-
 debian/koha-common.cron.daily                      |   24 ++++++++++----------
 debian/koha-common.cron.hourly                     |    2 +-
 debian/koha-common.cron.monthly                    |    2 +-
 debian/koha-common.init                            |   16 +++++++------
 debian/koha-common.logrotate                       |    4 ++--
 debian/scripts/koha-create                         |    2 +-
 debian/scripts/koha-disable                        |    2 +-
 debian/scripts/koha-foreach                        |   11 +++++++++
 debian/scripts/koha-remove                         |    2 +-
 .../prog/en/modules/admin/oai_sets.tt              |    4 ++--
 .../prog/en/modules/admin/transport-cost-matrix.tt |    2 +-
 .../modules/authorities/searchresultlist-auth.tt   |   12 +++++-----
 .../prog/en/modules/catalogue/detail.tt            |   12 ++++++++++
 .../intranet-tmpl/prog/en/modules/circ/offline.tt  |    2 +-
 .../prog/en/modules/ill/ill-requests.tt            |    2 +-
 .../prog/en/modules/labels/label-edit-batch.tt     |    2 +-
 .../prog/en/modules/members/member.tt              |    2 +-
 .../prog/en/modules/members/routing-lists.tt       |    4 ++--
 .../prog/en/modules/serials/acqui-search.tt        |    2 +-
 .../prog/en/modules/serials/routing.tt             |    4 ++--
 .../prog/en/modules/tools/manage-marc-import.tt    |    2 +-
 .../prog/en/modules/tools/modborrowers.tt          |    2 +-
 .../bootstrap/en/modules/opac-opensearch.tt        |    8 +++----
 misc/cronjobs/longoverdue.pl                       |    9 ++++++--
 t/db_dependent/Koha/Patrons.t                      |   12 +++++-----
 28 files changed, 107 insertions(+), 62 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list