[koha-commits] main Koha release repository branch master updated. v17.11.00-1088-ga2cccbd
Git repo owner
gitmaster at git.koha-community.org
Fri Apr 6 20:02:04 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via a2cccbd2314ea1832dae4c1c4ba738fa5c3510d2 (commit)
via 14c702bee5362654c8779b8b4a33a0d679ee6a6e (commit)
via f50a6ece8386058a5778d46458821064412c5f01 (commit)
via 9755c34938c42411e4a7e5d897af7335eca6bc13 (commit)
via 98164dc43209af9964b84e83f2ee8f0ff7491a35 (commit)
via e8fbe51ff33760b0446339b44047229be9e9f1a8 (commit)
via 28e980a25d02ea48609d3ec2ab025034a05ecc4b (commit)
via cbb62feb036317ff47122b5da60be088330f0136 (commit)
via db348f67f36c0849b2057a598bbbcc30deebd8bc (commit)
via 0a71e1df9858d55dddbeff6b31f60426e086570c (commit)
via b711ea638afc21ed93c6b7350e0d58d11f7e962b (commit)
via a71836f07db418e5c82b5cd55882a1e4d34c732d (commit)
via aa2cb3ffbb277fbbe6c7b8f17aa04a67c1996ac2 (commit)
via 509ab2c0ee5852824d2db8aa9c44a57fde629655 (commit)
via 5d1b491a799f4ca42cbe46809811539897647f8f (commit)
via f46ead631325dc86e7ff15344095b8b845cff7f3 (commit)
via fcf2b798fd985bfb87809dcbe04eadfd409714b3 (commit)
via 69f71ca2bf3e3c6a6a07cb97f88681c86c7d11b1 (commit)
from 45b1dee67e5fd771adbb30e9cac352b8a0c6ab40 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a2cccbd2314ea1832dae4c1c4ba738fa5c3510d2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 6 14:08:40 2018 -0300
Bug 20298: (follow-up) fix labels' for attributes
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 14c702bee5362654c8779b8b4a33a0d679ee6a6e
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Thu Mar 29 07:11:40 2018 -0400
Bug 20181: (QA follow-up) Remove double check
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f50a6ece8386058a5778d46458821064412c5f01
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Tue Feb 13 14:08:25 2018 -0500
Bug 20181: Add POD for new plugin
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9755c34938c42411e4a7e5d897af7335eca6bc13
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue Feb 13 18:50:02 2018 +0000
Bug 20181: (follow-up) Ensure test runs
If EnablePlugins was 0, this test before this patch fails.
After this patch, it passes.
TEST PLAN
---------
1) Apply all but this patch
2) Run the following commands
kshell
prove t/Koha_Template_Plugin_KohaPlugins.t
-- two tests fail, if you have the conf or syspref set to 0.
3) Apply this patch
4) Repeat step 2.
-- all tests pass, including the positive and negative case checks.
5) run koha qa test tools
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 98164dc43209af9964b84e83f2ee8f0ff7491a35
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Mon Feb 12 11:15:47 2018 -0500
Bug 20181: Unit tests
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e8fbe51ff33760b0446339b44047229be9e9f1a8
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Mon Feb 12 09:09:20 2018 -0500
Bug 20181: Allow plugins to add css and javascript to OPAC
A number of Koha plugins have been written that enhance Koha's public catalog. These plugins often make due to adding css and javascript to the various opac system preferences. It would be nice if the plugin system had hooks so plugin developers could add code the the head block and the area where we include javascript in the opac template.
Test Plan:
1) Apply this patch
2) Download and install the Kitchen Sink plugin ( v2.1.12 or later )
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.12/koha-plugin-kitchen-sink-v2.1.12.kpz
3) Install the plugin
4) Restart all the things if you can ( restart_all if you are using kohadevbox )
This will ensure the plugin takes effect right away, it should be
necessary but it won't hurt anything!
5) Load the opac, notice you get an alert message and the background
for your opac is now orange ( assuming you've not customized the
opac in any way )
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 28e980a25d02ea48609d3ec2ab025034a05ecc4b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Apr 6 08:05:58 2018 +0200
Bug 18816: (QA follow-up) Fix Circulation.t
Resolve:
ok 33 - Can renew, item is marked not for loan, hold does not block
Can't use string ("1") as a HASH ref while "strict refs" in use at /usr/share/koha/devclone/C4/Items.pm line 557.
Trivial fix. Remove fourth parameter.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cbb62feb036317ff47122b5da60be088330f0136
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Apr 6 07:57:32 2018 +0200
Bug 18816: (QA follow-up) Framework parameter is not needed
$frameworkcode is not used in ModItem (no need to pass it in
ModItemFromMarc).
$dbh is not used in ModItem.
Test plan:
Run t/db_dependent/Items.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit db348f67f36c0849b2057a598bbbcc30deebd8bc
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 23 07:04:57 2018 -0400
Bug 18816: (QA follow-up) Add rarely used params to hashref, remove param
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0a71e1df9858d55dddbeff6b31f60426e086570c
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Thu Mar 22 06:43:44 2018 -0400
Bug 18816: (QA follow-up) Convert param to hashref, fix typo
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b711ea638afc21ed93c6b7350e0d58d11f7e962b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jun 16 08:27:29 2017 -0400
Bug 18816: Make CataloguingLog work in production by preventing circulation from spamming the log
The system preference CataloguingLog is not recommended for use in
production. This is do to the fact that every checkin and checkout
generates one or more log entires. This seems to be not only bad
behavior, but unnecessary and outside the needs of CataloguingLog as we
have CirculationLog.
Test Plan:
1) Log into staff client
2) Home -> Koha administration -> Global system preferences -> Logs
3) Set only CataloguingLog to 'Log', everything else to "Don't log"
4) Click 'Save all Logging preferences'
5) In MySQL, use your instance DB, and then type 'delete from action_logs;'
6) Have a person checkout and checkin anything.
7) In MySQL, 'select * from action_logs;'
-- there will be data. This is the floodiness that will be removed.
8) Apply this patch
9) Repeat steps 5-7
-- there should be no data.
10) Edit any biblio or item.
11) In MySQL, 'select * from action_logs;'
-- there should be data reflecting the changes made.
12) run koha qa test tools
NOTE: Improved clarity of test plan -- Mark Tompsett
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a71836f07db418e5c82b5cd55882a1e4d34c732d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Apr 5 13:59:18 2018 +0000
Bug 20526: Show and sort by date of request in pending discharges table
This patch adds a "date requested" column to the table of pending
discharges, and updates the DataTables configuration to sort by this
column by default.
The patch also makes some other changes:
- Table information and filtering have been added.
- The "Allow" link has been converted to a Bootstrap-styled buttong with
an icon.
To test, apply the patch and view the table of pending discharge
requests. It should be sorted by default by date requested.
- Confirm that date sorting is correct.
- Confirm that other columns still sort correctly.
- Confirm that buttons look right.
- Confirm that the table information is correct.
- Confirm that the table search form works.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit aa2cb3ffbb277fbbe6c7b8f17aa04a67c1996ac2
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Thu Apr 5 13:14:39 2018 +0200
Bug 20524: Make columns of pending discharges table sortable
Test plan:
1. Enable syspref useDischarge
2. Login to OPAC and ask for a discharge (tab on the left)
3. Login to OPAC with another borrower from another library and ask for
a discharge
4. Login to intranet, you should see a message about pending discharges,
and a link. Click on the link.
5. Confirm that the Patron column is sortable and the Allow column is
not
6. (Optional) You can apply bug 20516 and confirm that the Library
column is sortable too
Signed-off-by: Axelle Clarisse <axelle.clarisse at univ-amu.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 509ab2c0ee5852824d2db8aa9c44a57fde629655
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 23 07:28:47 2018 -0400
Bug 11512: Update syspref description
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5d1b491a799f4ca42cbe46809811539897647f8f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Oct 26 07:40:04 2017 -0400
Bug 11512: Forced holds that violate issuing rules will never be filled
Currently in Koha, if you choose to force a hold from the staff side that would contravened the current issuing rules, that hold will never be filled, as it is always skipped over by CheckReserves.
This patch disallows overrideing except for tooManyReserves which are the only overridden holds that will be trapped.
Test Plan:
1) Apply this patch
2) Attempt to override hold placement, only placements where the patron has too many holds already should be allowed
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f46ead631325dc86e7ff15344095b8b845cff7f3
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Jan 19 01:56:17 2018 +0000
Bug 19712: (follow-up) Add missing use Pod::Usage
pod2usage call failed otherwise.
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fcf2b798fd985bfb87809dcbe04eadfd409714b3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 20 19:10:44 2017 -0300
Bug 19712: Fix test mode for delete_records_via_leader.pl
Test plan:
perl misc/cronjobs/delete_records_via_leader.pl
=> Should display a warning
perl misc/cronjobs/delete_records_via_leader.pl --test
=> Should not display a warning and script should not apply changes
perl misc/cronjobs/delete_records_via_leader.pl --confirm
=> Should not display a warning and script should apply changes
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 69f71ca2bf3e3c6a6a07cb97f88681c86c7d11b1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 29 10:39:08 2018 -0300
Bug 20446: Fix Edifact quotes processing
Caused by
commit 04aea91de0f2fe1103e4021f880d135da1fd11a9
Bug 15685: (QA follow-up) Address QA issues
->find is called on Koha::Object instead of the set class (Koha::Objects)
and raises the following error:
Can't use string ("Koha::Acquisition::Basket") as a HASH ref while
"strict refs" in use at /usr/share/koha/lib/Koha/Object.pm line 275.
This patch also makes sure $basketno refers to an existing basket in DB
I cannot provide a test plan, I have no idea how this code is used.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 18 ++--
C4/Items.pm | 42 +++++----
Koha/EDI.pm | 11 +--
Koha/Template/Plugin/KohaPlugins.pm | 96 ++++++++++++++++++++
.../en/modules/admin/preferences/circulation.pref | 2 +-
.../prog/en/modules/members/discharges.tt | 22 ++++-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 6 +-
.../bootstrap/en/includes/doc-head-close.inc | 2 +
.../bootstrap/en/includes/opac-bottom.inc | 2 +
misc/cronjobs/delete_records_via_leader.pl | 11 ++-
reserve/request.pl | 2 +-
t/Koha/Plugin/Test.pm | 10 ++
t/Koha_Template_Plugin_KohaPlugins.t | 47 ++++++++++
t/db_dependent/Circulation.t | 2 +-
t/db_dependent/Items.t | 48 +++++++++-
t/db_dependent/Plugins.t | 4 +-
16 files changed, 280 insertions(+), 45 deletions(-)
create mode 100644 Koha/Template/Plugin/KohaPlugins.pm
create mode 100755 t/Koha_Template_Plugin_KohaPlugins.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list