[koha-commits] main Koha release repository branch master updated. v18.05.00-533-g10cd9ac
Git repo owner
gitmaster at git.koha-community.org
Tue Aug 21 16:05:33 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 10cd9ac4bdc430d29bc71299e5d9b5d3bc8b1489 (commit)
via 390e39f1d2392e7ae44a4c22bbea5baf896d6cd1 (commit)
via d5296743a4b4e6e6004bdb68926a3584e55435e4 (commit)
via afa51869c39e1a450314a6d13098571566cc241c (commit)
via 717cb3f893e33a1f54299abbd81a5f9bc339a225 (commit)
via a0d775b9cce90b6a029bd92eb3971383a05f55e2 (commit)
via 5e9480937ae0a4bb901330138e1760d690d5f548 (commit)
via 3289f6f5bea07e7bec13aebd3db90d4f9e52c53a (commit)
via 4d2e8d6c91f31e2aa3db97d75168560c9ace15c0 (commit)
via df06587b763de2acd2d4e1afa3da8ad1841f7577 (commit)
via 266d7b5fa844b512cf68f4b08d6c07474c2ccc42 (commit)
via f5f31679bf260d17e996fbe8e2e77f695ac7ddfc (commit)
via d1890533c8796873149338831c5de13d5b19cb9e (commit)
via 7dab4cd903f9623fb52592e65d57c93b6156d2aa (commit)
via a4ec768e3787ff3ee426949c0f03188dd4d15e82 (commit)
via d24d77d495a56e76046907ab19e9474cab28169c (commit)
via cb5bf46dc7c17446c29273f37559d29a046b11de (commit)
via cbf75d37144e4a68d241638fe1cc91454106992b (commit)
via 8eed0466381435a0426fe9c2ea75fa295d906533 (commit)
via 88d3865168a83aa7e69999ab3336b238a2ed14ff (commit)
from f130ada624a7c48bbd2e082cc77f064a793cda8b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 10cd9ac4bdc430d29bc71299e5d9b5d3bc8b1489
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 21 13:38:42 2018 +0000
Bug 21243: (follow-up) Remove extra '</div>' tag
To test:
1 - Go to Admin->Z39/SRU servers
2 - Pick a server or add one
3 - Click 'Modify' button for mappings
4 - Copy the HTML of the popup into w3c validator
https://validator.w3.org/#validate_by_input
5 - Note extra closing div
6 - Apply patch
7 - Repeat
8 - Success
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 390e39f1d2392e7ae44a4c22bbea5baf896d6cd1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Aug 17 14:19:20 2018 +0000
Bug 21243: Regression: SRU mapping popup for bibliographic records is unstyled
This patch corrects a regression caused by Bug 21151: The include file
which adds CSS to the page was removed from the template.
To test, apply the patch and go to Administration -> Z39.50/SRU servers
-> New SRU server.
- Click the "Modify" button next to "SRU Search fields mapping"
- Verify that the pop-up window is correctly styled.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d5296743a4b4e6e6004bdb68926a3584e55435e4
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Aug 8 20:28:29 2018 +0000
Bug 20994: Fix capitaization "Save to Lists"
On the OPAC result list, below each result, there is a link:
"Save to Lists".
Patch changes this to "Save to lists" following our
capitalization rules.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit afa51869c39e1a450314a6d13098571566cc241c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jul 26 15:36:24 2018 +0000
Bug 19511: Local cover images not centered in table column in staff client search results
This patch modifies the JavaScript which embeds local cover images in
staff client catalog search results. It now adds the "thumbail" class to
the image, matching Amazon cover images.
To test you should have one or more titles with local cover images
attached. Apply the patch and clear your browser cache if necessary.
Enable both the AmazonCoverImages and LocalCoverImages system
preferences and perform a search which will return titles with local
cover images. Confirm that local covers are styled like Amazon covers.
Tested and confirmed local cover images are appearing quite nicely now.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 717cb3f893e33a1f54299abbd81a5f9bc339a225
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 17 13:20:04 2018 -0300
Bug 19500: Add missing span for 'other'
To stay consistent in the DOM structure it would make sense to have it
there as well
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a0d775b9cce90b6a029bd92eb3971383a05f55e2
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Aug 12 19:42:30 2018 +0000
Bug 19500: (QA follow-up) Add spans to ease translation
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5e9480937ae0a4bb901330138e1760d690d5f548
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Aug 10 22:54:11 2018 +0000
Bug 19500: Make module names on letters overview page translatable
While the module pull down on adding and editing a letter is
written out and fully translatable, the overview page showed
the internal 'module code'.
Patch also renames the "Members" module into the "Patrons" module
to match Koha's terminology.
To test:
- Before applying the patch:
- Add or edit a notice, look at the pull down for module
- Go back to the overview page
- Verify the module names don't match
- Apply the patch:
- Check again, pull downs should now match
- Verify that Members is now Patrons everywhere
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3289f6f5bea07e7bec13aebd3db90d4f9e52c53a
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 21 11:59:17 2018 +0000
Bug 21229: (RM follow-up) regenerate staff css
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4d2e8d6c91f31e2aa3db97d75168560c9ace15c0
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Aug 15 13:14:02 2018 +0000
Bug 21229: Correct nesting and specificity for some button styles
This patch corrects some Bootstrap button-related CSS which was causing
some buttons to have the wrong color:
- Circulation -> Check out: "Add a new message" link is black
- Catalog -> Details page: "Print" button is blue
To test, apply the patch and rebuild CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear your browser cache if necessary and view the above pages to
confirm the problem is fixed.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit df06587b763de2acd2d4e1afa3da8ad1841f7577
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 21 11:49:55 2018 +0000
Bug 21144: DBRev 18.06.00.017
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 266d7b5fa844b512cf68f4b08d6c07474c2ccc42
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Aug 2 02:19:42 2018 +0200
Bug 21144: Add ROADTYPE to default authorised values categories
The ROADTYPE category was missing from the default list of
authorised value categories available.
To test:
- Verify ROADTYPE is not listed as authorised value category
- Apply patch and run database update
- Verify ROADTYPE is now listed
- Add an entry, for example: AV = Avenue
- Add or edit a patron, verify a pull down with your entry
shows on the form.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f5f31679bf260d17e996fbe8e2e77f695ac7ddfc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 17 12:07:55 2018 -0300
Bug 21142: Open uploaded files in utf-8 - batch mod/del
Batch item/record modification/deletion tools does not open uploaded
files in utf-8
Test plan:
Edit and delete records and items using a file which will contain:
valid and invalid barcodes with and without utf-8 chars (💕)
You should see the warning message:
"The *** 39999000💕001679 does not exist in the database."
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d1890533c8796873149338831c5de13d5b19cb9e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Jan 17 19:50:31 2018 +0000
Bug 20014: Preselect item budget based on id not code
To test:
1 - Have the same fund code in two budgets
2 - Have budget code defined in MarcItemFieldsToOrder
3 - Stage a file with some order items as defined above
4 - Inspect the fuinds drop down in the item, notice two lines are
marked selected
5 - Apply patch
6 - Repeat
7 - Only one field should be selected, with a preference for active
budget
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7dab4cd903f9623fb52592e65d57c93b6156d2aa
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 21 11:25:53 2018 +0000
Bug 20773: DBRev 18.06.00.016
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a4ec768e3787ff3ee426949c0f03188dd4d15e82
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed May 16 15:39:04 2018 +0200
Bug 20773: (bug 20724 follow-up) Add a simple db revision
We should correct bad data too.
This is a trivial, pragmatic approach. Instead of doing a complex
calculation with holidays etc. (as was done on 12063), we just add
MaxPickupDelay or 7 days to today probably resulting in a little bonus
time. Only for waiting holds. When the ReservesNeedReturns pref was not
Automatic, there should be no changes.
== Test plan ==
1. git checkout c585f1149770ec401f188e061211501897cec0bf~1
This the commit before bug 20724's patches.
We need that to be able to generate "corrupted data"
2. Set ReservesNeedReturns to "Automatically"
3. Place a hold on a specific item
4. The hold should have an *empty* expiration date
record page → Hold → "Expiration" column
5. Apply this patch
6. Run updatedatabase.pl
7. Refresh the page
8. The hold should have an expiration date (not empty)
9. Celebrate! 🎉🎊🥳
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Victor Grousset <victor.grousset at biblibre.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Bug 20773: (followup) Remove MySQLism
Signed-off-by: Victor Grousset <victor.grousset at biblibre.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d24d77d495a56e76046907ab19e9474cab28169c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 16 12:29:43 2018 -0300
Bug 21238: Prevent TemplateToolkit.t to fail on slow servers
It failed 3x in the last 6 runs (on node 1), we should mock
DateTime->now to prevent it to fail again.
The error is:
koha_1 | # Failed test at
t/db_dependent/Letters/TemplateToolkit.t line 724.
When comparing <<today>> replacement:
koha_1 | # 08/16/2018 14:25<br />
[...]
koha_1 | # 08/16/2018 14:24<br />
Let's mock DateTime->now to prevent it to fail again.
Test plan:
0. Do not apply this patch
1. Add "sleep(60);" at line ~715, before "# Add a second checkout"
2. Run the tests
=> Fail!
3. Apply this patch
4. Run the tests again
=> Pass!
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cb5bf46dc7c17446c29273f37559d29a046b11de
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Aug 20 14:49:53 2018 +0000
Bug 21223: (RM follow-up) Generate css
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cbf75d37144e4a68d241638fe1cc91454106992b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 14 17:26:26 2018 -0300
Bug 21223: Fix some floating values
See description of the bug for screenshots
I do not really know why we have these issues, but maybe we should
regenerate the .scss in order to catch the other problems?
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8eed0466381435a0426fe9c2ea75fa295d906533
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Dec 13 13:27:36 2017 +0000
Bug 18947: LDAP - do not assume anonymous bind if no user or password
To test:
Ideally tested on a working ldap server with bind by auth and no
anonymous bind
1 - Define an LDAP config with bind by auth
2 - Don't define user/pass
3 - Define anonymous_bind = 0
4 - Attempt bind by auth
5 - Error is something like:
LDAP search failed to return object : XXXXXXXXX: LdapErr: XXXX-XXXXXX,
comment: In order to perform this operation a successful bind must
be completed on the connection., data 0, v2580 at
/usr/share/koha/lib/C4/Auth_with_ldap.pm line 102.
6 - Define user/pass
7 - Now bind by auth should work
8 - remove user/pass
9 - Apply patch
10 - Attempt again
11 - Bind by auth shoudl succeed
prove -v t/db_dependent/Auth_with_ldap.t
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 88d3865168a83aa7e69999ab3336b238a2ed14ff
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 10 12:17:45 2018 -0300
Bug 21203: ILS-DI - Make GetRecords handle non-existent records
Caused by
commit cb336e633bf7e0cb25051a8ed8157af8486a58d7
Bug 18255: Koha::Biblio - Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem
Can't call method "biblioitem" on an undefined value at /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 212
Test plan:
- Enable ilsdi
- hit /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=X
With X an existing biblionumber and a non existing one
Both requests must succeed
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth_with_ldap.pm | 9 +++---
C4/ILSDI/Services.pm | 11 ++++---
Koha.pm | 2 +-
acqui/addorderiso2709.pl | 9 +++++-
installer/data/mysql/mandatory/auth_val_cat.sql | 3 +-
installer/data/mysql/updatedatabase.pl | 18 ++++++++++++
.../intranet-tmpl/prog/css/src/staff-global.scss | 30 +++++++++-----------
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../prog/en/modules/acqui/addorderiso2709.tt | 2 +-
.../prog/en/modules/admin/sru_modmapping.tt | 2 +-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 20 +++++++++++--
koha-tmpl/intranet-tmpl/prog/js/localcovers.js | 5 ++--
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
t/db_dependent/Auth_with_ldap.t | 25 +++++++++++++---
t/db_dependent/Letters/TemplateToolkit.t | 5 +++-
tools/batchMod.pl | 1 +
tools/batch_delete_records.pl | 1 +
tools/batch_record_modification.pl | 1 +
18 files changed, 103 insertions(+), 45 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list