[koha-commits] main Koha release repository branch master updated. v18.05.00-559-ga122a53
Git repo owner
gitmaster at git.koha-community.org
Wed Aug 22 17:09:35 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via a122a5333445299da8a01e47a65b25f733e6ce7c (commit)
via fe9c6450979b5b7fd05821dd22c523ea6d10d3cd (commit)
via 3f05bda8fd6a3a079c4042dc15f6372a2d62f451 (commit)
via a49490a2f4c67e121cd475ee5866e9bef25d134e (commit)
via 23f78a6c2a6557aac557ae65261bce0e7baced61 (commit)
via a11b1083bff404b57f3ac959489f0a2b7a94f6e1 (commit)
via 18e122a78cb7f0ac84161cd908b4e03ec6401c48 (commit)
via 3c143b52acfadc300aa649c25aae34f433a709d6 (commit)
via fd4d17ace14052662f78d38eae2084cfefa12b9d (commit)
via fc55ecbe42a413ca1df54b34ec18597f01465522 (commit)
via f4615a2f817dc08e8d89c667646bff8dcc0b1c28 (commit)
via 76141a352ed5ff8c9541c0d4b1c99e22e5339add (commit)
via 6fd1a8c11484e8c1cd771aea0c6ac98a2ab18f40 (commit)
via 9b73cc22890aadae0fa6afd9d82d5109cc47fd80 (commit)
via 9558a118dacd74b77c27f63fc41611945aeff052 (commit)
via 5892ab07118b04a8071b49c40b441df326e15f07 (commit)
via 7d47bb311827298ddc30297bbd388e8f8905db48 (commit)
via 9ccfa48f6ee8ec44d1621874383b10f68d939f34 (commit)
via 579e53de7e98f96a9a2bf558a6e859366416fd2c (commit)
via 74cc24d227835ee822707dd808382371f1a6bae8 (commit)
via a744a3e2026c52b9270ea248909f71f3744ff1a4 (commit)
via 56c50a66169f956584050a8630a71cfa7d5984cb (commit)
via 9e9c9d5aa11b1804a5a2db8159cac76fad9bf1de (commit)
via 7f498085114a6d5fb04e888a6a25870af5e0a1ea (commit)
via 3484db7187ca4ca62a617d9362b8c64c37f60cfd (commit)
via a750ebdbd994ef2a793e632eea4e35bbc7f1ec6d (commit)
from 10cd9ac4bdc430d29bc71299e5d9b5d3bc8b1489 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a122a5333445299da8a01e47a65b25f733e6ce7c
Author: Joy Nelson <joy at bywatersolutions.com>
Date: Fri Jun 22 13:48:25 2018 -0700
Bug 20984: Add 300$f to display
Adding Type of Unit (300$f) to the Opac details and staff side searches results and details display
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fe9c6450979b5b7fd05821dd22c523ea6d10d3cd
Author: Joy Nelson <joy at bywatersolutions.com>
Date: Fri Jun 22 11:56:11 2018 -0700
Bug 17625: adding subfields f and g to XSLT display
Adding 245$f and 245$g to the Results and Detail pages on OPAC and staff side
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
Signed-off-by: Cab Vinton <bibliwho at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3f05bda8fd6a3a079c4042dc15f6372a2d62f451
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 6 15:38:58 2018 -0300
Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl
It has been added by
commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb
Bug 6963: Corrects a problem when a new order is created with a duplicate barcode.
But its last call removed since:
commit eefc774e274ce8167f1063be5f9204a0d5cf5650
Bug 7178: Acquisition item creation improvement
Test plan:
git grep check_duplicate_barcode
should not return anything
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a49490a2f4c67e121cd475ee5866e9bef25d134e
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Aug 8 14:33:11 2018 +0200
Bug 20248: (QA follow-up) Remove unnecessary stuff
- Remove useless 'action' attribute in forms
- $op should never be equal to 'reset', so remove the test
- Move 'op' parameter inside <button>s to avoid having different HTML
tags for elements that have the same kind of behaviour
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 23f78a6c2a6557aac557ae65261bce0e7baced61
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Mon Feb 19 16:54:39 2018 +0200
Bug 20248: Improve Elasticsearch mappings UI and rebuild_elastic_search.pl.
Improvements:
1) Mappings UI now has button that allows one to reset the mappings.
2) Mappings UI displays the items in alphabetical order.
3) Indexing script drops and recreates the index right away, which
helps prevent ES from autocreating a bad index if someone does something
while the first batch of records is being processed.
4) Indexing script has nicer output.
To test:
1) Change mappings.yaml file
2) Reset mappings in UI in mappings.pl
3) Verify the mappings have been changed in UI
4) The field order is alphabetical
5) Rebuild script has clean output
6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a11b1083bff404b57f3ac959489f0a2b7a94f6e1
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Aug 22 13:57:02 2018 +0000
Bug 19719: DBRev 18.06.00.019
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 18e122a78cb7f0ac84161cd908b4e03ec6401c48
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Jun 20 00:16:38 2018 +0200
Bug 19719: (follow-up) Add database update to keep collection column hidden
For existing installations we want to keep the current behaviour.
This patch adds the column configuration to hide the collection
column from the details and checkouts tabs until toggled.
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3c143b52acfadc300aa649c25aae34f433a709d6
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Mar 31 10:13:57 2018 +0200
Bug 19719: (follow-up) Show description instead of code
This follow-up changes the display from collection code
to description, following the existing pattern for
location.
To test:
- Repeat test plan from first patch
- Verfiy now the collection descrption shows
- Change column setting in administration
- Verify they work as expected
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fd4d17ace14052662f78d38eae2084cfefa12b9d
Author: Jesse Maseto <jesse at bywatersolutions.com>
Date: Fri Mar 2 13:11:44 2018 +0000
Bug 19719: Add new column for collection in the patron checkouts data tables
This makes the collection visible in the checkouts table
on the details and issues tab in the patron account in staff.
TEST:
1. Check out a few items to patron.
2. View check outs on patron account in staff client.
3. Collection code is not present.
4. Apply patch
5. Notice that not Collection code is visible while viewing check outs.
Signed-off-by: Severine QUEUNE <severine.queune at bulac.fr>
Signed-off by: Maksim Sen <maksim.sen at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fc55ecbe42a413ca1df54b34ec18597f01465522
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 7 13:37:30 2018 +0000
Bug 15408: Fix tests to fail without patch
We set all the timestamps to a specified date and ensure the new budgets
don't have this date
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f4615a2f817dc08e8d89c667646bff8dcc0b1c28
Author: Baptiste Wojtkowski <baptiste.wojtkowski at biblibre.com>
Date: Fri Feb 3 15:22:36 2017 +0000
Bug 15408: Remove fund's timestamp when cloning a budget
To duplicate the budget, the function CloneBudgetHierarchy create a new budget
from the old without the parameter timestamp, so that the database generates a
new one.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Added unit tests to patch
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Modified to run properly the QA tests
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 76141a352ed5ff8c9541c0d4b1c99e22e5339add
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 7 11:14:54 2018 -0300
Bug 21150: add the biblionumber to the output
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6fd1a8c11484e8c1cd771aea0c6ac98a2ab18f40
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 3 14:59:33 2018 -0300
Bug 21150: Search for item types inconsistencies
search_for_data_inconsistencies.pl will now display errors if:
1.item-level_itypes is set to "specific item" and items.itype is not set
or not set to an item type defined in the system (itemtypes.itemtype)
2.item-level_itypes is set to "biblio record" and biblioitems.itemtype is not set
or not set to an item type defined in the system (itemtypes.itemtype)
Test plan:
Use the script and the different possible combinations to display the
errors
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9b73cc22890aadae0fa6afd9d82d5109cc47fd80
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue Jul 31 16:23:43 2018 +0000
Bug 20509: Add to script documentation
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9558a118dacd74b77c27f63fc41611945aeff052
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 27 15:35:57 2018 -0300
Bug 20509: Search for not defined authority codes
This patch adds a new check in
misc/maintenance/search_for_data_inconsistencies.pl to search for not
defined authority codes.
Test plan:
Set some auth_header.authtypecode to not defined authority codes in Koha
(UPDATE auth_header SET authtypecode="XXX" WHERE authid=42;)
Then run `misc/maintenance/search_for_data_inconsistencies.pl`
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5892ab07118b04a8071b49c40b441df326e15f07
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Jun 27 20:27:09 2018 +0000
Bug 21011: (follow-up) Fix pod, fix missing homebranch condition, change mode to executable
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7d47bb311827298ddc30297bbd388e8f8905db48
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 27 15:32:56 2018 -0300
Bug 21011: Search for items with not defined homebranch and/or holdingbranch
From bug 5789: scripts can fail if items.homebranch and/or
items.holdingbranch is not defined
This script will help people catching these migration issues.
Test plan:
Update your items table to set some homebranch or holdingbranch to NULL
Run this script
It will display the different items with not defined values in these
fields.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9ccfa48f6ee8ec44d1621874383b10f68d939f34
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Aug 8 20:34:32 2018 +0000
Bug 20631: Remove unused RemoveLostItem from C4::Accounts
RemoveLostItem was 'used' in C4::Accounts, but is not
actually used there.
Call has been removed by
commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82
Bug 15896 - Use Koha::Account::pay internally for makepayment
To test:
- Verify that the routine was actually not used!
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 579e53de7e98f96a9a2bf558a6e859366416fd2c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Aug 22 12:34:45 2018 +0000
Bug 20487: DBRev 18.06.00.018
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 74cc24d227835ee822707dd808382371f1a6bae8
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu May 31 09:02:12 2018 +0200
Bug 20487: (QA follow-up) Requested db revision
As requested in comment12, we can update these cases in a dbrev too.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Checked out item, deleted issue record, ran dbrev.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a744a3e2026c52b9270ea248909f71f3744ff1a4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Mar 28 16:25:07 2018 +0200
Bug 20487: AddReturn should clear items.onloan for unissued items
If an item is no longer issued but somehow still has a date in the onloan
column, checking it in should clear that date.
Adding a ModItem call in the NotIssued section.
Test plan:
[1] Run t/db_dependent/Circulation.t
[2] Bonus: Checkout item, delete issue from table, checkin. Verify that
items.onloan has been cleared.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 56c50a66169f956584050a8630a71cfa7d5984cb
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Aug 9 17:46:09 2018 +0000
Bug 20504: Fix lang attribute in html tag on systempreferences page
On the system preferences page the lang attribute of the
html tag is always empty.
To test:
- Go to systempreferences
- Check the html source and look at the html tag,
it should read: <html lang="">
- Apply patch
- Check the html source again: <html lang="en">
Verify the language code shown matches the currently
selected language in the staff interface
- Verify the language system preferences work correctly
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
The problem was actually that
$lang = $template->param( 'lang' );
should certainly be $lang = $input->param( 'lang' );
and, as it, it overrides the value of 'lang' passed from C4::Auth
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9e9c9d5aa11b1804a5a2db8159cac76fad9bf1de
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Aug 22 12:06:32 2018 +0000
Bug 21234: (RM follow-up) regenerate staff css
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7f498085114a6d5fb04e888a6a25870af5e0a1ea
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Aug 16 13:02:34 2018 +0000
Bug 21234: Remove our .clearfix class in favor of Bootstrap's
This patch removes the ".clearfix" declaration from staff-global.scss so
that Bootstrap's built-in clearfix class will be used.
To reproduce this issue, see Administration -> Currencies and exchange
rates. The table of currencies does not appear below the table buttons.
Apply the patch and regenerate CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear the browser cache if necessary and reload the Currencies and
exchange rates page. The table should appear in the correct position.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3484db7187ca4ca62a617d9362b8c64c37f60cfd
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Aug 20 07:04:37 2018 +0000
Bug 7996: (QA follow-up) Remove unnecessary permission check view logs template
Permission is checked in the perl file, no need to check again
in the template.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a750ebdbd994ef2a793e632eea4e35bbc7f1ec6d
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Aug 17 11:07:41 2018 +0000
Bug 7996: Correct wrong permissions for modification log
To test:
1 - Create a staff patron with catalogue,borrowers,and view_system_logs
permissions
2 - Log in using that patron
3 - Go to tools
4 - Click 'Log viewer'
5 - You get a blank page
6 - View borrower circ screen, note you do not see 'Modification log'
7 - Edit a borrower, note you do not see 'Modification log'
8 - Apply patch
9 - 'Log Viewer' should now load correctly
10 - You should see 'Modification log' tab during circ
11 - You should see 'Modification log' tab when editing patron
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Accounts.pm | 1 -
C4/Budgets.pm | 1 +
C4/Circulation.pm | 1 +
Koha.pm | 2 +-
Koha/SearchEngine/Elasticsearch/Indexer.pm | 25 +++-
acqui/check_duplicate_barcode_ajax.pl | 54 --------
admin/columns_settings.yml | 4 +
admin/preferences.pl | 4 +-
admin/searchengine/elasticsearch/mappings.pl | 17 ++-
installer/data/mysql/updatedatabase.pl | 22 +++
.../intranet-tmpl/prog/css/src/staff-global.scss | 12 --
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../prog/en/includes/checkouts-table.inc | 1 +
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +-
.../prog/en/includes/members-menu.inc | 2 +-
.../admin/searchengine/elasticsearch/mappings.tt | 23 +++-
.../prog/en/modules/circ/circulation.tt | 1 +
.../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 -
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 5 +-
.../prog/en/xslt/MARC21slim2intranetResults.xsl | 5 +-
koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 10 ++
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 5 +-
.../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 3 +-
.../maintenance/search_for_data_inconsistencies.pl | 143 ++++++++++++++++++++
misc/search_tools/rebuild_elastic_search.pl | 20 +--
svc/checkouts | 8 ++
t/db_dependent/Budgets.t | 17 ++-
t/db_dependent/Circulation.t | 12 +-
t/db_dependent/Koha_Elasticsearch_Indexer.t | 34 ++++-
29 files changed, 332 insertions(+), 106 deletions(-)
delete mode 100755 acqui/check_duplicate_barcode_ajax.pl
create mode 100755 misc/maintenance/search_for_data_inconsistencies.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list