[koha-commits] main Koha release repository branch master updated. v17.11.00-362-gf3c6284

Fri Feb 2 16:17:54 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f3c6284835769dead3e9a8b6e91a14d7620a130c (commit)
       via  b65f1f4c94731c4c35845f2a3db112ea3f5cc843 (commit)
       via  906563d1ff9dd32b53b38e9b40a316f0570637fc (commit)
       via  e6da42de894a5fde78d804208fa9d8b493dc57c8 (commit)
       via  58f7214926c62f86e7d5a42e3c38037a8e80263c (commit)
       via  9215cb7cafb95b7fa21838a7d8ddaf71999ad572 (commit)
       via  320e66b0438cc752ddc4e21d5c74c226f2e85120 (commit)
       via  11515d5f76fbc5244df6b5d3b5ff7a6d4f262445 (commit)
       via  b8ffee5f0fad17815027c5c0b85babab515c679e (commit)
       via  6f5a9c98bcc38d6481be0463747086bfcf705a70 (commit)
      from  bd2d2fd433baeca3d311c403b482c6a2000a6668 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f3c6284835769dead3e9a8b6e91a14d7620a130c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Jan 18 15:40:15 2018 +0100

    Bug 20031: CGI param in list context warn in guided_reports.pl

    Resolve warn:
    CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_shadowclone_reports_guided_reports_2epl line 794, this can lead to vulnerabilities. [NOTE: line number from older Koha version.]

    Test plan:
    Looking at this change should convince you already. Another look at this
    routine in C4/Output.pm would be bonus.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b65f1f4c94731c4c35845f2a3db112ea3f5cc843
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Dec 1 15:51:16 2017 +0000

    Bug 19730: (follow-up bug 17196) Use biblio_metadata.timestamp in export_records.pl

    Since bug 17196, biblioitems.timestamp is not always updated after a
    change in the MARC record.
    Filtering should be based on biblio_metadata.timestamp instead.

    REVISED TEST PLAN
    -----------------
    0. Do not apply patch

    1. Find a biblio record, remember the biblionumber for step 3

    2. Edit the record, modify a field (e.g. 003, 015$q) that is
       not mapped to a DB column, so biblio_metadata.timestamp will
       be modified but not biblioitems.timestamp

    3. In MySQL with the koha database selected:
       > select timestamp from biblio where biblionumber=###;
       > select timestamp from biblio_metadata where biblionumber=###;
       -- you'll need to change the ###'s based on the biblionumber
          you remembered in step 1.
       -- the two timestamps will differ.
       -- Remember the timestamp of biblio_metadata for step 4.

    4. Run this command:
       $ sudo koha-shell -c bash kohadev
       $ export DATE="YYYY-MM-DD HH:mm:SS"
       -- use the timestamp remembered in step 3.

    5. Run this command:
       $ ./misc/export_records.pl --date="$DATE"
       $ ls -la koha.mrc
       -- the file should be 0 bytes.

    6. Run this command:
       $ exit
       $ git bz apply 19730
       $ restart_all
       $ sudo koha-shell -c bash kohadev
       $ export DATE="YYYY-MM-DD HH:mm:SS"
       -- use the timestamp remembered in step 3.

    7. Run this command:
       $ ./misc/export_records.pl --date="$DATE"
       $ ls -la koha.mrc
       -- the file should be a lot more than 0 bytes.

    8. Run this command:
       $ /home/vagrant/qa-test-tools/koha-qa.pl -v 2 -c 1
       -- this should pass.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 906563d1ff9dd32b53b38e9b40a316f0570637fc
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Feb 2 12:06:00 2018 +0100

    Bug 20126: Add simple test for ModBiblioMarc

    Just to confirm that we see record length and base address in a record
    that has been passed through ModBiblioMarc.

    Test plan:
    Run the test.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e6da42de894a5fde78d804208fa9d8b493dc57c8
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Feb 2 11:32:49 2018 +0100

    Bug 20126: (follow-up bug 10455) Restore MARC field length calculation in ModBiblioMarc

    Trivial fix. Problem raised by bug 10455.

    Test plan:
    [1] Create or edit biblio record.
    [2] Save and check leader field lengths in MARC view.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 58f7214926c62f86e7d5a42e3c38037a8e80263c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jan 31 13:52:46 2018 +0100

    Bug 18198: (QA follow-up) Add tests for GetMarcNotes

    As requested by the RM, this patch adds a separate unit test
    for GetMarcNotes. We test MARC21 and UNIMARC. The NotesBlacklist pref
    is tested and also handling URLs in 5XX$u for MARC21.

    Test plan:
    Run t/Biblio/GetMarcNotes.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 9215cb7cafb95b7fa21838a7d8ddaf71999ad572
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Mar 2 12:59:37 2017 +0100

    Bug 18198: MARC21: Further improve handling of 5XX$u in GetMarcNotes

    Bug 14306 only handled field 555 in MARC21 as an URI. But a lot of other
    5XX fields have a $u subfield for URIs; actually $u is not used in any
    other way. This patch generalizes the change made for 555 and extends
    it to all 5XX $u.

    Test plan:
    [1] Run t/Biblio.t
    [2] Run t/db_dependent/Biblio.t
    [3] Edit a MARC21 record. Add a URL into 505u, 520u, 555u.
    [4] Check presentation on opac-detail (tab Title notes)
    [5] Check presentation on catalogue/detail (tab Descriptions)

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 320e66b0438cc752ddc4e21d5c74c226f2e85120
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Jan 19 19:41:35 2018 +0000

    Bug 20051: Invalid markup in staff client's header.inc

    This patch corrects markup errors in header.inc which introduced by
    Bug 19851. For id attributes on <span>s have been replaced with classes,
    eliminating an HTML validator error about duplicate ids.

    Minor unrelated change: Updated an element's id with a more descriptive
    name.

    Test plan the same as Bug 19851's:

     - Log in to the staff client and confirm that the appearance of the
       menu bar at the top of the screen looks correct at various browser
       widths.
     - Confirm that the logged-in user menu label and help link expand and
       collapse according to browser width.

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Fix for QA: Corrected ID reference in circ/offline.tt

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 11515d5f76fbc5244df6b5d3b5ff7a6d4f262445
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Dec 5 10:23:45 2017 -0500

    Bug 19750: Overdues without a fine rule add warnings to log

    When running fines.pl, any overdue items that have no corresponding circulation rule will generate the following warning:

    Use of uninitialized value $amount in numeric gt (>) at /usr/share/koha/bin/cronjobs/fines.pl line 133.

    Test Plan:
    1) Create a single circ rule
    2) Backdate a checkout so it is overdue
    3) Delete the circ rule
    4) Run fines.pl, note the warning
    5) Apply this patch
    6) Run fines.pl, note the warning is gone

    Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b8ffee5f0fad17815027c5c0b85babab515c679e
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Jan 30 14:34:10 2018 +0000

    Bug 18497: (follow-up) Chomp newlines in BLOCK

    To test:
    Run report
    Validate results page at: https://validator.w3.org/

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6f5a9c98bcc38d6481be0463747086bfcf705a70
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Jan 3 13:13:40 2018 +0000

    Bug 18497: Use report id to retrieve saved SQL instead of passing param

    This patch takes some of the code when executing report and moves it to
    a sub to be reused when downloading

    To test:
    1 - Run some very long report (see comment #1)
    2 - Try to download, erk!
    3 - Apply patch
    4 - Run report, results hould not have changed
    5 - Try to download, success!
    6 - Ensure reports work as before

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |   18 ++++--
 .../intranet-tmpl/prog/en/includes/header.inc      |   12 ++--
 .../prog/en/includes/reports-toolbar.inc           |   10 +++-
 .../intranet-tmpl/prog/en/modules/circ/offline.tt  |    2 +-
 misc/cronjobs/fines.pl                             |    2 +-
 misc/export_records.pl                             |   12 ++--
 reports/guided_reports.pl                          |   46 ++++++++-------
 t/Biblio/GetMarcNotes.t                            |   59 ++++++++++++++++++++
 t/db_dependent/Biblio/{Isbd.t => ModBiblioMarc.t}  |   38 ++++++-------
 9 files changed, 137 insertions(+), 62 deletions(-)
 create mode 100755 t/Biblio/GetMarcNotes.t
 copy t/db_dependent/Biblio/{Isbd.t => ModBiblioMarc.t} (50%)

hooks/post-receive
-- 
main Koha release repository