[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.05-40-g75d6195

Mon Nov 5 17:05:26 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  75d6195c0ef36c4da244c4e2e2341696c94642c1 (commit)
       via  02860425d9ed9229664dc1d977f1d45ce83bcb50 (commit)
       via  39efd50a5f93c7629669f448c21d81a7765d278f (commit)
       via  5bc9139097327a05f411935cec08ded322a46032 (commit)
       via  08ece37ccabb739ff2ae7f34ccd8ea2e88827e18 (commit)
       via  e68d3d988497289656bcf12b7f260cdc91cbc176 (commit)
       via  882e18500c0ace2a1df7ad7ad3e38ece865a2953 (commit)
       via  7d4756c89741958e22714730793cc200e276686f (commit)
       via  9f61b7eb9421d354d2609cefa0a6814e8a2ca478 (commit)
       via  dd2c6e4c69ef411a05170abfe92ed60668ac7532 (commit)
       via  2d9f2739e953b36d6b48096644d8967018a6f90f (commit)
      from  cbb6605d632eba95599704fc3867c11f6947d531 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 75d6195c0ef36c4da244c4e2e2341696c94642c1
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Tue Apr 17 23:59:58 2018 +0000

    Bug 20592: Return early in ModItem if nothing to update

    Two lines of code and move them earlier.
    Add a check to make sure there are changes.

    Followed the test plan, both the _BEFORE_ and after do as described.

    Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 1f0064bbddb9d00529d5eac1c096e669732eb551)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 02860425d9ed9229664dc1d977f1d45ce83bcb50
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 24 15:53:02 2018 -0300

    Bug 20592: Add tests

    NOTE: It isn't really a test, but it does trigger
          the return line which was added to ModItem.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 619eca1c7aaebf4db6ed170a3cbd14065da79c9d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 39efd50a5f93c7629669f448c21d81a7765d278f
Author: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Date:   Mon Aug 27 10:46:12 2018 -0400

    Bug 21277: fr-CA translation for notices in sample_notices.sql

    This patch adds fr-CA translations for the following sample notices:

    - ACQORDER
    - AR_CANCELED
    - AR_COMPLETED
    - AR_PENDING
    - AR_PROCESSING
    - AR_SLIP
    - CANCEL_HOLD_ON_LOST
    - CHECKOUT_NOTE
    - MEMBERSHIP_EXPIRY
    - PASSWORD_RESET

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit bbd4f5821a9818074d07ade086e7881dc1bba195)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5bc9139097327a05f411935cec08ded322a46032
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Oct 19 16:50:40 2018 +0000

    Bug 21617: DBRev 18.05.05.002

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8150058b387b39469b64853a07d512bcc0a3741d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 08ece37ccabb739ff2ae7f34ccd8ea2e88827e18
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 19 10:51:05 2018 +0200

    Bug 21617: statistics.ccode is not long enough (see also DBRev 18.05.04.001)

    Warn from a test:
    DBD::mysql::st execute failed: Data too long for column 'ccode' at row 1 [for Statement "INSERT INTO statistics
            (datetime,
             branch,          type,        value,
             other,           itemnumber,  itemtype, location,
             borrowernumber,  proccode,    ccode)
             VALUES (now(),?,?,?,?,?,?,?,?,?,?)" with ParamValues: 0="z8LIyIV", 1='issue', 2=undef, 3='', 4='2584', 5='E_QkzaV5Ay', 6='oDnFRZyog2CS2_XoUB_MB2sBxyI3elbFPC_AekxLPrduGTXKnlNoLKEdQrXzpAw5zD1pGbZshV9ydZup', 7='2000005168', 8='', 9='j9ZDn74omZAoZrTOdC4a05SpWRSHPR2apfss7y5V6QJuQnBEk32XWXCfMp7'] at C4/Stats.pm line 138.

    The dbrev 18.05.04.001 did not change it from 10 to 80 as in other tables.

    We should either truncate to 10 chars in Stats.pm or increase to varchar(80). Since it is varchar and not char, we should not be afraid about size. I choose for the latter here.

    Test plan:
    Run db rev.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ad20a30a831c5f3482f2eed80cc36269ebbef05f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e68d3d988497289656bcf12b7f260cdc91cbc176
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Oct 5 12:50:26 2018 +0000

    Bug 21497: Correctly format dates for ILL requests in OPAC

    This patch updates the opac ILL template to use the $KohaDates plugin
    for displaying dates. Also updated:

    - Added "title-string" sorting to allow for correct sorting of dates in
      the table of requests.
    - Corrected capitalization as per our capitalization rules.
    - Added self-closing / to inputs as per coding guidelines.

    To test, apply the patch and log in to the OPAC as a user who has
    multiple outstanding ILL requests.

     - In the table of ILL requests, the "Request placed" and "Last updated"
       dates should be formatted according to your system's dateformat
       preference.
     - Sorting of those columns should work correctly.
     - View a request and confirm that "Request placed" and "Last updated"
       dates in this view are also formatted correctly.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a2418f743ce1e14d32229b5dd8d05aeb13f9e664)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 882e18500c0ace2a1df7ad7ad3e38ece865a2953
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Sat Oct 13 09:17:00 2018 -0300

    Bug 18959: Skip xt/author/Text_CSV_Various.t if Text::CSV::Unicode missing

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ca9a1b76d8d729b1c09dbedbd90bd3f748351c4b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7d4756c89741958e22714730793cc200e276686f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Sat Oct 13 09:15:52 2018 -0300

    Bug 18959: Text::CSV::Unicode missing from dependencies

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit eb3f78f82e8139739a17c11cc89f58865d7536b0)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9f61b7eb9421d354d2609cefa0a6814e8a2ca478
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 18 16:36:45 2018 -0300

    Bug 21600: Use str param instead of dt for output_pref

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5b9cb7086e74e9a6ea7a4eaac7c5053b6727bb3e)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit dd2c6e4c69ef411a05170abfe92ed60668ac7532
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Oct 18 15:50:27 2018 -0300

    Bug 21600: /patrons should have timestamp/datetime values converted from rfc3339 into valid MySQL values

    Bug 21597 enabled the option so set strict SQL modes in koha-conf.xml to
    be able to improve Koha's comformance to current standards on DB
    engines.

    This causes lots of parts of Koha to fail because they rely on MySQL
    fallbacks that are no longer default behaviours.

    While we can workaround this by setting SQL modes on runtime, the
    decision has been that this needs fixing.

    This patch deals with the /patrons API failing to correctly convert
    datetimes into valid SQL timestamps.

    To test:
    - Run:
      $ kshell
     k$ prove t/db_dependent/api/v1/patrons.t
    => SUCCESS: Tests pass
    - Add <strict_sql_modes>1</strict_sql_modes> on your koha-conf.xml
      $ sudo vim /etc/koha/sites/kohadev/koha-conf.xml
    - Restart memcached and Plack:
      $ restart_all
    - Run:
     k$ prove t/db_dependent/api/v1/patrons.t
    => FAIL: Tests fail due to updated_on and/or lastseen fields wrong
    format (MySQL error)
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/api/v1/patrons.t
    => SUCCESS: Tests pass! It all makes sense!
    - Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 13b8e95f218924cc1ec41e2570791980bd7bcf17)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2d9f2739e953b36d6b48096644d8967018a6f90f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 12 11:27:27 2018 -0300

    Bug 21554: Add missing use statement in subscription-batchedit

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f0373fbdec152c9d766eb82d6af667d1da5cf042)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Installer/PerlDependencies.pm                   |    5 ++++
 C4/Items.pm                                        |    5 ++--
 Koha.pm                                            |    2 +-
 Koha/REST/V1/Patrons.pm                            |    9 ++++++
 .../mysql/fr-CA/obligatoire/sample_notices.sql     |   24 +++++++--------
 installer/data/mysql/updatedatabase.pl             |    8 +++++
 .../bootstrap/en/modules/opac-illrequests.tt       |   31 ++++++++++----------
 serials/subscription-batchedit.pl                  |    1 +
 t/db_dependent/Items.t                             |    6 ++++
 xt/author/Text_CSV_Various.t                       |   20 +++++++++----
 10 files changed, 75 insertions(+), 36 deletions(-)

hooks/post-receive
-- 
main Koha release repository