[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.05-42-g0f719ee

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  0f719ee1b0d87ef7243c0824a1555c9399000cf8 (commit)
       via  4edef313918d8930de54d532089ed66c981bbb6e (commit)
      from  75d6195c0ef36c4da244c4e2e2341696c94642c1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0f719ee1b0d87ef7243c0824a1555c9399000cf8
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Oct 17 01:39:41 2018 +0000

    Bug 21005: Address QA tool failures on tabs
    
    Only whitespace changes.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b2070ef98b74908860556872cc08c0b2ce74b8b1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4edef313918d8930de54d532089ed66c981bbb6e
Author: David Cook <dcook at prosentient.com.au>
Date:   Fri Aug 10 18:08:13 2018 +1000

    Bug 21005: Missing row/column defaults cause unexpected results in report wizards
    
    Some report wizards are missing row/column defaults, which sometimes return blank
    pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning
    user may interpret incorrectly.
    
    If the DEBUG environmental variable is enabled, missing row/column choices will
    actually cause fatal software errors as well, which is also undesirable for users.
    
    This patch adds default choices for row and column on
    report wizards that had no radio buttons selected, so that a user
    can't submit the form without choosing a row and column. This
    prevents errors.
    
    To test:
    1) Apply patch
    2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl
    3) Visit /cgi-bin/koha/reports/borrowers_stats.pl
    4) Visit /cgi-bin/koha/reports/catalogue_stats.pl
    5) Visit /cgi-bin/koha/reports/issues_stats.pl
    6) Observe that default choices for row/column are there
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 6a451360b8fd0a56dd07be050cdecf538d890612)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt   |    4 ++--
 .../intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt   |    8 ++++----
 .../intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt  |    4 ++--
 .../intranet-tmpl/prog/en/modules/reports/issues_stats.tt      |    4 ++--
 4 files changed, 10 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository