[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.05-1-19-g907f898

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  907f8985bbc115645cdb2f5ad2db136064037a92 (commit)
      from  4199b04a836ea574b396a628dc144312a4083d31 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 907f8985bbc115645cdb2f5ad2db136064037a92
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 2 17:50:40 2019 +0100

    Bug 24145: (bug 22543 follow-up) Fix Auth.t
    
    Auth.t is failing because of: 1. recent changes from bug 22543 and 2. wrong mocked CGI->param in tests
    Without this patch we hit the exit statement that breaks the tests with the following error:
    
    t/db_dependent/Auth.t .. 1/22 Un-mocked method 'url()' called at /kohadevbox/koha/C4/Auth.pm line 1223.
    Un-mocked method 'redirect()' called at /kohadevbox/koha/C4/Auth.pm line 1227.
    A context appears to have been destroyed without first calling release().
    Based on $@ it does not look like an exception was thrown (this is not always
    a reliable test)
    
    This is a problem because the global error variables ($!, $@, and $?) will
    not be restored. In addition some release callbacks will not work properly from
    inside a DESTROY method.
    
    Here are the context creation details, just in case a tool forgot to call
    release():
      File: t/db_dependent/Auth.t
      Line: 74
      Tool: Test::More::subtest
    
    Cleaning up the CONTEXT stack...
        # Looks like you planned 22 tests but ran 1.
    t/db_dependent/Auth.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
    Failed 21/22 subtests
    
    Test Summary Report
    -------------------
    t/db_dependent/Auth.t (Wstat: 65280 Tests: 1 Failed: 0)
      Non-zero exit status: 255
      Parse errors: Bad plan.  You planned 22 tests but ran 1.
    Files=1, Tests=1,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.54 cusr  0.24 csys =  1.80 CPU)
    Result: FAIL
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 678b4bf4642852aba0d11af0ba826164ffdfd012)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 t/db_dependent/Auth.t |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository