[koha-commits] main Koha release repository branch master updated. v19.11.00-55-gf115158
Git repo owner
gitmaster at git.koha-community.org
Mon Dec 16 12:33:34 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via f115158d6df03b6238a1b2c22998b8c3a5a4cd07 (commit)
via 9a5ce70d3bf01d91c5864ef7c83273d22e536376 (commit)
via dac488b55f76b511a5c9bd66ced6b1813368c83e (commit)
via b2b9f2ceb87189eab1cbfab8b291afe95101c4b8 (commit)
via 1bd6c7d4571c1e7ad9ea8ee6f456260cb3636669 (commit)
via f4746340c1bf1d6408aedae93d713f49760e1279 (commit)
via f5435839263c31ef1c29e54f244a98ef7cce812e (commit)
via 50bb8e96f10638278dcec9a8eebf52c7f74209f2 (commit)
from 044b6eadd591f6f6c02496ed3d47403cc2d3f7f5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit f115158d6df03b6238a1b2c22998b8c3a5a4cd07
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 13 17:50:59 2019 +0100
Bug 24241: (bug 23049 follow-up) Add description for manage_accounts
Test plan:
Edit permissions for a patron
Unfold "Manage Koha system settings (Administration panel)"
=> Without this patch a checkbox appears without description
=> With this patch you see the description for manage_accounts
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9a5ce70d3bf01d91c5864ef7c83273d22e536376
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Dec 16 11:00:27 2019 +0000
Bug 23233: DBRev 19.12.00.002
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dac488b55f76b511a5c9bd66ced6b1813368c83e
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Tue Oct 22 11:20:39 2019 +0000
Bug 23233: (follow-up) Correct test description
AllowItemsOnHoldCheckout is not checked anymore but instead only
whether the tmp_holdsqueue is empty or not.
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b2b9f2ceb87189eab1cbfab8b291afe95101c4b8
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Tue Oct 22 11:04:48 2019 +0000
Bug 23233: (follow-up) Add description to atomic upgrade
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1bd6c7d4571c1e7ad9ea8ee6f456260cb3636669
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Tue Oct 22 11:00:51 2019 +0000
Bug 23233: (follow-up) Remove accidentally left comment
The line
t::lib::Mocks::mock_preference( 'AllowItemsOnHoldCheckout', 0 );
was removed from below this comment line but the comment explaining
what it does was forgotten.
Signed-off-by: Lari Taskula <lari.taskula at hypernova.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f4746340c1bf1d6408aedae93d713f49760e1279
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jul 1 08:56:09 2019 -0400
Bug 23233: Remove use of AllowItemsOnHoldCheckout from C4::Items::GetItemsInfo
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f5435839263c31ef1c29e54f244a98ef7cce812e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jul 1 07:19:33 2019 -0400
Bug 23233: Remove use of AllowItemsOnHoldCheckout from Koha::Item::has_pending_hold, it can cause false data to be returned
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 50bb8e96f10638278dcec9a8eebf52c7f74209f2
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Jun 28 14:07:39 2019 -0400
Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only
The system preference AllowItemsOnHoldCheckout only affects SIP based checkouts. I believe we should rename it AllowItemsOnHoldCheckoutSIP so it matches AllowItemsOnHoldCheckoutSCO. We should also update the description as well.
As far as I know AllowItemsOnHoldCheckout has never affected anything except SIP traffic. That does not preclude the addition of another AllowItemsOnHoldCheckout syspref that would affect the staff interface, but that would be an enhancement and is outside the scope of this bug report.
Test Plan:
1) Test AllowItemsOnHoldCheckout via SIP
2) Apply this patch
3) Test AllowItemsOnHoldCheckoutSIP via SIP
4) Note there is no difference!
5) Note the syspref description has been update to mention SIP
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 9 +++------
C4/SIP/ILS/Transaction/Checkout.pm | 2 +-
C4/UsageStats.pm | 2 +-
Koha.pm | 2 +-
Koha/Item.pm | 2 +-
installer/data/mysql/sysprefs.sql | 2 +-
installer/data/mysql/updatedatabase.pl | 13 +++++++++++++
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 5 +++++
.../prog/en/modules/admin/preferences/circulation.pref | 6 ++++--
t/db_dependent/Items.t | 12 +++++-------
t/db_dependent/Koha/Item.t | 7 +------
11 files changed, 36 insertions(+), 26 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list