[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.05-1-34-g371723e

Git repo owner gitmaster at git.koha-community.org
Fri Dec 20 16:51:54 CET 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  371723e94e39ad9750831007bf5fe47305e2da65 (commit)
       via  5d78c86daa6ea264f7238792da679cf36bf6b328 (commit)
      from  85a58e6f62a7b5a4eedcebb5e77f6f9776734780 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 371723e94e39ad9750831007bf5fe47305e2da65
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 20 10:56:24 2019 +0100

    Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del
    
    If a bibliographic record is deleted after having deleted all their items in a batch,
    we should not display a "return to the record" button but "return to cataloguing" instead
    
    Test plan:
    1 - Have/make a bib with items
    2 - On details page select Edit->Delete items in a batch
    3 - Select all items and check "Delete record if no items remain"
    4 - Delete the things
    5 - On confirmation screen you have a count of items/bibs deleted
    => Without the patch there is a 'Return to record' button that leads to nowhere
    => With this patch there is a "Return to cataloging module" button
    6 - Repeat using the "Delete selected items" link on top of the items table
    => Without the patch there is a 'Return to where you were' button that leads to nowhere
    => With this patch there is a "Return to cataloging module" button
    
    Note that there is a link AND a button, coming from
      commit 928c0af2b6a2c7aa6ed54019c5bd7dbddbccf4ee
      Bug 15824 - 'Done' button is unclear on batch item modification and deletion
    I do not think it makes sense to have both.
    
    Signed-off-by: George Williams <george at nekls.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 7c5a0759acf5f5a5a51e54f69d65067b6f22a0c5)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 5d78c86daa6ea264f7238792da679cf36bf6b328
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 20 10:53:32 2019 +0100

    Bug 23987: Use src=CATALOGUING for edition/deletion in batch from items table
    
    There are 2 ways to land in batchMod from the detail page of a bib
    record: from the Edit menu, and the action buttons on top of the items
    table.
    
    We want the same behavior for both and so use src=CATALOGUING
    It will make batchMod to behave identically for the "return" button
    
    Signed-off-by: George Williams <george at nekls.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 54e114833260055cd2b0131bc0548f80a5d7ff29)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/catalogue/detail.tt              |    4 ++--
 .../prog/en/modules/tools/batchMod-del.tt            |   12 ++++++++++--
 tools/batchMod.pl                                    |   18 ++++++++++++------
 3 files changed, 24 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list